Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Roger Quadros <rogerq@ti.com>
Cc:     "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
In-Reply-To: <410670D7E743164D87FA6160E7907A560113AE789A@am04wembxb.internal.synopsys.com>
References: <1519730526-22274-1-git-send-email-rogerq@ti.com> <a04fafee-7992-ce8b-55a9-afd4c9935462@ti.com> <69517684-bd39-e945-0c9e-ccd52b8050d5@ti.com> <87y3isffog.fsf@linux.intel.com> <5ea0ad17-d538-72ec-ed59-004242c4cd26@ti.com> <410670D7E743164D87FA6160E7907A560113ABB478@am04wembxa.internal.synopsys.com> <87zi38438h.fsf@linux.intel.com> <410670D7E743164D87FA6160E7907A560113ABBA4B@am04wembxa.internal.synopsys.com> <87d100qwc5.fsf@linux.intel.com> <410670D7E743164D87FA6160E7907A560113ABC945@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560113ABCA0A@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560113AE789A@am04wembxb.internal.synopsys.com>
Date:   Tue, 10 Apr 2018 10:31:13 +0300
Message-ID: <87r2nnldq6.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:
>>>>>>> Actually to fix this issue I updated condition of wait function
>>>>>>> from:
>>>>>>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING)
>>>>>>> to:
>>>>>>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING & DWC3_EP_ENABLED)
>>>>>>
>>>>>> you're not fixing anything. You're, essentially, removing the entire
>>>>>> end transfer pending logic.
>>>>> yes, you are right, but how to overcome this infinite loop? Replace
>>>>> wait_event_lock_irq() by  wait_event_interruptible_lock_irq_timeout()?
>>>>
>>>> The best way here would be to figure why we're missing command complete
>>>> IRQ in those cases. According to documentation, we *should* receive th=
at
>>>> interrupt, so why is it missing?
>>>>
>>>
>>> Additional info on test. Core configuration is HS only mode, test speed
>>> HS, core version v2.90a. Maybe it will help to understand cause of issu=
e.
>>> BTW, currently to pass above describe ISOC OUT test we just commented
>>> wait_event_lock_irq() in dwc3_gadget_ep_dequeue() function and
>>> successfully received request completion in function driver.
>>> Thanks,
>>> Minas
>>>
>>=20
>> One more info: while function driver call dequeue, host periodically
>> send control read command to get status of test from function - test In
>> Progress or Finished.
>> Thanks,
>> Minas
>>=20
>
> Your last dwc3 patch series allow us to successfully dequeuing remaining=
=20
> requests without falling in to infinite loop.

that's cool, thanks :-) I'll just fix the documentation bug I introduced
heh :-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlrMaEEACgkQzL64meEa
mQbvnA/8CBNEQFELdDhKM52NnWdqdhpXAXtNPB2xvWMPhXMXyT10H8aM5S6y1S5I
VNIAk3GcZqWf2Y9aVO362zVhXk0G6MCwtr9oOtd7s2QN/WV6MSPzlRmeyjvT7he2
LN2jOp//hmd1dLhPQfWddB81DQ3ghw2RVXPvo6J7A+ImKnRyAFMQ/3U3/oGUOJMG
6/tPviQ7goLpdg4aQE3n9wCfFPx1IOBWNdduOUq1to6pcseWNGIk0DFS/WcXLz5u
BgtguW8NXbP7XbwThoBpxAC0j1YzD7w8d7l9VfgEM8j8OtUjK2Q0EtlGtVahWqlF
OESUhPUO0Nic87r8FCPPe20hN6T2MZLZJdHLc7EacVSPnYKSLB9PfjhJ7Vx1169f
ufSt0WaPyZDmMM8FyO/7SuxR1a+I5+uVgk+8y/Zkl3vqnbNBetjZSQrQELxJV6dr
W4dzmXfr4WDdN6D++VOTmPGENwcxKOR+LPG+3smfjVIiZIAiNCrGGqSGWfB9PIVP
0hzOMinhjpLpEjFfL6rjjPWI6RN/amDXtLtq4gfXr7Cc24MSHf/x9FHBZm+0djlU
aVN2jS4+C3Ls1fEQz7Ka5ixQf3kAFcVCQB+apvZHK7/5+2im23AoQC9/PPtIkf/J
EH43bpX5M6soi1jnarF4lu8lPPIvwhX4XIXmRj1eNHc6ZTpG4OM=
=l7az
-----END PGP SIGNATURE-----
--=-=-=--