Received: by 10.213.65.68 with SMTP id h4csp3623833imn; Tue, 10 Apr 2018 01:51:34 -0700 (PDT) X-Google-Smtp-Source: AIpwx48O+Bk0YufgrZF/qJ6w8XVRgF5PniR9GtsgvUyjs/AtKRKx1rG5z1IhmdVF829ysO+7id8s X-Received: by 10.99.117.12 with SMTP id q12mr13924049pgc.395.1523350294719; Tue, 10 Apr 2018 01:51:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523350294; cv=none; d=google.com; s=arc-20160816; b=tdrrza7nAW4fdaBeVgZDnSHtkzWKS0bGkdfg9jJHlOOCbP7iPCXJK/UJ/1izeTA7TR VPk0UFhRgvvPuG42Aq2CSOtKNvd/32DsyXCAC+cjK554fpU4yZ0sXlJ97zW4rwEsm2z8 SyDHB7nmIxFDLt35GpjozpPMhLy7ppzHAFI8K2k3AnPDDACQvmk7jZTlJpkpsdKkFOM+ P2gkcYPBlrMisg2aX0DcAuTElTVuA84X5El7iquI2ochPJPlMfyL8LbXgldfeSERPY+c liwDDF8V0uIWx1MG2uXEA7zXkmNU5W+5CP7hg98sYkMfgxweFHNbeLRvJACVixqYK8E5 48HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Lrm0oy3u72lqh7OfKxh5QW75f8a1C0xC99SgAqjp8SQ=; b=qJDh+jigE/4wqpm32D4P2wYhK9fu6W4AndaPEQkJe6QrbjMF+b3EWrv/DdShg09U3i RLyheMKr9J4oeKGDpXxF6KrpbkD8umj1k5QmFIIji1GCdjBXjQYUbs4H9MXUosgfwxKU U5WR0UHVq5FkzYylzjskntlh7sBWWUVlc8s/hdDO49L3hPNnE0kkoX8uzPugzlTqPwqp yNgqeolJYLA0LBBmoe/C9b8P3uhyqBKTpiqqIsIkWcL1fDA3fy1AzhJGXb/t1RIQS2xb A8scPTsyh/1z/4oxDS1m+0JnIfYLJcFq81/VifB/lJ1x3wCQCWGLiqTHop6jkgm+CBdA WChw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wh91j+nH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s194si1474363pgc.578.2018.04.10.01.50.57; Tue, 10 Apr 2018 01:51:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wh91j+nH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbeDJIsC (ORCPT + 99 others); Tue, 10 Apr 2018 04:48:02 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39126 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbeDJIsB (ORCPT ); Tue, 10 Apr 2018 04:48:01 -0400 Received: by mail-wm0-f68.google.com with SMTP id f125so21700616wme.4; Tue, 10 Apr 2018 01:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Lrm0oy3u72lqh7OfKxh5QW75f8a1C0xC99SgAqjp8SQ=; b=Wh91j+nH+s5B7gaAyECcM29vS61sdG+SiSGvhe8KG2em0EiEGPfvpjQiTu1ruxv/cL KZullbgUuQps68QKZGbCe9/EdILdFJYbXC7cqdl/4zAs0OOrMaXGpaz7gi4TtnS0XaD1 jIHpF+8dmLN/JE4L8UerG+sjgKuzMP4AdkxyvCxQG5WqAmHdvQNjLmLKDc4FR7ZiGImh 1pLV0f6ZDdNKiJcoibtK3N5uMsN7xySJvO6wO2hQ/NlSBQ8KCK0hXFMEiUsZ+wDgsLdp yY3H4hITDYMjufYoK49hXVjSX7IyuBii9rKCI5bcpiH4sV0TIQxGSHIU0JWGyIof5Z/F xleA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Lrm0oy3u72lqh7OfKxh5QW75f8a1C0xC99SgAqjp8SQ=; b=b0Zv2q/fmUXLo+N8Lsknq4RRysb84U4F9crlU6GDKrZlAsWH07BdKBLvcs7cTK1Qy2 CEH4S+19f5xqng7yuWMgfgR3EnIVlLtzxyQTAlRLC08jBS6SvnZy6yCkAs6DIn5KNpGb ShSJVaroElyhI1//Xq10UWTp1tY+SQjEg0XPSn5Ixng/eo1HdAmSxw+ta2NbgVbWTQ9b XoQJ8bTvKsdT2PKr1lqKrkFmmVlN4DcoNh4RKmUjeIM11Oop1tk31dZo5/WJAHIeKwBL 46V5RJK7GhDZlSq7yZnHapt3zQFNS6rG/QXSIi9CyIOzUwsv0uZhbj6oiJBC7ohlrp1Z 6d+Q== X-Gm-Message-State: ALQs6tCxvbmfNbs0LNwgnLdbQhO9a6Wzds0lpmBuK2rx2+oqqLcZeFg/ 4poFkndpD94YENa/xhgJ8UnyyzRn6lw= X-Received: by 10.28.66.90 with SMTP id p87mr1010122wma.58.1523350079882; Tue, 10 Apr 2018 01:47:59 -0700 (PDT) Received: from [127.0.1.1] ([83.243.48.53]) by smtp.gmail.com with ESMTPSA id a63sm3245945wrc.22.2018.04.10.01.47.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Apr 2018 01:47:58 -0700 (PDT) From: Tobias Regnery To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tobias Regnery Subject: [PATCH v2] usb: typec: ucsi: fix tracepoint related build error Date: Tue, 10 Apr 2018 10:38:06 +0200 Message-Id: <20180410083806.27874-1-tobias.regnery@gmail.com> X-Mailer: git-send-email 2.16.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is the following build error with CONFIG_TYPEC_UCSI=m, CONFIG_FTRACE=y and CONFIG_TRACING=n: ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_register_port" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_notify" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_reset_ppm" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_run_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_ack" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_connector_change" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! This compination is quite hard to create because CONFIG_TRACING gets selected only in rare cases without CONFIG_FTRACE. The build failure is caused by conditionally compiling trace.c depending on the wrong option CONFIG_FTRACE. Change this to depend on CONFIG_TRACING like other users of tracepoints do. Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") Signed-off-by: Tobias Regnery --- V2: - change condition of trace.o to the right symbol --- drivers/usb/typec/ucsi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile index b57891c1fd31..7afbea512207 100644 --- a/drivers/usb/typec/ucsi/Makefile +++ b/drivers/usb/typec/ucsi/Makefile @@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI) += typec_ucsi.o typec_ucsi-y := ucsi.o -typec_ucsi-$(CONFIG_FTRACE) += trace.o +typec_ucsi-$(CONFIG_TRACING) += trace.o obj-$(CONFIG_UCSI_ACPI) += ucsi_acpi.o -- 2.16.3