Received: by 10.213.65.68 with SMTP id h4csp3797864imn; Tue, 10 Apr 2018 05:01:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/dwp+Lts/c6bxdMqACoGH0axrUgin5fzPfP7excHQTo5kFQFVVA1MJi9LON20dwUUKhor/ X-Received: by 10.101.73.207 with SMTP id t15mr87824pgs.204.1523361675381; Tue, 10 Apr 2018 05:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523361675; cv=none; d=google.com; s=arc-20160816; b=wuFkffWn0DOj0T5D/U0jJtheYPLpGzcB8V5MVf7FxI6OzyehPPJSRyijpkOzmWJwZa wfydnsGiLHF8hpgwspQV6lg1rodHMCrM+7GLevo+Pa6arucPxCbpY73AXXjvW7/1J21s saGQ4JCMtfgdwDOsuYDNsZSJCBFEh/gfH/MmsUiED7LFlFVdYy4jEUAN6IKLYq15k8yK 8fUSvYyrx9Fn+Me4t6CXi6z5Oo6MztWru4FLLcD4veABR89yphMY1eyRsJX+2GC5TnqC MggEMyyLgP8Yqj4alHVTqe1T9SomTvez2AIErBGeBhyjPH1CMqnbiqRlC4Xd7MYMinMW Z59A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=fG94V/vLL9cnChx3/U5ZF8Q4NanzbdrtewEXgpsjoB0=; b=USzmTlyt0cFd79j/dPkg4LtyzWNP60BiuRPu6SYZh+b3kFZv5w7fskiW1/9sE0wfPZ ivYa/xe9DQy0OECM4vA37hN5bSbSN9hlQME7eT/9u8I84yWB59K04TW5RGh2gLhhRUk8 aNg9/0MIGebbFxYIczv9MYgRKzPY7odzHiK7vFcnRqRDeEZzWKmkuyXef97g3/AxZ52W 9ZWWK1ZP0V23b7mpstipthBkX3XfjYAMvbmSWqrd+cjgY1mJAhnm2xYkYcUC2ELOg8pQ 5/SXOphmYWLQ5vq3eMFZUQ3ckT0AqmJNf3JvOotqz+uNwuUe/LSaoOWX5y30AWhYRyNS eC2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=M+bNNoYP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si1914925pfn.237.2018.04.10.05.00.38; Tue, 10 Apr 2018 05:01:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=M+bNNoYP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbeDJL45 (ORCPT + 99 others); Tue, 10 Apr 2018 07:56:57 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41892 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbeDJL4z (ORCPT ); Tue, 10 Apr 2018 07:56:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fG94V/vLL9cnChx3/U5ZF8Q4NanzbdrtewEXgpsjoB0=; b=M+bNNoYPSwJZZwTDokDhp60K+ egenrE89ofUUuxb7Z0hcpG6Hwtumeo+yxI3olasgQIxsGsn5dXzyq3maqu+cYd1otnkCBLobzzboP x+HHr7vjenAXe1IcfZahk8Uy5kOZUJffKnoJ275Gw7LxImiv0gTUjJ/qei6D9V0u/DH24U3Ch9BwC FUoZx8w4Pd11MuV2jPh+x04g82seCS6SvRLOn6OtqvOUV3woqkXNx4EsBLtVFNTzLQbZnKKnD0zzX oUim+fx20C7wOj/sp7iXlPiauFS1XcL1GygZOccyUUagKyokesejY917PdmD36tTu9s9e1ga8ofQo xd1fUgWEQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1f5rtM-0007GI-0H; Tue, 10 Apr 2018 11:56:52 +0000 Date: Tue, 10 Apr 2018 04:56:51 -0700 From: Matthew Wilcox To: Minchan Kim Cc: Chao Yu , Jaegeuk Kim , Christopher Lameter , Andrew Morton , linux-mm , LKML , Johannes Weiner , Jan Kara , Chris Fries , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mm: workingset: fix NULL ptr dereference Message-ID: <20180410115651.GA22118@bombadil.infradead.org> References: <20180409111403.GA31652@bombadil.infradead.org> <20180409112514.GA195937@rodete-laptop-imager.corp.google.com> <7706245c-2661-f28b-f7f9-8f11e1ae932b@huawei.com> <20180409144958.GA211679@rodete-laptop-imager.corp.google.com> <20180409152032.GB11756@bombadil.infradead.org> <20180409230409.GA214542@rodete-desktop-imager.corp.google.com> <20180410011211.GA31282@bombadil.infradead.org> <20180410023339.GB214542@rodete-desktop-imager.corp.google.com> <20180410024152.GC31282@bombadil.infradead.org> <20180410025903.GA38000@rodete-desktop-imager.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410025903.GA38000@rodete-desktop-imager.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 11:59:03AM +0900, Minchan Kim wrote: > Okay, I hope this version clear current concerns. It doesn't. The right place to warn about GFP_ZERO used with a constructor is _slab_, like the patch I already sent. We have no idea what other places might have the same bug, and slab is the only place to catch that.