Received: by 10.213.65.68 with SMTP id h4csp3875564imn; Tue, 10 Apr 2018 06:06:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx48YnkWyrdlp6k7Wpk3/Zya7m6ZVC0+MHNzs4Q3MtyG6Qe80pWcK0o+Vp9wJf4h3UvC39man X-Received: by 2002:a17:902:bf08:: with SMTP id bi8-v6mr367584plb.392.1523365564337; Tue, 10 Apr 2018 06:06:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523365564; cv=none; d=google.com; s=arc-20160816; b=F/PEVysRBIaeOSb27k0DC6ERXmFohndjCiUNIvJ7j5XogswqtnxKtfL5N8YcRwVczh MCY2dYkVytRYt1DXCONQw5xfbaug4Z78WUL+m9S6bpG6W3NeP6ZhT1ldHw8kxIFcFmpy ygwj2vchIdLO+ZK1KItVKAUMa4HBiXQUdJXq0E2XoEKTNL+kD2cbRf3mPrtOKcEt1LVJ /lf/GWLiibxjCtDyZD9uZCGp4QHxEHyU77ppK068yLSwaljhS/uWBvs6XhTWP8wSXMvr yM6wQvAdCkacmbEKCZLPCwI4Jk/9GjQpuqUri/XKBmnfwtVHaF+kWt58TLDt5Is1UmVJ 2dYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=kunZC+qenBih+JDW7yYSjE/qY6D7Uzn5UlxjlxO2N0k=; b=im3uJicc/btNuH53SZ6HO9W11Gvl6XbIPNV+XKTm4Ulu04YZRrm2vx/IuAHfyGQUiF XzjcXCXmdivNoHSa2YA+0lGOahaK0tqZVXX69hcehb8pYg+Ea6U4Pcz3iHrbM+oLZYFl 6oC9U0ofOtlcxAw6wf928et6A7uekym5EjAZnG2Wd3GJ1pYz75sAWAMcnhngER/5h+ta 1nh7OavbUocL1wtD/K7QT7885NqRjNngLu7f/ChRMkx8e3Dw4lAubUgiiQqE7wHiJ+2t 075lMcaq4n/uI+Sv41zhWwYMbYasvop7zfJhrT9XKyTcfinREHWiq5YqL9chKutu2RUp RYEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@cmpxchg.org header.s=x header.b=Iu5Ioszq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z79si2152299pfa.120.2018.04.10.06.05.27; Tue, 10 Apr 2018 06:06:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@cmpxchg.org header.s=x header.b=Iu5Ioszq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753727AbeDJM7M (ORCPT + 99 others); Tue, 10 Apr 2018 08:59:12 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:50940 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbeDJM7J (ORCPT ); Tue, 10 Apr 2018 08:59:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kunZC+qenBih+JDW7yYSjE/qY6D7Uzn5UlxjlxO2N0k=; b=Iu5IoszqDzRRQiAjH63w/Zpxne 3WGy6TSvNYOrZmsEbH4KwdKJhKg5ANOGBoiLQk7nwqiUSlWVTsrj8PxK3Mh+pttmjgXGpTDcehyvx tReWOh8mCo1Rm7hEWrxSgQQSdG/OqS+svIC5vmmRYjvQnmFfa8HbSXfp5ml9ObuvVk44=; Date: Tue, 10 Apr 2018 09:00:19 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: linux-mm@kvack.org, Matthew Wilcox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Mel Gorman , stable@vger.kernel.org Subject: Re: [PATCH 1/2] slab: __GFP_ZERO is incompatible with a constructor Message-ID: <20180410130019.GA7010@cmpxchg.org> References: <20180410125351.15837-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410125351.15837-1-willy@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 05:53:50AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > __GFP_ZERO requests that the object be initialised to all-zeroes, > while the purpose of a constructor is to initialise an object to a > particular pattern. We cannot do both. Add a warning to catch any > users who mistakenly pass a __GFP_ZERO flag when allocating a slab with > a constructor. > > Fixes: d07dbea46405 ("Slab allocators: support __GFP_ZERO in all allocators") > Signed-off-by: Matthew Wilcox > Cc: stable@vger.kernel.org Acked-by: Johannes Weiner