Received: by 10.213.65.68 with SMTP id h4csp3900904imn; Tue, 10 Apr 2018 06:25:54 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+sv4+LEF9CSxEe/uQcGqPwB0Tkvx8G17jS2a5ImXIprVkWNQBv++hz88X1DM7eIvx3oqpv X-Received: by 2002:a17:902:b60c:: with SMTP id b12-v6mr421931pls.203.1523366754177; Tue, 10 Apr 2018 06:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523366754; cv=none; d=google.com; s=arc-20160816; b=0gmwEa3kY0BvIYZLKlQoBM+58diTYlELth/XjwRXoPmwU65JqEHvpm03l15wzV6A+x zrnCZ0LGNUj/B3wpzd6w2Nge6AaOWPAoV+8ls/fVDYVMXzyVKgd8KApbOYwB6JdTlDdO KHT+UXUjvsUnI/WP7BEHhGeO1LdjlyETjZXUetWSAk+JXCcm82eJcFEwjlTSNPsk+DJQ sJ/byow7095PqWMP8os4NK/na88KctEmxFN1XgCMk1zq3nlq9SZFROgcehed8d/j0Kpz q+LG69Ju0zf35iQn5Liuv9UGCFxUpUVbTrPDCfR8XrgrhybhqbOPSjmvC+4NVVERTbym MCGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=eQqAR1O+RVvN/DVopXY1ZXsGFxLzcTPOHyVGQydk+vM=; b=PhQBzZ/kcFv0Ty30aTRSJR4yx6abXIJcYnE3QbNvZSwWGPzn0F2EXGwjdmPlQb0Grf deg+uh8pzG6z8U9fdfnSxMQMRX6EEMdrwcDprqfEL8byr/BC3WBd9SEf1KtiEhG77OwV ZIi6NEs/V1aeCxniQMIZfmvwiEsKla3xHC/hP+PBCgqSoTImuIITmLsr6UKyApzo2P4g aZfNCGLfb7hK5fPXZmHZbDJllCOVQuwxZ5ZGRLRe/ADijp2WehSg4wMRvR13joM23qIt 6IB4kA99kkr83lVsJZ6CpUGYlsECjbOWPCCoq0jeheql0eVHgXekHr7QlGGsIc48KIW9 RCkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si1797986pga.391.2018.04.10.06.25.17; Tue, 10 Apr 2018 06:25:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753720AbeDJNSU (ORCPT + 99 others); Tue, 10 Apr 2018 09:18:20 -0400 Received: from gloria.sntech.de ([95.129.55.99]:55562 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbeDJNSR (ORCPT ); Tue, 10 Apr 2018 09:18:17 -0400 Received: from wd0542.dip.tu-dresden.de ([141.76.110.30] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1f5t9t-0005Ap-VW; Tue, 10 Apr 2018 15:18:02 +0200 From: Heiko Stuebner To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Rob Herring , Frank Rowand , Daniel Lezcano , Thomas Gleixner , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Thierry Reding , Jonathan Hunter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] soc: rockchip: power-domain: Use of_clk_get_parent_count() instead of open coding Date: Tue, 10 Apr 2018 15:17:56 +0200 Message-ID: <7442109.yKeQIlf4qX@phil> In-Reply-To: <1523364701-15383-4-git-send-email-geert+renesas@glider.be> References: <1523364701-15383-1-git-send-email-geert+renesas@glider.be> <1523364701-15383-4-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 10. April 2018, 14:51:39 CEST schrieb Geert Uytterhoeven: > As of_clk_get_parent_count() returns zero on failure, while > of_count_phandle_with_args() might return a negative error code, this > also fixes the issue of possibly using a negative number in the > allocation below. > > Signed-off-by: Geert Uytterhoeven Depending on how we plan on merging this series, I could either pick this patch for 4.19, after patch1 makes it into 4.18 or otherwise someone could pick the whole series together with my Reviewed-by: Heiko Stuebner for this patch. Heiko