Received: by 10.213.65.68 with SMTP id h4csp3940471imn; Tue, 10 Apr 2018 06:58:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/6E33W00YtD1dnswAjViVYo6N3u7MmN9p6uDp2DNM8IARx7MgBfYLUXbQTJ4AEORytJ5Ye X-Received: by 10.99.119.133 with SMTP id s127mr366732pgc.441.1523368729625; Tue, 10 Apr 2018 06:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523368729; cv=none; d=google.com; s=arc-20160816; b=J5TWV/ELae8IRAcu06Qr8VkSGnZJtXe6ZbXt67H+oSHJyM27grz8x2HKu22GQlAVCq jX4oxYuE/+WrZUWSVh2JpYgMnIxegnOR4UjrpjpQlfas2xTKTs3v+EVOhVUM4HZvfHow SQ1DvLX09tB2BB0A6xR4yJL/THeeQsySkO7B96yy4GbG/KGLmJSWW7DZ8/hQ4Oqb/rWz mnKnb3WVAV6s/VbmX2lyKqDqCSNvTHAm5JVY6OJ/pn6XvxguNsSQCOGnpM/zRz6pkwBq iKieskpNywPYjS1lQBVsMbUUp75HhHvVwoJcxKMrqRuLyUn4Cj34NWNQUGis4/zh0tC6 U35g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=b0/k1ECzSMsmawRGI9xcwiinxQ8YOkaSnrAdJZ1CaTs=; b=y9dHV6l2j2+9RzaDxwPlyrNB6pkpNXHHil88hCNWEf1VZ46n4nJIdALZhGycOPrWnY znIJqczjsFIGEr1g7YQg2FrBPy6Ko0EMiDq5lsuKKxUKxAXjgGdS+p7fUH2+MZIxhXTg WcoS8UGcKHBSibuIk/kNI63dCT1yaIiyiPLd9rNrapJA/FgixmEXSXYQ4s0YD2DJ4D5y cxmFGzP9TVEMjXf03pkzcs5gg7H3MwJ405AjZhyk1ma3Hik2Ppb35GJCtMtb2Rw7qmee q2kBaTpYFrZnqTF3rXi0KRhslfFM44Acf4UiI5mLYSfSvEH9mLK/T35zz1nZxbTEdTxA NOKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p20si2164628pfi.345.2018.04.10.06.58.11; Tue, 10 Apr 2018 06:58:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754471AbeDJNxo (ORCPT + 99 others); Tue, 10 Apr 2018 09:53:44 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:48296 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753081AbeDJNxk (ORCPT ); Tue, 10 Apr 2018 09:53:40 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w3ADigxu020221; Tue, 10 Apr 2018 15:53:22 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2h8cecvvhw-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 10 Apr 2018 15:53:22 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1099A38; Tue, 10 Apr 2018 13:53:21 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E90C74E0F; Tue, 10 Apr 2018 13:53:20 +0000 (GMT) Received: from SAFEX1HUBCAS22.st.com (10.75.90.93) by SAFEX1HUBCAS23.st.com (10.75.90.46) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 10 Apr 2018 15:53:20 +0200 Received: from localhost (10.201.23.32) by Webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 10 Apr 2018 15:53:20 +0200 From: Philippe Cornu To: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , Dan Carpenter , David Airlie , , CC: Alexandre Torgue Subject: [PATCH] drm/stm: ltdc: fix warning in ltdc_crtc_update_clut() Date: Tue, 10 Apr 2018 15:53:12 +0200 Message-ID: <20180410135312.3553-1-philippe.cornu@st.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.32] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-10_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the warning "warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL. Many thanks to Dan Carpenter for the bug report https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html Signed-off-by: Philippe Cornu Reported-by: Dan Carpenter --- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 061d2b6e5157..e3121d9e4230 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc) u32 val; int i; - if (!crtc || !crtc->state) - return; - if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut) return; -- 2.15.1