Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: x86-tip.today (4cdf573) early instaboot
To:     Mike Galbraith <efault@gmx.de>, Ingo Molnar <mingo@kernel.org>
Cc:     Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Dave Hansen <dave.hansen@linux.intel.com>
References: <1523347959.4724.2.camel@gmx.de>
 <20180410085917.bo526ueprf7zfare@gmail.com> <1523363877.4942.2.camel@gmx.de>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <430ee27a-fbef-9717-792b-bbd06b04996f@amd.com>
Date:   Tue, 10 Apr 2018 09:06:44 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1523363877.4942.2.camel@gmx.de>
Content-Type: text/plain; charset=iso-8859-15
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 14:06:54.5746 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 09476b02-2a4f-45b8-4028-08d59eec514c
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0175
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/10/2018 07:37 AM, Mike Galbraith wrote:
> On Tue, 2018-04-10 at 10:59 +0200, Ingo Molnar wrote:
>> * Mike Galbraith <efault@gmx.de> wrote:
>>
>>> Hi Ingo,
>>>
>>> FYI, my i4790 box reboots immediately.. or close enough to it that you
>>> see nothing at all before again meeting the bios splash.  Master with
>>> the ~same config works fine.  I haven't poked around yet (work).
>>
>> Hm, so there's been a few 'dangerous' pieces of work merged yesterday-ish.
>>
>> Prime suspects would be:
>>
>>  triton:~/tip> gll linus..x86/pti
>>
>>  0564258fb2cf: x86/pti: Leave kernel text global for !PCID
>>  a5df4f1f0d78: x86/pti: Never implicitly clear _PAGE_GLOBAL for kernel image
>>  e0bb456e3250: x86/pti: Enable global pages for shared areas
>>  efad2b415152: x86/mm: Do not forbid _PAGE_RW before init for __ro_after_init
>>  4ddee6efdcd0: x86/mm: Comment _PAGE_GLOBAL mystery
>>  e71e836f463d: x86/mm: Remove extra filtering in pageattr code
>>  64c80759408f: x86/mm: Do not auto-massage page protections  <== WOOF
>>  6baf4bec02db: x86/espfix: Document use of _PAGE_GLOBAL
>>  8a57f4849f4f: x86/mm: Introduce "default" kernel PTE mask
>>  606c7193d5fb: x86/mm: Undo double _PAGE_PSE clearing
>>  d1440b23c922: x86/mm: Factor out pageattr _PAGE_GLOBAL setting
>>  ee1400dda318: Merge branch 'linus' into x86/pti to pick up upstream changes
>>  071ccc966ba5: x86/entry/64: Drop idtentry's manual stack switch for user entries
>>  9820e1c3376c: x86/uapi: Fix asm/bootparam.h userspace compilation errors
>>
>> ... which you could test via 0564258fb2cf: if that insta-reboots too then 
>> 9820e1c3376c^1 is expected to work and 4 bisection steps should pinpoint the 
>> guilty commit ...
> 
> Thanks.  I already had a full bisect running, so ended up doing more
> than 4 steps, but ended up at the above.

Just out of curiosity, can you try the following patch and see if it
fixes your reboot issue:

diff --git a/arch/x86/boot/compressed/kaslr.c
b/arch/x86/boot/compressed/kaslr.c
index c5196d2..a0a50b9 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -55,7 +55,7 @@
 extern unsigned long get_cmd_line_ptr(void);

 /* Used by PAGE_KERN* macros: */
-pteval_t __default_kernel_pte_mask __read_mostly;
+pteval_t __default_kernel_pte_mask __read_mostly = ~0;

 /* Simplified build-specific string for starting entropy. */
 static const char build_str[] = UTS_RELEASE " (" LINUX_COMPILE_BY "@"

Thanks,
Tom

> 
> 	-Mike
>