Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Nisar.Sayed@microchip.com>
To:     <phil@raspberrypi.org>, <Woojung.Huh@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <agraf@suse.de>,
        <tbogendoerfer@suse.de>, <netdev@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] lan78xx: Don't reset the interface on open
Thread-Topic: [PATCH] lan78xx: Don't reset the interface on open
Thread-Index: AQHT0MYPbZtiT4HsgkyLpriGu/5z6qP6CNcQ
Date:   Tue, 10 Apr 2018 14:16:23 +0000
Message-ID: <CE371C1263339941885964188A0225FA3A3F82@CHN-SV-EXMX03.mchp-main.com>
References: <1523362705-30032-1-git-send-email-phil@raspberrypi.org>
In-Reply-To: <1523362705-30032-1-git-send-email-phil@raspberrypi.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks Phil, for identifying the issues.

> -	ret = lan78xx_reset(dev);
> -	if (ret < 0)
> -		goto done;
> -
>  	phy_start(net->phydev);
> 
>  	netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
> --

You may need to start the interrupts before "phy_start" instead of suppressing call to "lan78xx_reset".

+             if (dev->domain_data.phyirq > 0)
+                             phy_start_interrupts(dev->net->phydev);

- Nisar