Received: by 10.213.65.68 with SMTP id h4csp4009997imn; Tue, 10 Apr 2018 07:57:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+bRuXSOKhzEBHaB1x6tfRphdZZ6ee2qAScl/muELaQ3e+mCiSXJlVhjBkiCQK7kuHTm8EA X-Received: by 2002:a17:902:227:: with SMTP id 36-v6mr808832plc.134.1523372241460; Tue, 10 Apr 2018 07:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523372241; cv=none; d=google.com; s=arc-20160816; b=JX0RX86oD1wl+eYmbw3I88M9iaadpNIkJ5BLYgh2K8Z6wSrkdJXxbrk7xT+E4XhNUE jA2vJPRI9gPZ2YFoFpWlMQ75avTotrXGVHIZBlw9g7e6RqO9/2FMTmQ/SQgCkDg2Vs2V MxRB6QlsmU83X2nSyhpT5EBFVPUzq9FgRsrrKgKmdPQdQks0u0NWZDO8Z5C+tdLfGoEr yHq72jxZeGerZHlAqD0GD2/LzBdtnaHuJEd9MUsjE5sfnw4TLs9ICOOf5lYKZfQAXj13 81FWJ6E3INkVFjOA0H0FzWEKyR4hqMZLnnAoCcig7iSJ/9+sL55ZPNROK6c57Nx65sln 6Axw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=iwladvjTQtcX7qa7ZIDTzv3AGy+utGHNJmh0eT91r9U=; b=yLIWMWtklbYtFYqP11oXVMa1nWXVH8S/G2ble75ggu1QG9V6jFWDKM3NaMqYv7X95U GZCxwU0cVF1Eyheoqos4OioMkd/Ta1dTPeOMcl5dRCphSo7eTDVFzWuwtbq771Lfs5gV fxQqoSJY5E+N9ckdZX5KvF84PYtFLK2zIdpDZ3QbchVrDRUqtrW4Dny4UdQBQz+Dd+77 tohhQv5Dk+x1vHqRIeYokUaHDE56clbCNKKS0H+8RUoaTgOomPojVTEOx+CbNqU7etFI jNdgHMQoxPEuwVIkp7Xlict4ly+CFyecKp5FrHw/+XBkXv0Rs2GUVJiIgE3Lvp+ubZc3 IfNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v23si2250412pfk.116.2018.04.10.07.56.44; Tue, 10 Apr 2018 07:57:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754255AbeDJOus (ORCPT + 99 others); Tue, 10 Apr 2018 10:50:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753562AbeDJOup (ORCPT ); Tue, 10 Apr 2018 10:50:45 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5430B10999B46; Tue, 10 Apr 2018 07:50:44 -0700 (PDT) Date: Tue, 10 Apr 2018 10:50:43 -0400 (EDT) Message-Id: <20180410.105043.1798364865868187298.davem@davemloft.net> To: jasowang@redhat.com Cc: stefanha@redhat.com, virtualization@lists.linux-foundation.org, syzkaller-bugs@googlegroups.com, mst@redhat.com, torvalds@linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check From: David Miller In-Reply-To: <8642c057-e49d-d95d-19e5-6d304f20064e@redhat.com> References: <20180410052630.11270-1-stefanha@redhat.com> <8642c057-e49d-d95d-19e5-6d304f20064e@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Apr 2018 07:50:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Tue, 10 Apr 2018 14:40:10 +0800 > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: >> v2: >> * Rewrote the conditional to make the vq access check clearer [Linus] >> * Added Patch 2 to make the return type consistent and harder to misuse >> * [Linus] >> >> The first patch fixes the vhost virtqueue access check which was >> recently >> broken. The second patch replaces the int return type with bool to >> prevent >> future bugs. >> >> Stefan Hajnoczi (2): >> vhost: fix vhost_vq_access_ok() log check >> vhost: return bool from *_access_ok() functions >> >> drivers/vhost/vhost.h | 4 +-- >> drivers/vhost/vhost.c | 70 >> ++++++++++++++++++++++++++------------------------- >> 2 files changed, 38 insertions(+), 36 deletions(-) >> > > Acked-by: Jason Wang This sereis doesn't apply cleanly to the net tree, please respin and add the appropriate Acks and Fixes: tags that Michael and Jason have provided. Thank you.