Received: by 10.213.65.68 with SMTP id h4csp4032028imn; Tue, 10 Apr 2018 08:14:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx487sXlYeeCxuj/0z3csyncujSd+WnE64NVeL9qGWIkmCqpByzCvOVl1x+6r3P/HHQu2478X X-Received: by 10.101.86.199 with SMTP id w7mr632278pgs.34.1523373278734; Tue, 10 Apr 2018 08:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523373278; cv=none; d=google.com; s=arc-20160816; b=yADsE1wweFb6hRsc/zT515Wbo36+mYla+Q2c/nBdR/Bbw76HtNMNqC+gBTzlD6trtq bMCadXPuOQ835MbYyGQDvVwShENtneUnbzbZzpSRVVKVGt9bMOvJAMyezkoL4USrHy91 iZ04+S1x/Pr7My5U2hmHGMRUruWubPFL/mHpKXLE5UOUNuL8EBmDdPUVawixUPhhSIMG hCU9gpYpu3zs5j78EXtYvIlw3aglWxlEQ1JDqwN9q5b+Ll6CXlQNl5tdVh94mZs39OGP tYRFc3XNML6xDMB1sKLc40b3cDgqwIk63aknn3Ptjq3bxRWOPtlwoc3F1JWAXmyTLgUO ZCJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=p8uMla3Gvj0F6iCw0yARgTpHhqkKfIwpgXcF/vOo1b0=; b=J+h+tT8hzu4P4IcinSgjIFKD4Mz3MdeCBcnYN4MCakyM3ZsosVC4nELeJkeceQ0gkE 4q/CdFHI0Sa3EZa596QYBzKVrlKJhkIyETksALH32pLG00xNJlgJKRluf65zK2IoF++E uboOBqL4TVH3GzP6QRupjQAI/v8K6a29xOFCsMw+OuqXjQJE6oKDYVeQuloT8KbNnhVW s1JZelMRu0xU4+7omr99hza7+h8XWChY1vWHC4W7VPdCtQRyUUC5OUscsi/JhrLY8AY4 F1AvXjNAhqQ6/z5aJSXk9ULCiLiIQai+0Qtg2eptw4PYAiRugcxshS00kQ0gOh+c3y4U Nfiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7-v6si2783758plf.552.2018.04.10.08.14.00; Tue, 10 Apr 2018 08:14:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbeDJPLI (ORCPT + 99 others); Tue, 10 Apr 2018 11:11:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33950 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbeDJPLG (ORCPT ); Tue, 10 Apr 2018 11:11:06 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3AFAtOT029257 for ; Tue, 10 Apr 2018 11:11:05 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2h8v0fusg9-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 10 Apr 2018 11:11:05 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Apr 2018 16:11:02 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 10 Apr 2018 16:10:54 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3AFArGJ57213034; Tue, 10 Apr 2018 15:10:53 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 215B0A4040; Tue, 10 Apr 2018 16:03:12 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 05203A404D; Tue, 10 Apr 2018 16:03:11 +0100 (BST) Received: from [9.101.4.33] (unknown [9.101.4.33]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 10 Apr 2018 16:03:10 +0100 (BST) Subject: Re: [PATCH 2/3] mm: replace __HAVE_ARCH_PTE_SPECIAL To: David Rientjes , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Jerome Glisse , mhocko@kernel.org, aneesh.kumar@linux.vnet.ibm.com, akpm@linux-foundation.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, Jonathan Corbet , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Vineet Gupta , Palmer Dabbelt , Albert Ou , Martin Schwidefsky , Heiko Carstens References: <1523282229-20731-1-git-send-email-ldufour@linux.vnet.ibm.com> <1523282229-20731-3-git-send-email-ldufour@linux.vnet.ibm.com> <20180409175757.GA12938@infradead.org> From: Laurent Dufour Date: Tue, 10 Apr 2018 17:10:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18041015-0012-0000-0000-000005C933E2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041015-0013-0000-0000-000019456010 Message-Id: <3a330851-d545-ebd8-e74c-c44e12220c24@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-10_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804100146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2018 22:08, David Rientjes wrote: > On Mon, 9 Apr 2018, Christoph Hellwig wrote: > >>> -#ifdef __HAVE_ARCH_PTE_SPECIAL >>> +#ifdef CONFIG_ARCH_HAS_PTE_SPECIAL >>> # define HAVE_PTE_SPECIAL 1 >>> #else >>> # define HAVE_PTE_SPECIAL 0 >> >> I'd say kill this odd indirection and just use the >> CONFIG_ARCH_HAS_PTE_SPECIAL symbol directly. >> >> > > Agree, and I think it would be easier to audit/review if patches 1 and 3 > were folded together to see the relationship between the newly added > selects and what #define's it is replacing. Otherwise, looks good! > Ok I will fold the 3 patches and introduce a new one removing HAVE_PTE_SPECIAL. Thanks, Laurent.