Received: by 10.213.65.68 with SMTP id h4csp4187662imn; Tue, 10 Apr 2018 10:35:16 -0700 (PDT) X-Google-Smtp-Source: AIpwx48Vw5NCdpbcLQxfXfJWNUBEDTC7aDFlUdUCTo+P8XkRjow9Es3YRxg+FL3vVrxv6q3c0hTh X-Received: by 2002:a17:902:8490:: with SMTP id c16-v6mr1412700plo.132.1523381716145; Tue, 10 Apr 2018 10:35:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523381716; cv=none; d=google.com; s=arc-20160816; b=gFSxmVPor5QmEDVAB0XYBabBuOblg40xszW69tSZdt+2TRYB8kv3zttPB8nXZ4e0oe ukPB9sOuR7xoVkykGmVgBYUQHhWHdRKCtgIImAupvbnh1pbW6QR9eACkWBm/AZFRhH3K raIzpdM3CVgM/rU5JHWkWcRyES2l3SXOeUYT3NtZLXmefm4S/GZJUlRhKH9kVLta2FOP KGn7j0P5lziq2TjtWJsrHdgGsyO/WD+qHiwlIcUFKX8BREcanzAdycRJOKTXeRIlOcum ED9eW3yVsYzwRTvlxUJu8a2D2Pv0ApD19gMYK1gPpNDOYt67XS5Iy257XKDEb4k0DEjY /8bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=y0YfzCp6PG1/Tkx+vRCawXy1qOB+8RC8LR+yTEES7VA=; b=PIhsRTX1vex0UZ1jyYkacd3JR4YyT2OA3Twlhc1Iu/MbitkNeOyOxxZlScCUutyGja oiqqrBRRA8oRjSeKLBsPOWgMAPww4haNWn1j3SL+Dno3txgDQraHk2qSYj5CFyWj9MqE 0U/XBSJ9jUh4n6vxAw23dXh9Vrz8+X4Vy+alHSU8H14TqQWP3EQaxAPR7GkeKCxescai xAQ1HG54tzvu3qAIVtjIzdGdXrhJzGVOwgVxKjyOoz53oJVE+fLPsTKPmilEM0UCFiRF mUOIMfZPD/deXt39l87yjttnmByn6hvKSqICEAXGsl4ogJGVZHnug5mXSuOl2viKHICl tV9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p13-v6si3145377pll.416.2018.04.10.10.34.38; Tue, 10 Apr 2018 10:35:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbeDJRa2 (ORCPT + 99 others); Tue, 10 Apr 2018 13:30:28 -0400 Received: from resqmta-ch2-10v.sys.comcast.net ([69.252.207.42]:42830 "EHLO resqmta-ch2-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbeDJRa1 (ORCPT ); Tue, 10 Apr 2018 13:30:27 -0400 Received: from resomta-ch2-16v.sys.comcast.net ([69.252.207.112]) by resqmta-ch2-10v.sys.comcast.net with ESMTP id 5x5kfZIXCueeM5x6AfXWsW; Tue, 10 Apr 2018 17:30:26 +0000 Received: from gentwo.org ([98.222.162.64]) by resomta-ch2-16v.sys.comcast.net with SMTP id 5x67fdGxnVfQA5x68fwDJt; Tue, 10 Apr 2018 17:30:26 +0000 Received: by gentwo.org (Postfix, from userid 1001) id DA8C51160B41; Tue, 10 Apr 2018 12:30:23 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id D821811600FD; Tue, 10 Apr 2018 12:30:23 -0500 (CDT) Date: Tue, 10 Apr 2018 12:30:23 -0500 (CDT) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Matthew Wilcox cc: Eric Dumazet , linux-mm@kvack.org, Matthew Wilcox , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Mel Gorman , stable@vger.kernel.org Subject: Re: [PATCH 1/2] slab: __GFP_ZERO is incompatible with a constructor In-Reply-To: <20180410165054.GC3614@bombadil.infradead.org> Message-ID: References: <20180410125351.15837-1-willy@infradead.org> <20180410165054.GC3614@bombadil.infradead.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfMT783t3W6VDnS5BMNi/dXae33+W6vKnGhR+4E6OtmIeuLQBz2eQrDhJeFxz/Ds14d+R12UAtRvAiJla837yr1wnifThlbeTskDdinZVC8A/sSbs20UX ma265iMQQKAk8GhZtA0pUJyLUFVXBpXbLxDxOWwPEausom3SgMVid4CEpVapGe3Dxisl9kpWUCL81A/OVSVq1AUu4qNP/02nW6WkyW/eec+FQiLra5gQhVwv 4WbJOeFshglwcm/UO5rbqceXg2dI47GT23n3nQppR+IqYx0hG0PhaGWfMlG3/bCWHgEiQW3h7kIDo7RFviWkV46OZhm6qnYg06Xv4+Mg7lr/KSZPVHzOsH55 Rr37SXYx2ZLA5Vv+MZHG3nJXl2Bkz4YC9QNKHwqwk8ye4CqHxaGumJzHW8OA2A7UbEwyKCVZlUtqilWNWXcWU1l2xMYNQLKt6PqpJSCPLPEfdDwOzQH9BHYf F86iK7RUPBk3sXWorZ4ZQZn20+qNdkWpnQAz7FAcou3WYKSTcZh/W+1/N1OrfgmnkTZxT8xYgyRaI9vaBo05Gz6OQwU+xetpsUsiCw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Apr 2018, Matthew Wilcox wrote: > If we want to get rid of the concept of constructors, it's doable, > but somebody needs to do the work to show what the effects will be. How do you envision dealing with the SLAB_TYPESAFE_BY_RCU slab caches? Those must have a defined state of the objects at all times and a constructor is required for that. And their use of RCU is required for numerous lockless lookup algorithms in the kernhel.