Received: by 10.213.65.68 with SMTP id h4csp4383764imn; Tue, 10 Apr 2018 14:05:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx49TTb1pBtc5tAssXhkdGODVlfhyh2PGJWYFtGfOQNaD8mdranlY3AuPzpUAVhUKCAj/bY7S X-Received: by 10.98.204.214 with SMTP id j83mr1662134pfk.182.1523394315417; Tue, 10 Apr 2018 14:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523394315; cv=none; d=google.com; s=arc-20160816; b=lnrLZK0Avyt8DcKDRwYbFH8rJWt26sfX1R7DOcgZ41B0ZGI613kho/bdbFcO0WlPGZ VBdC1gsMqMpkb0ybLNFJ6esb9nNekkNif0hOErmHDfCeeBVGdaBhlwMS078iyShKD34I +kjwZFqonMq8dZQGGvHabgmevslI8tzyBqJ96r4caqeMbVPA1Zr9jvpz04Ib/QACiOCS MLybFpOvXw6O8yzxL/HcSz/YoeuyogeOce6scgR1B25WwZpVghQaxKd0gKpkBeBvXZKT ADZVOKQY/R1WQxmY+CRnocJWC/RCpgX6dsWltHYq+nemKWLyDEwV+7auFrozGE+tPxAC FlRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:date:message-id:in-reply-to :references:from:subject:cc:to:arc-authentication-results; bh=6EPc5FJFYbtJtr1pd8BGRIqplYvwLQq7saxNpJOpRF0=; b=RfQRfzBn/MvIqc2pmKgO+VQzV4daj3cCtHxlZfSDRiVQ+X0q+0Ndco2L2JKuDe3WRz Hpdjlk/asxF2/KAlFIoxoRQHUw5hgVZoz3xa7o55X6RRk7Ym9ZPvSL5/ZodYM8xYmmeB D/zIORAULtdVd0xdcrnPWuvrZ1vug3/vS9j0Iwh7LeUOwdhiUWAcg3AsAUwkaMv0a9DA j+ZZE2L9SGJ+adlYu6AlMYJU7vtqSWUulzluKgWNeR008dNtIDhO5VcRfKMMiSdmtnkB bmhLxK+cFMMvT/WhZ+6K6bFvWEWZiVtnB6T6MkAZbxsRgq3MFbunyM7jnjsyhJAHjXup 9k6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si2625730pff.182.2018.04.10.14.04.38; Tue, 10 Apr 2018 14:05:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbeDJVB2 (ORCPT + 99 others); Tue, 10 Apr 2018 17:01:28 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:50805 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbeDJVB0 (ORCPT ); Tue, 10 Apr 2018 17:01:26 -0400 Received: from fsav302.sakura.ne.jp (fsav302.sakura.ne.jp [153.120.85.133]) by www262.sakura.ne.jp (8.14.5/8.14.5) with ESMTP id w3AL0lqr019458; Wed, 11 Apr 2018 06:00:47 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav302.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav302.sakura.ne.jp); Wed, 11 Apr 2018 06:00:47 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav302.sakura.ne.jp) Received: from AQUA (softbank126099184120.bbtec.net [126.99.184.120]) (authenticated bits=0) by www262.sakura.ne.jp (8.14.5/8.14.5) with ESMTP id w3AL0lNg019455; Wed, 11 Apr 2018 06:00:47 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) To: ebiederm@xmission.com Cc: syzbot+9369930ca44f29e60e2d@syzkaller.appspotmail.com, serge@hallyn.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, linux-security-module@vger.kernel.org Subject: Re: KASAN: null-ptr-deref Read in xattr_getsecurity From: Tetsuo Handa References: <0000000000008d2e0d05697a693d@google.com> <9d192497-8b1e-ca8d-0ed8-b3324ee1e361@I-love.SAKURA.ne.jp> <87o9irw2ad.fsf@xmission.com> In-Reply-To: <87o9irw2ad.fsf@xmission.com> Message-Id: <201804110600.CCF73450.FFOOQtSFOLHMVJ@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Wed, 11 Apr 2018 06:00:44 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > Tetsuo Handa writes: > > > From 904d07a6eb014f3df0c5a1ebfcfd4323276a9a76 Mon Sep 17 00:00:00 2001 > > From: Tetsuo Handa > > Date: Tue, 10 Apr 2018 15:15:16 +0900 > > Subject: [PATCH] commoncap: Handle memory allocation failure. > > > > syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1], > > for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when > > memory allocation failed. Return -ENOMEM if memory allocation failed. > > > > [1] https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107 > > Acked-by: "Eric W. Biederman" > > Tetsuo I can pick this up, or do you have preferred path for getting > this change merged? I don't have preferred path. You can pick this up. Thanks.