Received: by 10.192.178.70 with SMTP id s6csp17843imc; Tue, 10 Apr 2018 15:03:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx48e7/EHMO/3KoONsV/dFhBByaCLCTsDDnItRralsNGI3RST7ruwpZMMEh+G80oTmqaY5Jrv X-Received: by 10.99.95.75 with SMTP id t72mr1480575pgb.411.1523397838975; Tue, 10 Apr 2018 15:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523397838; cv=none; d=google.com; s=arc-20160816; b=EJaCQlyJ+A0uwVLVUere30tu1zQQX3uGQzKQ/3cuo8BcfiyoicE+qN2HWRs4UV7J6r 1f80RQp5iNm/KHmfOm+y0o8AfdJgRGVgrn9mHXBbh+s2/IGZ1x8tKbCMQ6q21EdRwbrl tVGsJqYYIf3iA5JY7G2YfdXBfKxQPA/sg/xwED/LIfhM0gxFH2iUUAbja/QmkSGVeu4X tYJkpNLyYz9GfoDgXWbedkykCivwmP8FrRQYHOIYQIzZcNSeYCtzWCUMB+y30mGAGy4p 2qMBpYwAcV2WDtbLT9iq4MmzpOLhtQi/3x27lvrgQPCZFqNv8n4c+v06Cvsofy70HYiB eQnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=ndDddXNTT33oJyHpPEugp5pw/43EJXWUUxgUHzoz/M8=; b=fEWnq9lkw635A79T8CCac2te1FbpOomQukWb+nPCP260Ofxd8IjM5coh/19isPWUcP FGCJEnw8gj7Bkx38iV9QhVb9NU9vJmOrRN/76+2BhCjhyKMW+U7dZL+tTqwH6kaRRYO8 MVseeQeOfhv79q9xqWmd/kLxeMAbKigFY5C0beOnT8uXJx05UDu0H5URWzzxyrSfPmjq 5g9g6Dp38UCpklA0uapK64/06lCQDdw0vDE2hnj3V2+Gpg/TViqac2qH0dYoeK1056dJ Y9CIBELnK5i6k0WCvWfrxISznhwX7iaCJf9/dRsMG13c0Wo806JrZ38WISRsDNAroDqb GafA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z62si2794644pfb.305.2018.04.10.15.03.09; Tue, 10 Apr 2018 15:03:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752062AbeDJWAO (ORCPT + 99 others); Tue, 10 Apr 2018 18:00:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59676 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbeDJWAN (ORCPT ); Tue, 10 Apr 2018 18:00:13 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7C169DA0; Tue, 10 Apr 2018 22:00:12 +0000 (UTC) Date: Tue, 10 Apr 2018 15:00:11 -0700 From: Andrew Morton To: Joe Perches Cc: Peter Zijlstra , "Rafael J. Wysocki" , Andy Whitcroft , yuankuiz@codeaurora.org, Linux PM , "Rafael J. Wysocki" , Frederic Weisbecker , Thomas Gleixner , paulmck@linux.vnet.ibm.com, Ingo Molnar , Len Brown , Linux Kernel Mailing List Subject: Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions Message-Id: <20180410150011.df9e036f57b5bcac7ac19686@linux-foundation.org> In-Reply-To: References: <891d4f632fbff5052e11f2d0b6fac35d@codeaurora.org> <20180410123305.GF4082@hirez.programming.kicks-ass.net> <95477c93db187bab6da8a8ba7c57836868446179.camel@perches.com> <20180410143950.4b8526073b4e3e34689f68cb@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Apr 2018 14:53:51 -0700 Joe Perches wrote: > On Tue, 2018-04-10 at 14:39 -0700, Andrew Morton wrote: > > On Tue, 10 Apr 2018 11:19:54 -0700 Joe Perches wrote: > > > > > A struct with a bool member can have different sizes on various > > > architectures because neither bool size nor alignment is standardized. > > > > What's wrong with bools in structs? > > See above. Yeah, but so what? `long' has different sizes on different architectures too.