Received: by 10.192.165.156 with SMTP id m28csp62546imm; Tue, 10 Apr 2018 16:26:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/887D+qF1cl9XKZyphmN6oUNoI5EVwDitHXfQNHSFGQk5Gx6/BcGvHakgXdFjhYXq/jg/s X-Received: by 2002:a17:902:1e5:: with SMTP id b92-v6mr2466365plb.78.1523402802434; Tue, 10 Apr 2018 16:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523402802; cv=none; d=google.com; s=arc-20160816; b=YJWekechSduMQW/3c+ZydFXl8goxks4cOXGSDgcs6AejDX+Z0n3Jt4ZXrBqJ+2a3YB CsTo/cyaQkose2oNkV8T0X4yRjs6h1+2YY0ExQ3fILyV3cPX9BzRRTJNwhdWH/pCvytZ L4aTFlm29QUb/QxFs1lUdLp+NduexFQgI4EO/dOrt01fTAofXmZC8+bdTdXdGFnx9cw8 f0N/glXeDnO300QlEeuaARypEyYQgsSY1bC0KjwP35RgGa9QZerTJxlgM+p3HDZFhXK/ wcKLSz1yN7AHXBYclB/hd0oOVgabLvSTzXJmEvD6tJL5liZB2wwrAsGXGzliZ11/m52d nmPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=YyTMFHKeryYNm9t70YbeZqnlr6UY8SE2WHCxlidzxIM=; b=BnmAU4iHHxpfwp38XK2X8syk6f4GcgqcHOkqaMSi7HLMeso05Q+EysIBx7OroO6ppW DhzDQJNclllnH4G64OXfvQ4qU5CmCoBTBIVBtydTfurKeXa6QdMynBXfCwYnCcerrVSV gs9gt8egfbhqZanYZi4s+XpVQjPpwC0Ij2liXqemiBV/LkM61tskA9Yw+0tBETtWeDvU 7cAAGhVa9z4KvNmb26cSw3joWbAIRaZNzNquqDfWlPwpjFvkUzTdQn0VfNWxZWCp043Q cPlLBnmZORD+nkCMpkKNeCjCw+RVLF/JFe0NxLMrseW6xDlNrrO64ErNwBqvyueo4Z7j pFVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kUyeJlpl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b31-v6si3703909pla.170.2018.04.10.16.26.05; Tue, 10 Apr 2018 16:26:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kUyeJlpl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176AbeDJXUp (ORCPT + 99 others); Tue, 10 Apr 2018 19:20:45 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34786 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755091AbeDJXUm (ORCPT ); Tue, 10 Apr 2018 19:20:42 -0400 Received: by mail-wm0-f42.google.com with SMTP id w2so23465591wmw.1 for ; Tue, 10 Apr 2018 16:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YyTMFHKeryYNm9t70YbeZqnlr6UY8SE2WHCxlidzxIM=; b=kUyeJlplphjbDWhIOM6zYrWkmh57cfRQpw4IR0MaZQEOdBbznPKV224tPkxIEQ0kPe WR6RAqB0LnEOOixdndf3x1cpTpHsatQmYAYT043knXJFcm9jnMkrqA3krpwOiAJIlQ6G 8eQXJ54L+MMwVrWjBqzmEKPEqmjJCzqu31ylcK1kfjqJ8u/Ldh6CKfsgrNFk9S7N86Zf VLn3YRertkD/NP3ca7HKeHuNtSD06twkmk15DUvQTGL2n+JdvJeKn7WZ8dJ8d9xknNtd A4KzK2TwI/mknSzU6WXqXFxadPTqUlVslzj1CMA3rxKpMg2UjeKYNvtFKK7a4ZFswuj5 eE3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YyTMFHKeryYNm9t70YbeZqnlr6UY8SE2WHCxlidzxIM=; b=CD6yMKBG5vKlmt1kzHO6qGnOBF2Fdx1t6qAIGbYF6t9Y1JIceTi+HzP2PI9b7cDJXV +ytsAxL/mPYz410QGVICjaR6Gs4AMoTrCgRWa9rDt/D7nLUgUJFokKE3sgexgbRVKPZE Mtsy44UGCTXzLJtt3fnRKAYUJtdZvAcDpaoTnAdq9VhmCeCXFrh4pM6eyZc0Q6dI1Zkk rHcE0Y9fFnYfG+BjAWGgSgqXtp+lvvtMjvyM91lr6K4KBvDU7eDnNnbZ93M3Juf3NiTl gMrEY2E9EgwUsQ7T6gq4EY0rVbkinB4yJ4ur7Qiy2RqPbeQl+pQsYIfLqHlCsDGRGB9r vUSg== X-Gm-Message-State: ALQs6tCeq1bRhdCpBHG2kVDSeu0WcK46xhQhGsAX4UbDeXYt/E22iSe2 LkE9c0i44fNFJryr0j2Nt0YjsAFi X-Received: by 10.28.111.194 with SMTP id c63mr797153wmi.25.1523402440612; Tue, 10 Apr 2018 16:20:40 -0700 (PDT) Received: from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz. [86.49.107.50]) by smtp.gmail.com with ESMTPSA id y9sm4516538wrg.46.2018.04.10.16.20.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Apr 2018 16:20:40 -0700 (PDT) Subject: Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing. To: NeilBrown , Cyrille Pitchen Cc: David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <874lkmw54j.fsf@notabene.neil.brown.name> <61e255fa-ece4-5566-d63a-730aaa25f18c@gmail.com> <87sh85uzu3.fsf@notabene.neil.brown.name> <87efjnvpjl.fsf@notabene.neil.brown.name> From: Marek Vasut Message-ID: Date: Wed, 11 Apr 2018 01:20:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87efjnvpjl.fsf@notabene.neil.brown.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2018 03:05 AM, NeilBrown wrote: Skipping the previous discussion, I think there are actually two problems here. One is the reset and the other is braindead behavior of this flash. TLDR, you are right and this patch is needed (with minor tweak to make it winbond-only and possibly clean up the conditions a bit, maybe even pull it into separate function with some sensible name), sorry for the noise. I had to read up the datasheet and the discussion again, the behavior of the flash is horrid. [...] -- Best regards, Marek Vasut