Received: by 10.192.165.156 with SMTP id m28csp238112imm; Tue, 10 Apr 2018 20:40:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+gDLAU6ZI52wL0SZ4AzW+5lImP9mKNaKRJNRIj+hhtO7tkAOlZaM+RsPdgjWcX1W58ywj4 X-Received: by 10.101.75.202 with SMTP id p10mr2168893pgr.339.1523418002649; Tue, 10 Apr 2018 20:40:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523418002; cv=none; d=google.com; s=arc-20160816; b=LJIBCjAhJsWTpVJwibpfNhQyEM1YSpUkIlNCMoDADxIKbaf1uFd4S9Mo1IX20BUBJZ naofKMdqfxEy6qQ38W5cVYxDGqqsQa307o3TwL0TUqu/85KQUwOtIaBcLjz6T8z+emuq uQEau4cTvNd/CtBTgkml/Bh87bCW4Fzcur1cqV9QhNQihPw5BSVIKIMxvKouHikStLtE hilpO7giEsTHxe/IQ3rbxGvUWFwkfAKGWCEqs6oI19Nh1FuYYAyDz3pIXaT4H8ppSp3W UBofeahl0T8IYbgGgzuK49Fbx5w9bhGabxJiXSPQkfy64tPYUlhfdEI22tF+H26Lz6k/ FnFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=A9MVyjrkXZozVeLFogJBLU+4klJzGcefgHpziViHcDU=; b=sHLyPMIzsOVWuz4V6UolemPBRrE9HgZmoAUlUB43weEdGqIag8PZFx9GvkJMnvbmQH 2+20sHB+6jNi4siXcC/9b/78n0ObUl5sAGOSbo9+dKgBs773gYL/rbfSU932ExRm/wU1 L4ITnGyb/iS0rd+2Dgb15OXSr1Vt+bMJreUMdJBx0VlT6jlYCz/HPsPFmWq/pq/N6C+8 AXqvsRtjVZd2TNT5mM06D8lz16+NIfC2/u7iSzCL3KRS5MDhoaYCpE54RMgYhywL1Qwv KecdSXCbpMwKmDGyvbamGL+czL4PYDOpL3IcXhR3YWaYZC7vfjYGPsIrXH+zzjoJOYXm xIDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si174904pff.125.2018.04.10.20.39.25; Tue, 10 Apr 2018 20:40:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbeDKBVd (ORCPT + 99 others); Tue, 10 Apr 2018 21:21:33 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47860 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751624AbeDKBVb (ORCPT ); Tue, 10 Apr 2018 21:21:31 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1CF9406F972; Wed, 11 Apr 2018 01:21:30 +0000 (UTC) Received: from localhost (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE5E32026DFD; Wed, 11 Apr 2018 01:21:29 +0000 (UTC) Date: Wed, 11 Apr 2018 09:21:26 +0800 From: Stefan Hajnoczi To: David Miller Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, syzkaller-bugs@googlegroups.com, mst@redhat.com, torvalds@linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check Message-ID: <20180411012126.GA28698@stefanha-x1.localdomain> References: <20180410052630.11270-1-stefanha@redhat.com> <8642c057-e49d-d95d-19e5-6d304f20064e@redhat.com> <20180410.105043.1798364865868187298.davem@davemloft.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20180410.105043.1798364865868187298.davem@davemloft.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Apr 2018 01:21:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Apr 2018 01:21:31 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'stefanha@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 10, 2018 at 10:50:43AM -0400, David Miller wrote: > From: Jason Wang > Date: Tue, 10 Apr 2018 14:40:10 +0800 >=20 > > On 2018=E5=B9=B404=E6=9C=8810=E6=97=A5 13:26, Stefan Hajnoczi wrote: > >> v2: > >> * Rewrote the conditional to make the vq access check clearer [Linus] > >> * Added Patch 2 to make the return type consistent and harder to mis= use > >> * [Linus] > >> > >> The first patch fixes the vhost virtqueue access check which was > >> recently > >> broken. The second patch replaces the int return type with bool to > >> prevent > >> future bugs. > >> > >> Stefan Hajnoczi (2): > >> vhost: fix vhost_vq_access_ok() log check > >> vhost: return bool from *_access_ok() functions > >> > >> drivers/vhost/vhost.h | 4 +-- > >> drivers/vhost/vhost.c | 70 > >> ++++++++++++++++++++++++++------------------------- > >> 2 files changed, 38 insertions(+), 36 deletions(-) > >> > >=20 > > Acked-by: Jason Wang >=20 > This sereis doesn't apply cleanly to the net tree, please respin > and add the appropriate Acks and Fixes: tags that Michael and Jason > have provided. Sorry, will fix. Stefan --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJazWMVAAoJEJykq7OBq3PIN1IH/ikRjLXh9rfQ7bPYf9bbkcyE 43iYyGKK5W5N5GA5urguo6yZHly24hLAhvm+MdbLFiXmjrEsNODc7Lk2+p9d1HJa m0Dc+pyjig489X/jFWtEUwFS2woZlAbxCS/iyEjMDkotc43GCRvm1C6OT0nBHdky XSdsu2rJyc/PNJtLNkDAFaRm2gvbvCfLG82SlZY39S679M1Xfm+23IvZD+6E6Mhr c2QrUEYjF3drmY0HjfTEqiRBH4f+/wJe67W4oiBfjM1kNJd3rOO5qkMnmF28dQjC S/7S/hC5FJplkvxXKKis749OHLbgPFPtgwFkW5FQfgd9miWOVp7wF9lrnq88SjY= =eq0T -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--