Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S274813AbTHRUU3 (ORCPT ); Mon, 18 Aug 2003 16:20:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S274964AbTHRUU3 (ORCPT ); Mon, 18 Aug 2003 16:20:29 -0400 Received: from [66.212.224.118] ([66.212.224.118]:40968 "EHLO hemi.commfireservices.com") by vger.kernel.org with ESMTP id S274813AbTHRUUZ (ORCPT ); Mon, 18 Aug 2003 16:20:25 -0400 Date: Mon, 18 Aug 2003 16:20:23 -0400 (EDT) From: Zwane Mwaikambo X-X-Sender: zwane@montezuma.mastecende.com To: long Cc: tom.l.nguyen@intel.com, Greg Kroah-Hartmann , Jeff Garzik , "Nakajima, Jun" , Linux Kernel Subject: RE: Update MSI Patches In-Reply-To: <200308181728.h7IHSolh016169@snoqualmie.dp.intel.com> Message-ID: References: <200308181728.h7IHSolh016169@snoqualmie.dp.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 25 On Mon, 18 Aug 2003, long wrote: > I make minor modification to the last patch to reduce some duplicate functions, > as shown as below. I think this perhaps looks better. What do you think? The patch looks fine. > +#ifdef CONFIG_PCI_USE_VECTOR > +static unsigned int startup_edge_ioapic_vector(unsigned int vector) > +{ > + int irq = vector_to_irq(vector); > + > + return (startup_edge_ioapic_irq(irq)); > +} Tiny nit, Linux coding style is; return startup_edge_ioapic_irq(irq); But you can queue that change for later. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/