Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function
 parameters
To:     Julia Lawall <julia.lawall@lip6.fr>,
        Gabriel Francisco Mandaji <gfmandaji@gmail.com>
Cc:     gregkh@linuxfoundation.org, hsweeten@visionengravers.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        lkcamp@lists.libreplanetbr.org
References: <20180410225007.GA5050@gfm-note>
 <alpine.DEB.2.20.1804110707130.2316@hadrien>
From:   Ian Abbott <abbotti@mev.co.uk>
Message-ID: <fe7c72f2-2d51-42a7-5d2b-960174bc29a4@mev.co.uk>
Date:   Wed, 11 Apr 2018 10:16:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1804110707130.2316@hadrien>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/04/18 06:07, Julia Lawall wrote:
> On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
[snip]
>> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> index fdd81c3..631a703 100644
>> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
>> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
>>   }
>>
>>   static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
>> -					const struct comedi_cmd *cmd)
>> +				   const struct comedi_cmd *cmd)
> 
> Someone has made the effort to put const on these parameters, but not on
> the other similar functions.  Perhaps this can be improved as well.

Perhaps, but that should be in a separate patch.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-