Received: by 10.192.165.156 with SMTP id m28csp483978imm; Wed, 11 Apr 2018 02:23:09 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/2YtTqB0iSq/VFxCNPU9/K+NGUkfyP8bGdvKRDHVsrdudHaYU6gr+txj5Fk5BkcN97rK66 X-Received: by 2002:a17:902:86:: with SMTP id a6-v6mr4301307pla.298.1523438589253; Wed, 11 Apr 2018 02:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523438589; cv=none; d=google.com; s=arc-20160816; b=DUw0s7FUteWAFJBzCGcWLX1G8Y7AAC68u6KVBUSDBKpjW/rl4bwYJCkp6BvrjGmkN0 wU27R3TZL4m4EktMcse3nO+8rkKZYR2tBNH3zCAQBncLsq2k8g7Cx4LQKmqI1SCxYKIr lfGWT/01hDL2WKOvVwRjKNdsVRtqpWUZc8EVh8QMk+5QoEQvdfXjOXsP7o/dPFhHOtk8 KNYhtFXQ4uS0tc+MRikTxFdGviRDraqGYWRlCqWLGCIJ6KwBPBfJRbliotBWzvZZFCrk FTsLywTC6MTzMfI5LwMoHGkt3XGqZ3Frzcxy2oGxQN4rGEGn9rheDXgZ2wJeCCLznkQc qmAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=gJ9L4qNFvPsQKLjdQ+JVs8k7d4tfSyP7nPGvoB8wX1k=; b=GqnUoGvTO0K27myzcv4ROkNjpn2bGlTmzH+r/NpAeUDi/qOobaNSQUe2I4AuXR2+vv sNbeCiKg4pEmztkmPZNGkNaOR3RXHJ/46Deo2kquamTewi4JBAatgwnKI0/FYkL3md4w LLCdjIUVk9qI4nlSQZGok22nobMGJBpyU30rfKz/R2iXkDCQtjQU+eRXzQTKv5nI2js3 rrBQn9Q8Ya7PWc2uhYaLtF6gZy4peZQE1fXzne7banqTyqLlKfyZBHrEVe0fpec/BX0Q wbAjtm34+/8zyaCZAKJQpIsUTF4lSx+pJE6Id8Zk3KQnv5yT996yh2jyEDde3UwfMDvc a5UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3-v6si602999pld.384.2018.04.11.02.22.33; Wed, 11 Apr 2018 02:23:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbeDKJSm (ORCPT + 99 others); Wed, 11 Apr 2018 05:18:42 -0400 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:35866 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbeDKJSl (ORCPT ); Wed, 11 Apr 2018 05:18:41 -0400 Received: from smtp4.relay.iad3a.emailsrvr.com (localhost [127.0.0.1]) by smtp4.relay.iad3a.emailsrvr.com (SMTP Server) with ESMTP id 749D15715; Wed, 11 Apr 2018 05:18:40 -0400 (EDT) X-Auth-ID: siepeng@mev.co.uk Received: by smtp4.relay.iad3a.emailsrvr.com (Authenticated sender: siepeng-AT-mev.co.uk) with ESMTPSA id 99B1A4287; Wed, 11 Apr 2018 05:18:39 -0400 (EDT) X-Sender-Id: siepeng@mev.co.uk Received: from [10.0.0.185] (remote.quintadena.com [81.133.34.160]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.7.12); Wed, 11 Apr 2018 05:18:40 -0400 Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters To: Gabriel Francisco Mandaji , gregkh@linuxfoundation.org Cc: hsweeten@visionengravers.com, julia.lawall@lip6.fr, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org References: <20180410225007.GA5050@gfm-note> From: Ian Abbott Message-ID: <50d5d5b9-d4f3-68a5-268b-fbe46188ebb4@mev.co.uk> Date: Wed, 11 Apr 2018 10:18:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180410225007.GA5050@gfm-note> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/18 23:50, Gabriel Francisco Mandaji wrote: > Fix most checkpatch.pl issues of type: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Gabriel Francisco Mandaji > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index fdd81c3..631a703 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev) > } > > static u32 ai_convert_counter_6xxx(const struct comedi_device *dev, > - const struct comedi_cmd *cmd) > + const struct comedi_cmd *cmd) > { > /* supposed to load counter with desired divisor minus 3 */ > return cmd->convert_arg / TIMER_BASE - 3; > } > > static u32 ai_scan_counter_6xxx(struct comedi_device *dev, > - struct comedi_cmd *cmd) > + struct comedi_cmd *cmd) > { > u32 count; > > @@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev, > } > > static u32 ai_convert_counter_4020(struct comedi_device *dev, > - struct comedi_cmd *cmd) > + struct comedi_cmd *cmd) > { > struct pcidas64_private *devpriv = dev->private; > unsigned int divisor; > Looks good, thanks. I guess the remaining case of open parentheses alignment wasn't changed because that would exceed 80 columns. Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-