Received: by 10.192.165.156 with SMTP id m28csp542936imm; Wed, 11 Apr 2018 03:30:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx49PSX8ffNG2+F6NG3zsMMpGGw9zmX1ImCE/twzKCabVItOiCRLnUDUuQqpZRJxT3VkC5YcO X-Received: by 2002:a17:902:6b4c:: with SMTP id g12-v6mr1635711plt.213.1523442606383; Wed, 11 Apr 2018 03:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523442606; cv=none; d=google.com; s=arc-20160816; b=WiiAew1hqTj90XEaN1pVYYStNANP3Q1ssCAFfbaauGji23/nota33zPEWIaUP+Sl4m 9VsHFv3o44hjICmOUWL2Y/mQLOgaWDYQ0hT3s7Gm5j194JgTNFakmXsM5GizGpfzv716 2+a3EsXGXADiYRrKmzawIcB5650I8sMjDjZZGgVk2vmoB1EJ96mcJIphaUhnr7vxmfnI GSBksmY55ioWWWRTV1sbwbjsqsXQuvmn9E8x3kYWOPP8bfPOq0xrCjTtc87ETWSZLT3G aDequEHmAH5g7JnbhTHJAEHRbh1488/rzmn5/f8SVD9bbglRRm6rSLan2gBAXNbtjnA3 oFDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4sviywPv75eTMlxVrDUXn2jBMcLEKVlW5fy3hgbSv90=; b=XGSPkZGBiay5AwhCgpdkJ50X7K/VQHx4x+kF+r5X/xmZ8kS9jsbTMRLHPkuiByadDN 6XBYIpTp5jzC9NzT8WSAGtVX1r1BFZx5M4U8lwpsFPIl6Awm9IWNpgRoo7318Oa+lGWN D17JxB0L7EPT7V2y7qAhbK2B5QfpYYvEDJHBjElclszHbSoFvL2myhtBA3StL53A9XPI 5nAnZBm17OrBECNqNQao2SrCfgYppetDRm07bhejwzON6OkARp4toEs/9jyhDWPUz292 e1qZve72S60E7rR3VbLvfd6NlTZvDNB4P9gz7+HpRUILpEZmStN4jcBWxyI/kX2Yah2m +yNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=fLfmLgbk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si530735pge.659.2018.04.11.03.29.29; Wed, 11 Apr 2018 03:30:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=fLfmLgbk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbeDKK0a (ORCPT + 99 others); Wed, 11 Apr 2018 06:26:30 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45298 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbeDKK02 (ORCPT ); Wed, 11 Apr 2018 06:26:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4sviywPv75eTMlxVrDUXn2jBMcLEKVlW5fy3hgbSv90=; b=fLfmLgbkyehp+3/qTAvZEL5Ir Tr8J8KDP4qQ5xl39MntzcqJCR5/ijLVzc4dlbwfZQk8GgNKcDlBiVbXTouXjewhQu98npZt08h7u0 Rc+dioD2narNc6tA6ZdN6mlG4Ekd4d3YmXoBcg6SrDz3Of4RiiTrYImJI/KVizrdgpkphWOF6LtEQ T43qVPyvL45DqtJGBW0Nr9M+bmyUtEXTdcS85RkEfi5kkaZqawn1GpdZpQHtMvUy0GvZ4VDsSQ18Z EXAuEdIrO3RQqSU1KaR5fmpqsHU9RfcCsCTevsDDGX3wZz2JEpmDHpgBwYQCGLFSXcu8suECLLo9G rd5CA3lGw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1f6CxL-0000tM-To; Wed, 11 Apr 2018 10:26:24 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 44A3E2029F86F; Wed, 11 Apr 2018 12:26:22 +0200 (CEST) Date: Wed, 11 Apr 2018 12:26:22 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Zhou Chengming , linux-kernel@vger.kernel.org, mingo@redhat.com, huawei.libin@huawei.com Subject: Re: [PATCH] sched/rt.c: pick and check task if double_lock_balance() unlock the rq Message-ID: <20180411102622.GK4082@hirez.programming.kicks-ass.net> References: <1505112709-102019-1-git-send-email-zhouchengming1@huawei.com> <20180410180546.4159134c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410180546.4159134c@gandalf.local.home> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 06:05:46PM -0400, Steven Rostedt wrote: > > Peter, > > Going through my inbox, I stumbled across this one. And it doesn't > appear to be addressed. > > I think this patch is a reasonable solution. Urgh, yeah, also seem to have forgotten about it. The proposed solution is in fact simpler than the existing code. Also, I think deadline.c has the exact same problem. Zhou, could you respin and fix both?