Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Apr 2018 10:33:01 -0400 (EDT)
Message-Id: <20180411.103301.1978874246933299635.davem@davemloft.net>
To:     phil@raspberrypi.org
Cc:     woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lan78xx: Avoid spurious kevent 4 "error"
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1523444567-128200-1-git-send-email-phil@raspberrypi.org>
References: <1523444567-128200-1-git-send-email-phil@raspberrypi.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Phil Elwell <phil@raspberrypi.org>
Date: Wed, 11 Apr 2018 12:02:47 +0100

> lan78xx_defer_event generates an error message whenever the work item
> is already scheduled. lan78xx_open defers three events -
> EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware
> of the likelihood (or certainty) of an error message, the DEV_OPEN
> event is added to the set of pending events directly, relying on
> the subsequent deferral of the EVENT_LINK_RESET call to schedule the
> work.  Take the same precaution with EVENT_STAT_UPDATE to avoid a
> totally unnecessary error message.
> 
> Signed-off-by: Phil Elwell <phil@raspberrypi.org>

Applied, thank you.