Received: by 10.192.165.156 with SMTP id m28csp825194imm; Wed, 11 Apr 2018 07:51:09 -0700 (PDT) X-Google-Smtp-Source: AIpwx48CowjQ9dG3Bx602FE8OmbbQL42Y2sZx11wOmbkLPKYhqOnE6we0bQdhpdW/MLOSTIePtJS X-Received: by 10.99.54.75 with SMTP id d72mr3673557pga.96.1523458269050; Wed, 11 Apr 2018 07:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523458269; cv=none; d=google.com; s=arc-20160816; b=f95E4hXogsFxJAFD6n3W5guupw7YP3gQQ02Wxsrcm4xi6P8BUWqYe0V2EJCMb3LR4r ECnlPyNKdvHrIuN0zPNae7yoa+j7x5Nkbfg2y3kI1PxuJsZx2q9C+BKHIIcMkKHkImEq w75yvFoySPYrvT2BBtER34tplgV9MW+9mu5Gu/zVvCCJfukMfcbLzv+GsMq6WyGU4MeX O6o0XsHLdDZTg14nmSvp+53uml5OJAm608sJFDqUmRsZ5UADGMy1BEw/F+ZXbq77M2oG 7x2KLdzV0mXU/juFJKfKd2ZxS1sUYvE4d6w00yZD6tPSF3Ezp/3rY0RQSVrbYhZ+NPhz 2lCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=9tkFsbKdMCaggJgTdvoDQamniKNS4e5a1WIGQ6JaYE0=; b=BlIhmUvJ0VM3e2qYhJMC7Qz8CjW274/GiONuOEYI1trWWYsJvs6BouS5Ee6+NnDL8X JBZ/yVG3ULRooIjBZJjEshjtQXfgCw+tV21CSkZ8nWIJoxORcVld44+sLP8n9ye5uE5e RRe7kwKsFVkoarCG+nHNabI2IaXZ6z+zdKXHfwUoz+e+SnTZkFVqTlh0qG64oWCVBSvj 1cSUIsy/IRgEMx/HTogbRInKePDAWjrGCHyiQAJNpzP9thjC2Nc1CLhrsk4uttNu+5ZF ZDDOI9dBVBbcSmmPlZNSsGwFO2tCy5uWg+WhJ9INPBEAg0HhNWrCYXXTFPkWIoXROpDM CZ1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XGHtKFjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si820701pgr.419.2018.04.11.07.50.31; Wed, 11 Apr 2018 07:51:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XGHtKFjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810AbeDKOqX (ORCPT + 99 others); Wed, 11 Apr 2018 10:46:23 -0400 Received: from mail-yw0-f170.google.com ([209.85.161.170]:44964 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbeDKOqT (ORCPT ); Wed, 11 Apr 2018 10:46:19 -0400 Received: by mail-yw0-f170.google.com with SMTP id z21so625787ywg.11; Wed, 11 Apr 2018 07:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9tkFsbKdMCaggJgTdvoDQamniKNS4e5a1WIGQ6JaYE0=; b=XGHtKFjFUgYN7gx9hfQo9F2GKFVJRLJorB9ChMxtxkPHSDJDJpIAhDC/II/+fh2GUL qK/eZOZq0MEXMI4CYtYY/ZBvwFtHIvS+GXzevLYO/2YFzMU59yRNb1Nk/hFfeLGjAGk6 +ebf8XUmh0z7ljLeSZrg7hzmouE+YF9c7aOTmnozPmXT/jcMSKT1G0FCIDC8Pot1Kl4l ewGdtlI8l1AkQESw4KffNJdxwpgNMBJ5b2E2fPHsBUcEsY7V0AEwJfSYp8zRbf+CCiNp 5fI2vddb5y+Cp20Afhie6sscRUMf8aM81OdvZtJG982ALj45iMvcnAw/W/jroXkQIgzR Vkng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=9tkFsbKdMCaggJgTdvoDQamniKNS4e5a1WIGQ6JaYE0=; b=uSsKDMLgI0ZzChnHxr5IgVAPiAt/V3LqgFrNcV9ideW21D95M8IsEZK7dvyRrInSj9 JiNymB0tmTBTOEa++x/3BNf4hJWxK4G2fM11PUF/ED+GpnzuVbyDCREZjjGcebQuv43s N8oAY0nPJnwJpefzGGQu/H3x/6jg74VM3lN4XzlZVXyuJf7kniGKfobFHuv2BU9hvR50 90Syw9S4kmeY3ezp3RDgj3asfP/5ZL7ULsz2cGkFMyTFKO91PbEUYMV8vUqePkXmnORM RNoryT/9wVHMskNiSPYK9rUS/G3bPKrUWA9OMv7Xzxa0fWG3TrdZLG77ATCbrE8bS+jC +XbA== X-Gm-Message-State: ALQs6tCUqqiN7yCajoU39X6e+X6MTS2R4dNfLWgiAwHz48/RFF8PJl97 5NFX6xRuZ4Z5BnCTHRoGd5w= X-Received: by 10.129.103.135 with SMTP id b129mr2252911ywc.214.1523457978735; Wed, 11 Apr 2018 07:46:18 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::1:e6ed]) by smtp.gmail.com with ESMTPSA id p20sm476686ywp.58.2018.04.11.07.46.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 07:46:17 -0700 (PDT) Date: Wed, 11 Apr 2018 07:46:16 -0700 From: Tejun Heo To: Alexandru Moise <00moses.alexander00@gmail.com>, Joseph Qi Cc: axboe@kernel.dk, shli@fb.com, nborisov@suse.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release Message-ID: <20180411144616.GI793541@devbig577.frc2.facebook.com> References: <20180407102148.GA9729@gmail.com> <20180409220938.GI3126663@devbig577.frc2.facebook.com> <20180411101242.GA2322@gmail.com> <20180411142019.GG793541@devbig577.frc2.facebook.com> <20180411142859.GB2322@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180411142859.GB2322@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Apr 11, 2018 at 04:28:59PM +0200, Alexandru Moise wrote: > > Ah, that changed recently. Can you please check out the current > > upstream git master? > > > Just did, without my patch I see this crash: lol I was looking at the old tree, so this is the fix for the new breakage introduced by the recent change. Sorry about the confusion. Joseph, can you please take a look? Thanks. -- tejun