Received: by 10.192.165.156 with SMTP id m28csp834270imm; Wed, 11 Apr 2018 08:00:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/ODAUWNNjzk0MxDS0IkDraJrRaJE4RNWunHPmWZFJ9ZQp/drM9a6RdRB6r91AcsrosaqVq X-Received: by 2002:a17:902:76c3:: with SMTP id j3-v6mr5426071plt.257.1523458804699; Wed, 11 Apr 2018 08:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523458804; cv=none; d=google.com; s=arc-20160816; b=IH2jBycJUsMqfkbMegknVxcCFSiKtrqstoO67WZ8CmISGSdVNbqrnoDmTTdFqP2Tos doOQNu0vCyHhOvDgKe9l9gK0+Tj/bufFZDFrJ2l06l/SVEDun4P8JEeyQ6Z6+26z19yr tq8VuXjVO5pmnWcdIRvUbUPcCvVx1Yo4COyn9jv2RQZq0pnpJYlxP+V7t/GBpdi5QVih txEu69VKntuW8xFCpBRv4BibBgk9fXURFr1+uwp0TF3EDVJ6y7ZY3orVcSlED5zzsuBY PUxxB36kJoxJGX2jjpwdskM2IkTig+eihKiqvlBLBxNxoPN83nPORCWWQwt48OwViGUM DGpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=4/U1t1wxahJfkKMuKRWQlonsInkdiHGfREddK6g4k74=; b=MyPc1Ogbm6mkth/GvhZzWGESNoNOZtvZZ3opeUWVp2x+89Hq18AQ4SwTMMKR2IP8Pq KBFiJbwfsvm1mRaWiOa81CtsXKC0pMvc7zNoKs1WINfhHT773gdBLAN77BYhk/usOqlu hdIuZSP44k9zY+y3uGSJL5Xo2/CEtOmzEOaD4fUZlntvee/iM9nNhq38Zuc8sT/VuMLH wUpQzYnPIQYGfyv15ZyYpBH5OYMhu8Pjs+F70VpdXMO0EjHZCjfwE5eDZSYhF6BCMlWq SLTJ6LcQQ6NyxDVB4xedCz0LkBG5TPTAU0tC59Df2EpNcQ4pyhQxgdaFGomPq6opHuYS MM0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c12-v6si1220430plo.216.2018.04.11.07.59.27; Wed, 11 Apr 2018 08:00:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbeDKOzd (ORCPT + 99 others); Wed, 11 Apr 2018 10:55:33 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41614 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbeDKOzb (ORCPT ); Wed, 11 Apr 2018 10:55:31 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 432B113FC31F0; Wed, 11 Apr 2018 07:55:30 -0700 (PDT) Date: Wed, 11 Apr 2018 10:55:28 -0400 (EDT) Message-Id: <20180411.105528.2200336972660597076.davem@davemloft.net> To: mst@redhat.com Cc: stefanha@redhat.com, virtualization@lists.linux-foundation.org, torvalds@linux-foundation.org, jasowang@redhat.com, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check From: David Miller In-Reply-To: <20180411162345-mutt-send-email-mst@kernel.org> References: <20180411023541.15776-1-stefanha@redhat.com> <20180411162345-mutt-send-email-mst@kernel.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Apr 2018 07:55:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Wed, 11 Apr 2018 16:24:02 +0300 > On Wed, Apr 11, 2018 at 10:35:39AM +0800, Stefan Hajnoczi wrote: >> v3: >> * Rebased onto net/master and resolved conflict [DaveM] >> >> v2: >> * Rewrote the conditional to make the vq access check clearer [Linus] >> * Added Patch 2 to make the return type consistent and harder to misuse [Linus] >> >> The first patch fixes the vhost virtqueue access check which was recently >> broken. The second patch replaces the int return type with bool to prevent >> future bugs. > > Acked-by: Michael S. Tsirkin > > We need the 1st one on stable I think. Series applied and patch #1 queued up for -stable.