Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Apr 2018 21:32:16 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg Hartman <ghartman@google.com>
Cc:     Alistair Strachan <astrachan@google.com>,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        arve@android.com, tkjos@android.com, maco@android.com,
        devel@driverdev.osuosl.org, kernel-team@android.com
Subject: Re: [PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.
Message-ID: <20180411183216.hn7l5djgrzezomtr@mwanda>
References: <20180410190647.82986-1-astrachan@google.com>
 <20180411080536.sw6tesgi3vqgxxpn@mwanda>
 <CAOvepGkHgJwZs+LtLb+10yXUkLrRxazEJk3o2he-awhMV3WMMQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOvepGkHgJwZs+LtLb+10yXUkLrRxazEJk3o2he-awhMV3WMMQ@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 11, 2018 at 10:49:47AM -0700, Greg Hartman wrote:
> > +     /* Ensure that the offset is within shared memory */
> > +     if (((uint64_t)arg->offset) + region_p->region_begin_offset +
> > +         sizeof(uint32_t) > region_p->region_end_offset)
> 
> I'm not certain if I understand the overflow.
> 
> arg->offset, region_begin_offset, and region_end_offset are all uint32.
> 

Ah...  You're right.  I didn't read carefully.  Sorry for the noise.

regards,
dan carpenter