Received: by 10.192.165.156 with SMTP id m28csp1111581imm; Wed, 11 Apr 2018 12:38:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx48xEOnHkdUmUFCMJ3QvJk/hLiqdxopM3+6FEusLLF8RD8MGiFAd4+lMopDJM0s2So/cpNRR X-Received: by 10.99.142.201 with SMTP id k192mr4394766pge.278.1523475492693; Wed, 11 Apr 2018 12:38:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523475492; cv=none; d=google.com; s=arc-20160816; b=XnMopbhEP2cdnzS9Av8Zq72vzSRoMclwI/HO/jMJJaZuUUockj9dVdsBoPJGlJv8CH GmR1nSMfkPdBBWPp/Art4ti2yaBePUoI0/Cc0AFCtuiluV3lcYS5MB5JI/EIa1SOfA7/ Y/nNq7vloRpVsFkildL1lh5MxQn8YtywNNAje3n6yFdo98tudcu5A/Mt/LcEitWOgNwd 12x4hL49HdLBBwdbHNdmrHmFcTfR+Jx48NIeuLvzpHUtn+M3OMuHaBRZ7lAQdMWmxker pREHXwgPYpNMypXSC48UGMIo0eFonc1WSnIe85ZepTn33p68CJ8meHQ8xLg5ZL1CmX+W mliw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ib+XvU8BfSKcyJAxuCd8aLgdpHlCyz9FPKzfmek60PM=; b=lTjWlNYykNGXC1o323D4LSYx+MPOxyXwzEXzqt5doN72miLot/UnNE7fSXYJDVxmK7 bj4nuvIx9OCQuoQf7zwvfSiy/Q5BScpdERPniHMgj3aBqlWvkeT1upItWntlB3ABCaVy V2vKQqPZorkSEcv4cw3z/1n/oT4KmO0v8eQX3v5ONpQerNe3Zuh5DKE/SRYR2oSnMqCl SK4K7cw3fbX7ymSbcfwudqXQiSKey+M51GVxPmYGNWKcECaOxP0HtMGo4jEahQDS+mIL fHKXum+FxTpT10DXHoAXX4z3hGxJCaeQ4HF/kAEe1HkChi4sgKQYQzx4I9sxvDTyKOUJ ExHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k12-v6si88725pln.103.2018.04.11.12.37.36; Wed, 11 Apr 2018 12:38:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757288AbeDKTep (ORCPT + 99 others); Wed, 11 Apr 2018 15:34:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38526 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934466AbeDKTC0 (ORCPT ); Wed, 11 Apr 2018 15:02:26 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A5B10DAC; Wed, 11 Apr 2018 19:02:25 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jia-Ju Bai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 180/310] mISDN: Fix a sleep-in-atomic bug Date: Wed, 11 Apr 2018 20:35:19 +0200 Message-Id: <20180411183630.351103149@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183622.305902791@linuxfoundation.org> References: <20180411183622.305902791@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jia-Ju Bai [ Upstream commit 93818da5eed63fbc17b64080406ea53b86b23309 ] The driver may sleep under a read spin lock, and the function call path is: send_socklist (acquire the lock by read_lock) skb_copy(GFP_KERNEL) --> may sleep To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC". Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/isdn/mISDN/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/isdn/mISDN/stack.c +++ b/drivers/isdn/mISDN/stack.c @@ -72,7 +72,7 @@ send_socklist(struct mISDN_sock_list *sl if (sk->sk_state != MISDN_BOUND) continue; if (!cskb) - cskb = skb_copy(skb, GFP_KERNEL); + cskb = skb_copy(skb, GFP_ATOMIC); if (!cskb) { printk(KERN_WARNING "%s no skb\n", __func__); break;