Received: by 10.192.165.156 with SMTP id m28csp1141068imm; Wed, 11 Apr 2018 13:12:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx49ABoQEHYw+8FE4zz94QeeGomU6MES85PuKvtTovUBs32UkgZVEAcixBXXrdVmAr7CyhYcw X-Received: by 10.99.63.131 with SMTP id m125mr4441705pga.196.1523477532804; Wed, 11 Apr 2018 13:12:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523477532; cv=none; d=google.com; s=arc-20160816; b=QPZMmeqadnPKCE29XeuTZwI1jG20KJ8mYpx9obA+AGujNzWAvWtbeV+92rmyeHDIc9 4Iiv6hGOWHffAJVi3EkLBLygFNajgszGNcvB7RbxYlktBaSrvlsGjPuIJJGUc7VQO+xG clmjzc3pxV1V3pbnhj2oJ2GbrcSYZV4QNHTg6QmD3jg/SMEIPRsaJMsmdxQHgJianUjZ Bds5bx3kve6pD3SoKn0dJG90vBs3CagCvW2DrtBbqszQ5pPyRPJkaDeXQ0G2PRDHKym6 f8tfMB67omQaUxR7aG8pMNXA3EZS1UtgaZN+hr1QjL3fFeETW59YJrAVazzDWr2vYPME PlJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=cyNJnJkCiwTF04MQC6ywAfcy9BlQmhPTDJfR0UIGdLc=; b=v0TGPnd5udFpXrs7Ph2WXnTcLVJTKLTpbKI+7Xhkewmyuhpg2FtM27ulqEdmZPvhXu ol2LZLcqt/LGy00Wo7YLZ10Ad2aF3/vzCjwRczKmningEsVkLBHsMtSddSxh7vumuQTG ToU1f2wTEClaTVP7mKbfKosxDFHqUOWWIZgLUYgSuvXwtIXIKh4iaMWUosnXy+AUAuvf 4Fk0rlkKtJSWMw+HbVp4sEKVSsTp0pFfOHCl84gS7LJZP0sGUnvqhORiAJjpEoxH+T7l fsSRBfisHCKikl0Dd6povQ+YC6E8b+igpz6duUofgKb/Y4/J7oMv9jZHkmOoIxrqdxQr o67Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s189si1208907pgb.126.2018.04.11.13.11.35; Wed, 11 Apr 2018 13:12:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933794AbeDKSzu (ORCPT + 99 others); Wed, 11 Apr 2018 14:55:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35572 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933049AbeDKSzs (ORCPT ); Wed, 11 Apr 2018 14:55:48 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 02953CF7; Wed, 11 Apr 2018 18:55:47 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 075/310] sh_eth: Use platform device for printing before register_netdev() Date: Wed, 11 Apr 2018 20:33:34 +0200 Message-Id: <20180411183625.541619486@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183622.305902791@linuxfoundation.org> References: <20180411183622.305902791@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Geert Uytterhoeven [ Upstream commit 5f5c5449acad0cd3322e53e1ac68c044483b0aa5 ] The MDIO initialization failure message is printed using the network device, before it has been registered, leading to: (null): failed to initialise MDIO Use the platform device instead to fix this: sh-eth ee700000.ethernet: failed to initialise MDIO Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3133,7 +3133,7 @@ static int sh_eth_drv_probe(struct platf /* MDIO bus init */ ret = sh_mdio_init(mdp, pd); if (ret) { - dev_err(&ndev->dev, "failed to initialise MDIO\n"); + dev_err(&pdev->dev, "failed to initialise MDIO\n"); goto out_release; }