Received: by 10.192.165.156 with SMTP id m28csp1143461imm; Wed, 11 Apr 2018 13:14:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/SqxnA42AYnEgLD1vB8wosWqIwVqw1ro7W8lmi9G79ibF5N1lr2Lv+b5p0IiHJda6tGRdH X-Received: by 2002:a17:902:7d86:: with SMTP id a6-v6mr59745plm.264.1523477688584; Wed, 11 Apr 2018 13:14:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523477688; cv=none; d=google.com; s=arc-20160816; b=MhKNM6nO5lws5Mew/RUZD44ldrjxx0PjhgpqnAN8KnyNEALrledi3OGtlqNtXOWTFj gNjeoMQkWeVhaA4pFjxgVs7FcrzAWUa0U0PIfgN1RJ0mLhP7h3hNwhFn3DDYqi8mikjl +Mla0tZDOAFhPJyCzRyAeSvBgnFPQJOzG3NI00Z3WVmrbr9xRy1G3SAwprtdrn9bobva GsnwdyW/HYcHl2F4BKWkVniOBfq9WNR/Ud3uBbe3BjOvqHJXVCmC0Gg8CG0y4fDrImxh i7R3jTGYKyd2ma4wECoTfqp2LGZEADFOHUz6gvwx8XsGsrM1eOHpo1Uj+eGYeOoGIroY NvmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=ITTLYzP0m48ThZWr+eYvsFYOFbPMirzMUIihozz9bIA=; b=MHOCvEDOUY9ve/1oqWjT4Zrgy6S3kh2+zNGzV3WMUDzCcumeIJOxOZWTND6Gx8+QHm LGYE2nKnFjOUlOoTylq14OeBPT94gjD3FAKGVrHgzv9n/shAw6+phJmRIpAZzTrTZ65R l/3QHGFkyLmSYM7NTQwjfWks4QZ2Mt9xlzzbspNhG2ka16wKDzX8GI/j9UK3LtlxpC3Y gL6xZKmUiHhb2KnE8tH34UdLGmM/4SFY+mVyhszLn1lU4eeZfp+htq2ytQVSvVQ378BR KEbdskAG28KO+GvlgyiZ3HAresNX0Z8gr/2bNHIxuxsX/v2rlUuuWiwUQJbhSDrb2qjm rGyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o18si1386487pfa.346.2018.04.11.13.14.11; Wed, 11 Apr 2018 13:14:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932085AbeDKUJV (ORCPT + 99 others); Wed, 11 Apr 2018 16:09:21 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756444AbeDKUJT (ORCPT ); Wed, 11 Apr 2018 16:09:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5EB638DC39; Wed, 11 Apr 2018 20:09:18 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-8.rdu2.redhat.com [10.10.120.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B2062023587; Wed, 11 Apr 2018 20:09:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180411195436.GA7126@kroah.com> References: <20180411195436.GA7126@kroah.com> <152346387861.4030.4408662483445703127.stgit@warthog.procyon.org.uk> <152346403637.4030.15247096217928429102.stgit@warthog.procyon.org.uk> To: Greg KH Cc: dhowells@redhat.com, torvalds@linux-foundation.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 24/24] debugfs: Restrict debugfs when the kernel is locked down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12768.1523477356.1@warthog.procyon.org.uk> Date: Wed, 11 Apr 2018 21:09:16 +0100 Message-ID: <12769.1523477356@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 11 Apr 2018 20:09:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 11 Apr 2018 20:09:18 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH wrote: > Why not just disable debugfs entirely? This half-hearted way to sorta > lock it down is odd, it is meant to not be there at all, nothing in your > normal system should ever depend on it. > > So again just don't allow it to be mounted at all, much simpler and more > obvious as to what is going on. Yeah, I agree - and then I got complaints because it seems that it's been abused to allow drivers and userspace components to communicate. David