Received: by 10.192.165.156 with SMTP id m28csp1177487imm; Wed, 11 Apr 2018 13:59:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/vsO2k4CfZGQ2bnvaNq7yY/zRsRfrD9XBlWaCEJhMrG6HaHo242AOPHBE5V9OskA+swESj X-Received: by 10.98.15.92 with SMTP id x89mr5307581pfi.7.1523480376691; Wed, 11 Apr 2018 13:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523480376; cv=none; d=google.com; s=arc-20160816; b=xC4wyCxSwtjEDdUMXT4/e6j+2T+9FI/cbcoVRxFnkwRaOTmHLcA8GS36/a+myHF1H5 dBmsOS8Zl+QE2VL1whwhwTQvZGVKGetgen3tZ64lhsd8fLGBEY3qdtCMS7b/ch8i+oH1 dFBlLmiq/6oNfP/VA/xF959YFtqY5DNlHeBsiN6j/jzB4PfGhoIRlf3yXgg91VgpUf0D ZwSbnNrZfKOkOLoXnn72jjzTNNNKqO0ThOQojiSMtMs4crvUHCGSuBPczLNeZBggt/KI UqMOCX4wSHqwXZ8KV6P4rpkTU3K8xJU9Fw9IGKdcIBmMQDaQjA1jJtwRHU4mI+tW+IUs I9BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=h5uj8d6ZKpp4tAsT9zLqewrvSzqPfMHTNViIoJDN+Dg=; b=prSmyOnNNH3VquGd9RFpSf/ndxoYGUBTsJXicJVqGdHTLwtfzN/whE8jjFYSOvct3b XTtt+makIrbY0lqC1QzRtNzb+DJE4C5a2dH8QdHR2jxcqYHuGYISpVRjFV4YUwDt9mcm MaGc565gKhEz/dHcxakSn91OYSp74ik2bbvCS9fMUpnNYWPTWLNXXSspVmi0IK9432Qj NabDvDBklehg6fWAajQsJ4ytyIUmrIA15y2kdoQbax/SAGG7bgwCEM7/+Bxi9XEghljW H1HnEM4OhcM2xsF9C13pi1DVsYzJjDIbLi9wdiQjxAl073Oqa8AG4ShXS5GfAPTP4hmK yqKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w8-v6si767990plp.521.2018.04.11.13.59.00; Wed, 11 Apr 2018 13:59:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755441AbeDKSoi (ORCPT + 99 others); Wed, 11 Apr 2018 14:44:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58278 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755426AbeDKSoe (ORCPT ); Wed, 11 Apr 2018 14:44:34 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8014FC06; Wed, 11 Apr 2018 18:44:33 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH 4.4 008/190] mac80211: bail out from prep_connection() if a reconfig is ongoing Date: Wed, 11 Apr 2018 20:34:14 +0200 Message-Id: <20180411183550.536813653@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183550.114495991@linuxfoundation.org> References: <20180411183550.114495991@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luca Coelho [ Upstream commit f8860ce836f2d502b07ef99559707fe55d90f5bc ] If ieee80211_hw_restart() is called during authentication, the authentication process will continue, causing the driver to be called in a wrong state. This ultimately causes an oops in the iwlwifi driver (at least). This fixes bugzilla 195299 partly. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195299 Signed-off-by: Luca Coelho Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- net/mac80211/mlme.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -4326,6 +4326,10 @@ static int ieee80211_prep_connection(str if (WARN_ON(!ifmgd->auth_data && !ifmgd->assoc_data)) return -EINVAL; + /* If a reconfig is happening, bail out */ + if (local->in_reconfig) + return -EBUSY; + if (assoc) { rcu_read_lock(); have_sta = sta_info_get(sdata, cbss->bssid);