Received: by 10.192.165.156 with SMTP id m28csp1200377imm; Wed, 11 Apr 2018 14:26:24 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/NSOO/yX41mIcYEHPQ8LXUT7aV+7Vkqszr6/lRqCNUVw6bjo7t+HP+W6Fhb4FNeC3xxnJn X-Received: by 10.99.103.67 with SMTP id b64mr4718511pgc.14.1523481984431; Wed, 11 Apr 2018 14:26:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523481984; cv=none; d=google.com; s=arc-20160816; b=Vz6LxyKzVqouy94bn1+HzybEnoWd2M7HZP2QdRAHiSqidOAf7RQDOzPLoJTGyoN7Wm 8vtvRs1kEp01EsbXoIwIN9RIrqHDNI3WKaBqwzXMuqSr9T3ZvC1dTBEK27joxT8mzS7s pqZxrhCzmVyFMUfcrQKUl53TeGoX4J7W/3m9JmE8rmyGr1cL7U3fF4h1/veBQER9HOi8 2JK/x3P7mwGbN+tmodRj4/KfYCYsUYSOIEKUK2TVRyvkKQFV31w5P66qPGEMIIeMcTFf uwcmfkNqyc9kdfDW5clnfOJXdm3X5neALNcaxR/yq0kRK+oX5rANx6pZoGyh11H6Psaa 29Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=RlBaWcGWKPXALgtEuogo70MnFy3ErIDg6DiRxKqbVVU=; b=Aw/WgSHRVYIqcS06axBF4cf+sc4kHFHr7tVH1HS4zD2nHB+5wndSjgGPVLyv+46XXw kVvwvDLdAEcV+GtPXZxKfYAcP2nArTJWqizfPuAGuHfIpzqIVBBA/u35vshFPpHxJTL/ uILsANn63+/3s5/clT2UW9pBZFnUBW9p7NZ+2YPpCjfQtmJCPDWXJ/2M5T1bd30ju9Tc F45YIAYLMsAWMKwgrp+2Sqp4wSRdEmIlzl/vSkiZ0X1zop7Vm/Z8MjTlw6MbGCtQP/Jb 0Iip6kIcQBdJ7u8ittUAf+RF+3eG3/8XGasdZDMfovQ0xyCuAFwit1kQU7Yz03JVze54 nCgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g66si1207331pgc.624.2018.04.11.14.25.47; Wed, 11 Apr 2018 14:26:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754299AbeDKSjG (ORCPT + 99 others); Wed, 11 Apr 2018 14:39:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55604 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbeDKSjD (ORCPT ); Wed, 11 Apr 2018 14:39:03 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CCD0DE93; Wed, 11 Apr 2018 18:39:02 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart , "David S. Miller" , Sasha Levin Subject: [PATCH 3.18 032/121] sh_eth: Use platform device for printing before register_netdev() Date: Wed, 11 Apr 2018 20:35:35 +0200 Message-Id: <20180411183458.034766543@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183456.195010921@linuxfoundation.org> References: <20180411183456.195010921@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Geert Uytterhoeven [ Upstream commit 5f5c5449acad0cd3322e53e1ac68c044483b0aa5 ] The MDIO initialization failure message is printed using the network device, before it has been registered, leading to: (null): failed to initialise MDIO Use the platform device instead to fix this: sh-eth ee700000.ethernet: failed to initialise MDIO Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2933,7 +2933,7 @@ static int sh_eth_drv_probe(struct platf /* MDIO bus init */ ret = sh_mdio_init(mdp, pd); if (ret) { - dev_err(&ndev->dev, "failed to initialise MDIO\n"); + dev_err(&pdev->dev, "failed to initialise MDIO\n"); goto out_release; }