Received: by 10.192.165.156 with SMTP id m28csp1223904imm; Wed, 11 Apr 2018 14:59:39 -0700 (PDT) X-Google-Smtp-Source: AIpwx483+C98U12nc/y6rPYit6FqCCYjxVgvQAgm5B8w5zJNByRgus0DEbsnozJ8AYyll2YzMdEb X-Received: by 2002:a17:902:2ac3:: with SMTP id j61-v6mr206807plb.224.1523483979107; Wed, 11 Apr 2018 14:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523483979; cv=none; d=google.com; s=arc-20160816; b=QrkfKp1l97VJ0Pe7EDWA4ngyjNH5Tq5JddBDk4dwuK1mseUET/5lP9r3qxW7iBTr7g +1GGae33Bq89hDR4+yAYBvxYDweBRiTVf8aDOplcOAaxW4Oppe34RcCeiBueZ+fSNohI hbBcA3RKY3Bw+3grrA1DSiGyqDhuaQqLMAn36PWyFmimkUeHz+mhCZC+5GEGy5PsksB2 4CQGQg0KrJeRPb79n+PkpflkX6cQiNJYoEHiKXpNnkHjmwbUAM+yFYfkwJfHWaMm0KTA idh3cFkn8EhKdnnRhrBS4kfKKjBPxkQQDwHHr0C7JE4J+FvMcY0Xt1HAHt44X/kFnE1C wK2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=0G4Jw01aM3Z1JJbDP8HVlPCT9wNUZGWilxO1Le/qho4=; b=mMqZTaOiwhRIVA/fdk/2Xt3uVhXWggnWxXSf/GDhjwu1W+m5CLkCe2fgsrBAhe9Z/A 9g4wtDi75FHynQ3rknA0x4VahuXMCSMZrhxvFyIUdPehEb0v2a+cAsUpuB9LYEqBRLAG j+5GwOTFwhNcgU034fDpVljyCsbipC9med5KsQuVRrN+1RIIrbj4s4iWr14k5bhOtZsq fXgfdL9a7rrUDQleQMkG9hEityexez7O1t+01o64uw18SJxH7Qbb7t+OwjTBf2r9ybgx bJ0goBWMSps5hrU7DR3JdZj1jj4LkCNcAHbIGMqlDPkdxncbqQ2Kx/Bkp20ewaz2jJUT Hl4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NO7HALrQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si1468767pfh.101.2018.04.11.14.59.02; Wed, 11 Apr 2018 14:59:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NO7HALrQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756784AbeDKT5G (ORCPT + 99 others); Wed, 11 Apr 2018 15:57:06 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:32959 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315AbeDKT5D (ORCPT ); Wed, 11 Apr 2018 15:57:03 -0400 Received: by mail-yw0-f196.google.com with SMTP id q12so971717ywj.0; Wed, 11 Apr 2018 12:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0G4Jw01aM3Z1JJbDP8HVlPCT9wNUZGWilxO1Le/qho4=; b=NO7HALrQEKBs/lmKgh8emdOjcilYXu9iM7OAAMaIQFNK8YiF7biJY+bAfvR4ZLQ4I/ zWIf6IsQNgKfC8pXqYHkCJVtPMp8pX/6PkGbc1KTPDVVbZDur1RqgH5kCBg5NzYc3xVx +yThgXMW1y1mdNWQmKC31bW9Us13Ps9Rrh8o6kG/kzZCDvbn5BfLp5Xoqs8CY5uh0fZK dVqq0RqoWk16FUyDRTCOHMAv6jceEH3DOlypG4s+tlbjVGIM2YY6Sqr3/Rxm+1XuLpQH ZYInfQJDsRsrBMTDSoBDr4zkFSk0e4F6CLmpa81p42b2TQUybEV+VYKLCDEdp4sVYemY LSTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0G4Jw01aM3Z1JJbDP8HVlPCT9wNUZGWilxO1Le/qho4=; b=bb+OWJMUbGz+a8ghYyYaErx8abB7i6NwBYxD93SVV70n1QJcqEYalKhTJawZkro3TL 6D26yNZf4lN2f9jHczAbt1i3JRbnhIMyH8QWExeROhboe/aCAcd/gK2MNfnQReAN/c8U YOxW03fcZ7DLzCy9LoI7iTkVKPOFXJUFHHoPo6AFefSPnLP4bZdN+tQyYnzDxDaonYVW Rp/8Vl4h3PNatxGwK/jsA46wyg7Z5xRSVZuwjCqG0SI4gKrE21d6qDmuUeXRjCzdA7mm 2y3Dx3lKIc0V/zyMQkEUks+bWhmZcIpNDlavbJnBjDJqye+h/TZXm3NknVJDKdbkuunw tlBg== X-Gm-Message-State: ALQs6tBnTHAV2rCTKqwvmOIdTzhELOtP3xcHVK7vUSfqBo/UDuvcm8Ts Hkg5ijqyuyTi6V6vx5AF8sY= X-Received: by 10.129.134.5 with SMTP id w5mr2689242ywf.428.1523476622351; Wed, 11 Apr 2018 12:57:02 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::1:e6ed]) by smtp.gmail.com with ESMTPSA id g64sm748220ywh.12.2018.04.11.12.57.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 12:57:01 -0700 (PDT) Date: Wed, 11 Apr 2018 12:57:00 -0700 From: "tj@kernel.org" To: Bart Van Assche Cc: Alexandru Moise <00moses.alexander00@gmail.com>, "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "nborisov@suse.com" , "axboe@kernel.dk" , "shli@fb.com" , "gregkh@linuxfoundation.org" , "joseph.qi@linux.alibaba.com" , "arnd@arndb.de" Subject: Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release Message-ID: <20180411195700.GP793541@devbig577.frc2.facebook.com> References: <20180407102148.GA9729@gmail.com> <20180409220938.GI3126663@devbig577.frc2.facebook.com> <20180411101242.GA2322@gmail.com> <20180411142019.GG793541@devbig577.frc2.facebook.com> <20180411142859.GB2322@gmail.com> <5fafe1cbf6b0111448a81005c1c16feee24a99ad.camel@wdc.com> <20180411190027.GA21274@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2018 at 01:55:25PM -0600, Bart Van Assche wrote: > On 04/11/18 13:00, Alexandru Moise wrote: > >But the root cause of it is in blkcg_init_queue() when blkg_create() returns > >an ERR ptr, because it tries to insert into a populated index into blkcg->blkg_tree, > >the entry that we fail to remove at __blk_release_queue(). > > Hello Alex, > > Had you considered something like the untested patch below? But queue init shouldn't fail here, right? Thanks. -- tejun