Received: by 10.192.165.156 with SMTP id m28csp1352341imm; Wed, 11 Apr 2018 17:54:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/S+cILGdoZ08wQ7vjtBogN+PMfeWJa7NDsHMQgxUqGhdLOceq8hos/5Vgj9m+qdNnvBY6l X-Received: by 2002:a17:902:70c6:: with SMTP id l6-v6mr7404668plt.201.1523494484426; Wed, 11 Apr 2018 17:54:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523494484; cv=none; d=google.com; s=arc-20160816; b=q70u5IynxmWzCloEANEWh4ZXjhCbM9uXZo8NjkefOnDuJ/HMQHKFRBOgprQF2sF1nr 4ISv5Aiy8NFvVj7I58i//pe1fVFaBcv+V1qy2w1un8zwErJWApIPSEmZ4SfPqEicKo35 AgXX9A/tiCqYoslhgBUYIuYjf+KDUK4P3kDAFe1tKrjY30ha6qGaWmLgh5EeJuUhujSe GxD6hPtbxef53+ENMugg3j2pjwVIw7d0B/v3s1RXk8/VwcNfZy1i8JpLYwFfJuw2c8jW 2Lp15fmDG3e6qm7jl58NTktGvrz3cAwrmQ4yhxMwGU2qS7KfP1i9p4ku0In6cfrZIl/p 0HDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:references:in-reply-to :message-id:cc:to:arc-authentication-results; bh=7COMICr9oazGnJJI21dcV1tnMkfytBa4TaZh7mBbpRU=; b=azpZl09lfk98tGcwLTrarJ6FFU09IKXHMFIdaVvETOVpLvjxW/ynoTQWKEN/9N2tRN ZIYZQq4/CUhEnhWi3JBTlLmkwa/DNLY4mnNOCw1nRvAzs5TNT4G01jQgaKHNPR7TT5s+ 4773xhX70q7jisAMs6ydqvAs/Cp6yXHB+DNY9tMF6YXJ7QAFpJ5EtTpnTfpUKaCj1jjM F/RPd5enVsQPusq+Gqadnkw2Mn3TzvP/fWUAypf8Q87F4iLB0+1rMi7XY9+1V/OKK70L nLyPY2JDoaTn4lDxN0oKA6MPcftSuZY04FYw3GTt8exAW7zieNN3ZrlnQkAyTDg9qZBQ +q9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18-v6si2258849plo.647.2018.04.11.17.54.07; Wed, 11 Apr 2018 17:54:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbeDLAuZ (ORCPT + 99 others); Wed, 11 Apr 2018 20:50:25 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:39860 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbeDLAuU (ORCPT ); Wed, 11 Apr 2018 20:50:20 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id B82A7299E7; Wed, 11 Apr 2018 20:50:14 -0400 (EDT) To: Geert Uytterhoeven Cc: Jens Axboe , Laurent Vivier , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, stable@vger.kernel.org Message-Id: <7f3cf4519b38aeadb3c2211629689dce920fe610.1523493475.git.fthain@telegraphics.com.au> In-Reply-To: References: From: Finn Thain Subject: [PATCH v2 10/10] block/swim: Select appropriate drive on device open Date: Wed, 11 Apr 2018 20:50:14 -0400 (EDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver supports internal and external FDD units so the floppy_open function must not hard-code the drive location. Cc: Laurent Vivier Cc: Jens Axboe Cc: stable@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier --- drivers/block/swim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 2c75761b61e8..0e31884a9519 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -648,7 +648,7 @@ static int floppy_open(struct block_device *bdev, fmode_t mode) swim_write(base, setup, S_IBM_DRIVE | S_FCLK_DIV2); udelay(10); - swim_drive(base, INTERNAL_DRIVE); + swim_drive(base, fs->location); swim_motor(base, ON); swim_action(base, SETMFM); if (fs->ejected) -- 2.16.1