Received: by 10.192.165.156 with SMTP id m28csp1640055imm; Thu, 12 Apr 2018 00:29:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx49k3o9iovFYbc7ZZOaXljpn6VTaYcH7yg82GphdZ5HJzH5u3UIurpy3AyvpAJhKHrKkKF46 X-Received: by 2002:a17:902:3f83:: with SMTP id a3-v6mr8567747pld.279.1523518184833; Thu, 12 Apr 2018 00:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523518184; cv=none; d=google.com; s=arc-20160816; b=DTWTEQNPodYRsU85C3F91TOLujvota+1upAClHIoe8WeQW+vPf3cVE2i71AcW2cfad x5nBsVqN5xZ8foN9vgyEAZrg5OhGTu+G8px8113HHsJlhmGZTQ46l1IU90KEJcv9znHO T5dvZZYuw2IbjCH3SKZNWm3l5P8kP54J7g0qOU11JJ6rdcgjcIuWm6K+aUJuD7jyiNko ZLZb1uVsLZTOVevC4dyqLAmVOeOEn+HCJcp+T5xg7TbsoFdVZByXCEdfIwY9wXwkMyRr gPyRfMuFLbBIN3GH0EZ0ophCx9iAEvjvMdBI1tSruH3wkhq4RfSH33s+nPXjnzPZEK1+ qolw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=gQ3DE2PCmIE567BXW1QK/eePaTMKJD9+V539gKk76bM=; b=a54TIz6247vCKsTMaQQ0w2Ajj8Wq6X+pEFVOsTYwVUwFaYW0joCjJz309NKWhjfMMO 6i/mG88jlW1TJGgwp3PFVaQRX8y31u2dP3IzWD2thToKNPgiSa1Nq7hV6svBE/X3qAoN xaV6PC+sJgzbnlHQ+T1pRjZypkCV+16I9v5vPyZlJ/1SILHpd+Ek2eqpupYlb3gxK1cF w2y3zcLC7nM7Olvdai352CSexclrw1blGSr28DHEYmbdCf2znR5TzZTdvcH+8Yhm6fqv d3xTrrFfvdFcf8fHQAnAOom80P663TWhMQdp2HMX6yp3eyyN+/NLLaDjJsN/pTBThoPD XgqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n124si1869282pga.53.2018.04.12.00.29.07; Thu, 12 Apr 2018 00:29:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbeDLH0Y (ORCPT + 99 others); Thu, 12 Apr 2018 03:26:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:27989 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbeDLH0X (ORCPT ); Thu, 12 Apr 2018 03:26:23 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2018 00:26:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,440,1517904000"; d="scan'208";a="46285648" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 12 Apr 2018 00:26:19 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 12 Apr 2018 10:26:19 +0300 Date: Thu, 12 Apr 2018 10:26:19 +0300 From: Heikki Krogerus To: Tobias Regnery Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: typec: ucsi: fix tracepoint related build error Message-ID: <20180412072619.GF7517@kuha.fi.intel.com> References: <20180410083806.27874-1-tobias.regnery@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410083806.27874-1-tobias.regnery@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 10:38:06AM +0200, Tobias Regnery wrote: > There is the following build error with CONFIG_TYPEC_UCSI=m, CONFIG_FTRACE=y > and CONFIG_TRACING=n: > > ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_register_port" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_notify" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_reset_ppm" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_run_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_ack" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > ERROR: "__tracepoint_ucsi_connector_change" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! > > This compination is quite hard to create because CONFIG_TRACING gets selected > only in rare cases without CONFIG_FTRACE. > > The build failure is caused by conditionally compiling trace.c depending on > the wrong option CONFIG_FTRACE. Change this to depend on CONFIG_TRACING like > other users of tracepoints do. > > Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") > Signed-off-by: Tobias Regnery Acked-by: Heikki Krogerus Thanks, -- heikki