Received: by 10.192.165.156 with SMTP id m28csp1740224imm; Thu, 12 Apr 2018 02:40:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx48H9XjMv/i2ktYU7+pY5pHxdAIXpQQZ51B4x4II26Mnf5Q6D2DQOnX4Ux3slIxPrF4n7gKP X-Received: by 10.99.148.17 with SMTP id m17mr162719pge.140.1523526028210; Thu, 12 Apr 2018 02:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523526028; cv=none; d=google.com; s=arc-20160816; b=Ijzs6HVQ1QtGWct+aM1at5Vm1RdxnQZubQqDPJj2D1v3phPMX/9oFlvzQKxuPjTuid /jptC3ex1Zl56zsH08v8DpdS2GsQNTfh1AdBoDe8iTVdVZuZeNKyA6Q3Diqd36onLQ9R sRJyBVAfMsXL5vJ6HELOjUYp1dIHlSVgwT2onKPa1sQM0HBtS5s5U3Waa/qBdHMQ82VQ 0+e1ZYBVNWYwDXsUdfusfVmuqWzXuV/pg3yb5iWn5L8knSoFf6DcH9zEvURkQ1weKW56 7Jb7q0vaFhwtnctOE7Bvh3+3TYPqkc92hLTzTTlLBVxSWm+9n40uSaGvOGhGTJXCcCoc GJVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=SY19eQKpuyPCeWNWvLswVhUTkeKOHhBfwoqNUgya31s=; b=B0SMjT5SPvchIliMfvHLBwThZKFMboGPmvSOLBCp/UuFfxuTdQ5ipcK0icgz5KJb6U iUg4GpiScsoOWr0T74h8WNAyOCqJP/K+0fIJkPnzk0lNm/CyAyd36YmgJzlL0m0DzdIq eXoaWMKX1stqZum3YTtOItph/yubdJ6uWD580vcV8O+gPS+4YFiVZV78v6dM0TxejwA8 TuneNFUG0NVHRAK9JIggFW1iJ5V/qovF9irNpjXtgDVpYRYZWufMZZmSE+FP3cpBEnXc YTNQwaI20diaIvsUN2Ogx6ziyL8HhA8Y/iv0m844Aqguu/fhsyRv/xcvzM85d1mXPthA CyUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si2309622pfl.165.2018.04.12.02.39.51; Thu, 12 Apr 2018 02:40:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbeDLJgv (ORCPT + 99 others); Thu, 12 Apr 2018 05:36:51 -0400 Received: from 9pmail.ess.barracuda.com ([64.235.150.225]:33933 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbeDLJgu (ORCPT ); Thu, 12 Apr 2018 05:36:50 -0400 Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx1.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Thu, 12 Apr 2018 09:36:20 +0000 Received: from mredfearn-linux.mipstec.com (192.168.155.41) by MIPSMAIL01.mipstec.com (10.20.43.31) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 12 Apr 2018 02:36:36 -0700 From: Matt Redfearn To: James Hogan , Ralf Baechle , Florian Fainelli CC: , Matt Redfearn , Namhyung Kim , "Maciej W. Rozycki" , Peter Zijlstra , , Paul Burton , Ingo Molnar , Jiri Olsa , Alexander Shishkin , Arnaldo Carvalho de Melo Subject: [PATCH v2 0/6] MIPS: perf: MT fixes and improvements Date: Thu, 12 Apr 2018 10:36:20 +0100 Message-ID: <1523525786-29153-1-git-send-email-matt.redfearn@mips.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.155.41] X-BESS-ID: 1523525780-298552-14027-32435-1 X-BESS-VER: 2018.4-r1804052328 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.191914 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series addresses a few issues with how the MIPS performance counters code supports the hardware multithreading MT ASE. Firstly, implementations of the MT ASE may implement performance counters per core or per thread(TC). MIPS Techologies implementations signal this via a bit in the implmentation specific CONFIG7 register. Since this register is implementation specific, checking it should be guarded by a PRID check. This also replaces a bit defined by a magic number. Secondly, the code currently uses vpe_id(), defined as smp_processor_id(), divided by 2, to share core performance counters between VPEs. This relies on a couple of assumptions of the hardware implementation to function correctly (always 2 VPEs per core, and the hardware reading only the least significant bit). Finally, the method of sharing core performance counters between VPEs is suboptimal since it does not allow one process running on a VPE to use all of the performance counters available to it, because the kernel will reserve half of the coutners for the other VPE even if it may never use them. This reservation at counter probe is replaced with an allocation on use strategy. Tested on a MIPS Creator CI40 (2C2T MIPS InterAptiv with per-TC counters, though for the purposes of testing the per-TC availability was hardcoded to allow testing both paths). Series applies to v4.16-rc7 Changes in v2: Fix mipsxx_pmu_enable_event for !#ifdef CONFIG_MIPS_MT_SMP - Fix !#ifdef CONFIG_MIPS_PERF_SHARED_TC_COUNTERS build - re-use cpuc variable in mipsxx_pmu_alloc_counter, mipsxx_pmu_free_counter rather than having sibling_ version. Since BMIPS5000 does not implement per TC counters, we can remove the check on cpu_has_mipsmt_pertccounters. New patch to fix BMIPS5000 system mode perf. Matt Redfearn (6): MIPS: perf: More robustly probe for the presence of per-tc counters MIPS: perf: Use correct VPE ID when setting up VPE tracing MIPS: perf: Fix perf with MT counting other threads MIPS: perf: Allocate per-core counters on demand MIPS: perf: Fold vpe_id() macro into it's one last usage MIPS: perf: Fix BMIPS5000 system mode counting arch/mips/include/asm/mipsregs.h | 6 + arch/mips/kernel/perf_event_mipsxx.c | 257 +++++++++++++++++++++-------------- 2 files changed, 158 insertions(+), 105 deletions(-) -- 2.7.4