Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Apr 2018 15:28:59 +0200 (CEST)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Joe Lawrence <joe.lawrence@redhat.com>
cc:     live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Petr Mladek <pmladek@suse.com>,
        =?ISO-8859-2?Q?Libor_Pech=E1=E8ek?= <lpechacek@suse.com>,
        Nicolai Stange <nstange@suse.de>,
        Artem Savkov <asavkov@redhat.com>
Subject: Re: [PATCH v2] Add livepatch kselftests
In-Reply-To: <1523373354-10801-1-git-send-email-joe.lawrence@redhat.com>
Message-ID: <alpine.LSU.2.21.1804121526110.4758@pobox.suse.cz>
References: <1523373354-10801-1-git-send-email-joe.lawrence@redhat.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Questions for v3:
> 
>   - Should we split off the atomic replace and shadow variable update
>     tests so that the this patchset could be merged before the ones
>     listed above?

What Josh said. If we merge it almost together, there is no need to split 
it.
 
>   - I didn't remove any of the sample modules.  If anyone thinks any of
>     them should go, let me know.  They serve as nice, simple examples so
>     I thought they should all stay.

Ok

>   - Module naming convention: to make the test script easier to grep
>     module names and filenames, I broke with livepatch convention and
>     used underscores instead of dashes.  I didn't think it worth the
>     regex foo to flip back and forth in the test script.

Ok

Miroslav