Received: by 10.192.165.156 with SMTP id m28csp2023311imm; Thu, 12 Apr 2018 07:25:16 -0700 (PDT) X-Google-Smtp-Source: AIpwx49wyFj5WhkTse8UM+Aer64e7K58FefZePSylQzuX6QOpKtmUUwQkqUWVUEfcz9Jy3omqZx4 X-Received: by 10.99.120.196 with SMTP id t187mr893905pgc.149.1523543116528; Thu, 12 Apr 2018 07:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523543116; cv=none; d=google.com; s=arc-20160816; b=mVJ9//rf7nZMFEkZdN9+3DwwCU+3dzBJJCPHw/Wbr0bzgm2tgvoIarwXzDm/VGkmbQ mP87v3YDpA7XJ+q5jvILTiTsCa8pP6lygek6SNvmC/f/RcPYA54a/CnvvD9jvUTeBVcz 3dQb//+jU2EobZLl2UJasNVEFD+Jv1c/oEjz7VAwS7u2VRLuuHV+cmIH1+WVeE/1UiHh w2MxTHYfVa+sI6nFMAWz3WkUZPtnp7oZzZbcYCwIk4w5l4lzCRo0zIPs7bum+I9tUjYt veZ4b8QjwKSdrjTaFEqh7Ags+Qa7E+vp4sSC4PTbp/goOxopkiCWPwI1RwFbWqYOhADA l3cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :dkim-signature:arc-authentication-results; bh=gOePZq6/BEqfu+MRZK10p1n3gwkv9l47Ic4PwzcrdWA=; b=xZLQ1pRLG0jXVNk1mHKzsiafqrvLiHjVCn2PtfEcdi4t02ULN8znH1K4LELKcdbgn/ dHTBGC8m6D1KX7Bq67DV7hiBWfficUqQpdEX5l9050QcT8ABMdEncUEROgMwzAH/nbP3 hYNzyNiGXn4YYH8Aj4Me3HnWV7clbgqP/CUAQGJDR3N90kg6HE0TyIjWD6fLQdUVJZRQ Musy0Mv3JxQb548KP4i03o4vLw/vpqdQJH9K0HX7LshL562IPPsv0uEuzrK65wNPsq5y 9RjIuvbIeSj2wqb2w4dEnCBSGlPvLDihUJzpV8ohORJjArgi0D8V/JC8aGFUWG1xJGQm Rz1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@raspberrypi.org header.s=pp header.b=jPeM68NN; dkim=pass header.i=@raspberrypi-org.20150623.gappssmtp.com header.s=20150623 header.b=aPbXV3b6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 75si2679443pfx.61.2018.04.12.07.24.39; Thu, 12 Apr 2018 07:25:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@raspberrypi.org header.s=pp header.b=jPeM68NN; dkim=pass header.i=@raspberrypi-org.20150623.gappssmtp.com header.s=20150623 header.b=aPbXV3b6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbeDLOSq (ORCPT + 99 others); Thu, 12 Apr 2018 10:18:46 -0400 Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:41668 "EHLO mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbeDLOSn (ORCPT ); Thu, 12 Apr 2018 10:18:43 -0400 Received: from pps.filterd (m0102629.ppops.net [127.0.0.1]) by mx08-00252a01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3CEE22o024921 for ; Thu, 12 Apr 2018 15:18:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp; bh=gOePZq6/BEqfu+MRZK10p1n3gwkv9l47Ic4PwzcrdWA=; b=jPeM68NNlwNSmgmurlMSjnmQ/v80vKw3PveLlrYnDIBUlpFxoZzSYy0gjSEoyFaoQw4v kIwh/7IV9Xn76lQkBVJSCIvuLH0sJ69t4EuKs7Om84bP0D+AcKfz/HQboEsSVmOmwtrx kcf0unTzrdrcRObQgndps0kgEGG0ph+jzIqvy6ATpvqwAhSILfz0Gwwd+IVawXl16KoC 64WBCa58ibuqdFTHqMwpoWARwx1D4yVCbNJowL3NiAwaBKs6ui7oYshvL8Q1glu5YARV ZiRPFsEYWxtl4DVCg2YxH3BQWKVO/8vUWTrhdo1kF8Va9Lnd2m7LQtpsNd5VBhtOCgET Zw== Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by mx08-00252a01.pphosted.com with ESMTP id 2h6trdtk38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Thu, 12 Apr 2018 15:18:42 +0100 Received: by mail-wr0-f198.google.com with SMTP id v11so3135342wri.13 for ; Thu, 12 Apr 2018 07:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi-org.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gOePZq6/BEqfu+MRZK10p1n3gwkv9l47Ic4PwzcrdWA=; b=aPbXV3b6Zlrc62bwG71q5JeZAF1LwBnP8mSWbrmgaPbIcbVCi6YBM9b9BGFbOi5wwe r9TOVvU62lP4GmyEYrgxJb7nZh5Am4dFzHLZM4jtd5MdRF/RvRASkqWwhMEeSId9MSoq siKP+L8WyVtZkSZ3AvvBZYpnjP2rtIkzJJ10Vcp7KP56FRP+7gDNhGxqQhW9xtL0glL1 yzP4lrK2nsnXZLusRgO1vdgCq8kYU9YPjo+odm5UNpVoPG0lofzZBVZic+yMi1zvKwaG yc5klIdtZYIsmvw3M63Jqp3jCMYlsOmdA3LSF8zpXQII/AximVlzhFRoHNarlNkNog6I AHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gOePZq6/BEqfu+MRZK10p1n3gwkv9l47Ic4PwzcrdWA=; b=EFOprWOhDuuOGhrKyiFAJBWFUxZ+kpQfmIbXQorBKkIN/+TYTY3+YKUR0sAKycgWXG ztrnWup3XqboY8afJU4TvVoDq0VbOWXBERY7EUXuPW4Ze9BiMhCjI1TJEgJQidZVS0Ps M/9TpUcNHuHD1mCX5SICdy4D7DjmGGWNHuz1HfUbaHePbU7dxy1dS5+janA7kpfhgWMt D8/5QPssX5BxgR7NWxOgeRoGKuJFC8ODcN0Uzd2cGudx15Ual2jp7XInnTLEtXZdcJpe wtN/GxOG4sHKqJ74lbF0ONOSVQTpMEwy63qym+9n3ZxaiNotW77ULa96FncK3ON+8PPH bQ8w== X-Gm-Message-State: ALQs6tDlT2VDrPTdbFgZ917sBM3dtat1bJwei7Nk99AoltEhhBajiT+R xsBiSdu4zC0K2W031ZIJzrL85CT+CvyxLLtPC8Ry7egnAI2g7STYXrqTkXo7S1DpR4WsA9a1Rx6 pVvTu2cP/sjornja+P8NYeE8t X-Received: by 10.28.34.7 with SMTP id i7mr835547wmi.97.1523542722005; Thu, 12 Apr 2018 07:18:42 -0700 (PDT) X-Received: by 10.28.34.7 with SMTP id i7mr835527wmi.97.1523542721847; Thu, 12 Apr 2018 07:18:41 -0700 (PDT) Received: from ?IPv6:2a00:2381:fdf7:14:8da9:f6b6:f0c3:26ea? ([2a00:2381:fdf7:14:8da9:f6b6:f0c3:26ea]) by smtp.gmail.com with ESMTPSA id e202sm4968138wma.43.2018.04.12.07.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Apr 2018 07:18:41 -0700 (PDT) Subject: Re: [PATCH 1/4] lan78xx: Read MAC address from DT if present To: Andrew Lunn Cc: Woojung Huh , Microchip Linux Driver Support , Rob Herring , Mark Rutland , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <1523541336-145953-1-git-send-email-phil@raspberrypi.org> <1523541336-145953-2-git-send-email-phil@raspberrypi.org> <20180412140640.GL28963@lunn.ch> From: Phil Elwell Message-ID: <4f95f1bc-412f-6926-0a61-f00e3abe7ecf@raspberrypi.org> Date: Thu, 12 Apr 2018 15:18:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180412140640.GL28963@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-12_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 12/04/2018 15:06, Andrew Lunn wrote: > Hi Phil > >> - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); >> - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); >> + mac_addr = of_get_mac_address(dev->udev->dev.of_node); > > It might be better to use the higher level eth_platform_get_mac_address(). OK - I'll take your word for it. Phil