Received: by 10.192.165.156 with SMTP id m28csp2078016imm; Thu, 12 Apr 2018 08:15:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/DEvAbNIfVo2We1skZzTwbuL44u2t8kLcBRXng0QKoUmnReRmjMvzoG5p63CA2vpCt7JW4 X-Received: by 10.99.2.202 with SMTP id 193mr1030440pgc.117.1523546114622; Thu, 12 Apr 2018 08:15:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523546114; cv=none; d=google.com; s=arc-20160816; b=K+wdK+HK9lMsjErtaPnNnkV1sX7hbrVE3A6ccE/MUoAFZyWhi3iQfPf0yyLVYw16+k mIUL6JEAPSMPZfONfZSwcBINIstDUdmcvGUmqrN5891tcEY3nre8+64Vm1IHAfAzQAHQ cyyNXJIGbmqZMWjOH54MQMvsmTKqJetplhiRcdUn8wdDDVtsAOa8+AaRnCu/WCDPkaC5 QYWWCeCCB/tJaxeJycEFilNXMyS9VxGsprtZJyqrgkoaLtiePGa+0eh0uze7Mgarbvn9 eGdTtffhj1bLX5E7rnkt8AxVE/aMnXT/GH6KuBbe3N5Tt/hCh3SXUFGzs5yZsXfmLumQ a3Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=yGeWXQdU+PKSAvgvV1MrYTtLhzrSyiGAu8XyHaXNYzw=; b=0Gra0yYcYXfiXL+7m3jfnEo+G9qkMeHToF2HVlKWcLXeLOFi3sdKexo934b91va+m7 HDrIBa01JU1T6Wp5co7ttNAb53rtAQ5/m+WHBNVUPDoetcxcp9y/DZZ7P476Fi3tgvJa FqqSjRp70xow07hRuAlUtl29P6VxQWX0wJHqN67hHWVAcsyI88iHKLZjIAh+H+kfL60O rc4NJc3DyZiigvDJTA6gDYISV8zBeeO0kR2HzowpZIqpnqw99tvGpFqPQZ5E5ekiU924 1sQaDO91XePnTukQ1S3vV2wZHkZtKWq+8Siow9eIM0KUpk/AZDG/+AdN4z76U1PduGy2 OsGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b61-v6si3537307plc.500.2018.04.12.08.14.37; Thu, 12 Apr 2018 08:15:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753744AbeDLPJJ (ORCPT + 99 others); Thu, 12 Apr 2018 11:09:09 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:39370 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645AbeDLPJD (ORCPT ); Thu, 12 Apr 2018 11:09:03 -0400 Received: by mail-wr0-f193.google.com with SMTP id c24so5466420wrc.6 for ; Thu, 12 Apr 2018 08:09:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yGeWXQdU+PKSAvgvV1MrYTtLhzrSyiGAu8XyHaXNYzw=; b=E3R8pw+YQnlLf+wPq54eH0EpUjb/AY6Ns48+SruZIL780gDG7AF8M8B5GHakc51CZ5 qBEUDCtp+FK4qDOitTventZZ9plKwjbalZr37M9BDxpzZB/LlO+9obW4zXRT8jH73Yet Pw/56qShC8FFn52TGzZOHiBZcjBhGK5/sxmEXof0tv7uHZ+RXfF/lWI1Oi51JnJNcq27 d9nJoZCrXwr3751N/Yt0k+lFAJ8bG1rb/qSbRZLg8JTYvuS3+jXXDHwh5ZcBaswu1H9f nhUeV5ctH/UpQjFatKR2uGj8rB1z9v41u46JzFVjVfVDrI1MlE0DX23fH0aIEttS4sBZ xkNA== X-Gm-Message-State: ALQs6tBrlDWfGNfe0VGLS6oACvE4Ofu2n/BmYKC3Xhaaf1Y1cBS3UzH1 gFN5exDeeId7ghdYEYZsL9BIdw== X-Received: by 10.223.142.244 with SMTP id q107mr1114278wrb.64.1523545741922; Thu, 12 Apr 2018 08:09:01 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (catv-176-63-54-97.catv.broadband.hu. [176.63.54.97]) by smtp.gmail.com with ESMTPSA id p197sm2621783wme.43.2018.04.12.08.09.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Apr 2018 08:09:01 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 26/35] Revert "ovl: fix may_write_real() for overlayfs directories" Date: Thu, 12 Apr 2018 17:08:17 +0200 Message-Id: <20180412150826.20988-27-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180412150826.20988-1-mszeredi@redhat.com> References: <20180412150826.20988-1-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 954c736f865d6c0c68ae4263a2f3502ee7c447a3. Overlayfs no longer relies on the vfs for checking writability of files. Signed-off-by: Miklos Szeredi --- fs/namespace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 9d1374ab6e06..9ec9bf74116b 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -468,9 +468,7 @@ static inline int may_write_real(struct file *file) /* File refers to upper, writable layer? */ upperdentry = d_real(dentry, NULL, 0, D_REAL_UPPER); - if (upperdentry && - (file_inode(file) == d_inode(upperdentry) || - file_inode(file) == d_inode(dentry))) + if (upperdentry && file_inode(file) == d_inode(upperdentry)) return 0; /* Lower layer: can't write to real file, sorry... */ -- 2.14.3