Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269583AbTHSJuG (ORCPT ); Tue, 19 Aug 2003 05:50:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269639AbTHSJuG (ORCPT ); Tue, 19 Aug 2003 05:50:06 -0400 Received: from hq.pm.waw.pl ([195.116.170.10]:2271 "EHLO hq.pm.waw.pl") by vger.kernel.org with ESMTP id S269583AbTHSJuC (ORCPT ); Tue, 19 Aug 2003 05:50:02 -0400 To: Jes Sorensen Cc: Pete Zaitcev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] RFC: kills consistent_dma_mask References: <20030818111522.A12835@devserv.devel.redhat.com> From: Krzysztof Halasa Date: 19 Aug 2003 11:49:28 +0200 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 22 Jes Sorensen writes: > Bzzzt, *wrong*! Take a look at drivers/scsi/aic7xxx/aic7xxx_osm_pci.c, > if you look at the code you will notice that the hardware does support > different masks for consistent vs dynamic allocations (32 bit for > consistent vs 39 or 64 bit for dynamic). The hardware, maybe. > However make a note that the > driver uses the current interface incorrectly and thinks that > pci_set_dma_mask() actually applies to pci_alloc_consistent, which is > something it never did. No, it nearly always does. Looks at the actual pci_alloc_consistent on, say, i386. Will it be ok if I fix the consistent allocs to use consistent_dma_mask (some drivers will need a fix on i386 etc.)? -- Krzysztof Halasa Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/