Received: by 10.192.165.156 with SMTP id m28csp2156833imm; Thu, 12 Apr 2018 09:28:40 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+L/oOAbPxi19F7pnMXE5uIZERJTHTRkCNJlv9lBTvHP+N0v4n7vpXi6lXz49McdZwyAk4H X-Received: by 10.98.220.86 with SMTP id t83mr8269852pfg.60.1523550520508; Thu, 12 Apr 2018 09:28:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523550520; cv=none; d=google.com; s=arc-20160816; b=g1dYJ7kHC829qF+q3PuZDCLXsX8ySC7gt8TW4Xk9HBBaFOwXDq8z/1bmoE8maG4lFH rvGTOnSE2oXrQjldOoPUWbQ/WBsiGf/c4GB3Qjaogd65UNsb6/5blCiSqSt65ZkohEYw j27CSOGZR4kDssCS9qMsX55Y1qMAxt6w8gugBJAhCCWAtYuPyC5hr8JkbZaPASPGw/xi ffn6gwu2rBIan3DzIg3s1kXUMvQrlGKh8sd58dzsqbIElgRCmGEANfKPLr9WMqJ3gmAa +RqYUYrhtikfhJxY6Rhc3iVpPzh8XOs+LPg59/4Ubw29Zs+/eLPnkZQKKaUMcDFWGbfb xocQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=maDeUUq1QTreIZkzI0R+p2gC6PBQCJWiSXFPOEpWfSs=; b=Moy3hkbxmhrE92G6GDqU3ir4uapqW9xlrna77XlCDFsg81Ere0ou2M01FfoDoK2G+m SAG8wKvrKR08YUBb/EiqW8wjAs984es8geMWceO4aT2bxW4hEoJVIvAGEpjdoROWgrWa DhkugUf7nOLT9TR9cptN82fMKVQ1ex898Uq/Qg55T/NTfNjrIVIKM+k8zHow3eeREN3k BBUxLm9qNKPHGZvowN28Yxx5NY5HQJA9+0//iIuw9gV+jwLfTjzNNulCc5iykl6Skufw zHovuSncBX5qbAeZchQ8Ncxz/8dJ38HEJKlEsGzSWlJllIEq03OFhDlwGSQxe8x6+yJt BAIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hXRb+wVS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g185si2486755pgc.155.2018.04.12.09.28.02; Thu, 12 Apr 2018 09:28:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hXRb+wVS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbeDLQZD (ORCPT + 99 others); Thu, 12 Apr 2018 12:25:03 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60566 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbeDLQZC (ORCPT ); Thu, 12 Apr 2018 12:25:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=maDeUUq1QTreIZkzI0R+p2gC6PBQCJWiSXFPOEpWfSs=; b=hXRb+wVS64yZiaYYPesDuOrvs KckSm/5RC2pzaHdtfM4D5Yx4MIc483+oH1adCcUhy949e5kA3lrAe6lxPQQOYxnqx42Nt7WNBmNVv f4XLBDcjFhKlYaEIGVMl5r5SYZLZ9YKYVdb0oECiJgnpbDTTAeLlQoxTeI6lg6Rn3gOMxdNTuyX0q atDIwROPzeJX3UTNY+tMNgjczXT2rJw/Mv3SVVNwZ4Pqv8Dke5oV/TveaJqomGkxDcHP2ZfMcdSoy MrxetmUN+OfGoI1FNjMi4mZeDgMcCIPo9999ibohDjt7GADAOR4VN37pZHABg5LMmWqafFW/p64bd 3nXTU1/FA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1f6f1x-0005nB-5K; Thu, 12 Apr 2018 16:25:01 +0000 Date: Thu, 12 Apr 2018 09:25:00 -0700 From: Matthew Wilcox To: Miklos Szeredi Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 01/35] vfs: clean up dedup Message-ID: <20180412162500.GA24728@bombadil.infradead.org> References: <20180412150826.20988-1-mszeredi@redhat.com> <20180412150826.20988-2-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180412150826.20988-2-mszeredi@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2018 at 05:07:52PM +0200, Miklos Szeredi wrote: > +ssize_t vfs_dedupe_file_range_one(struct file *src_file, u64 src_pos, u64 len, > + struct file *dst_file, u64 dst_pos) Why u64 instead of loff_t?