Received: by 10.192.165.156 with SMTP id m28csp2333015imm; Thu, 12 Apr 2018 12:28:43 -0700 (PDT) X-Google-Smtp-Source: AIpwx48dJxZoyy4YcxPo8wDH2IeGqZKilMKjzQgiV2aeKjdBlc59Vl0rDyLCTzdpr8y+OQwiCu4P X-Received: by 10.99.176.12 with SMTP id h12mr1654879pgf.448.1523561323555; Thu, 12 Apr 2018 12:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523561323; cv=none; d=google.com; s=arc-20160816; b=Gz2PRzmsFSR3QBkZ1+sGb2Tg+n3CFsRm19RWSwbvCZoTYLGk4vJfQTWDbu/PfrNLa5 AAPSWhu+fF3dh4Lb8VWHw/u/x98sOyHy/ol7vDtIDTATqYKsUHvDxTc/jjIdMybzRYS/ 7ALghYkL8KYk2/XUQVBKhJXMYp+dzy2HAwUvHFCcApDuTWvsRtdKK0hTgep7/kvxrlFg q/M7u7IEhNqn188lnhyPxR595Jk/9hduDZ8bHaSdcIHv0EHWS5GFa3yxUfh0xi/OF5b8 nGetfd0HrbLA2dD1tu7jWnmoOOL05bsf1sL8klLcfyIk+Ho5GBL5e37pjTNs2wYtlVdf MiEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=QotMc270ofEL9dFTkTjL8JY+beIxB2tby0JZp/92OlI=; b=OHLI8lUqL3cPqPGX/8KEmX1NJFnEk0er7Woap2ujYUr0BaVI5+ipB0xVhY1eS9dToh L1/ozbeP79YjNGt69Wnh9M2CjK6DhoJQAjFpoAK8cNa8s3/0B7uY3/gB+JlyyA7EJcjU heij/7sLdceMQID+UMqCDUMrDkWyZRIIlfH/H5KgFPVflJ6Qe8x5sBqdpex8jApa+0bv Y6u4FLZ9svQ6fhWgKsjF4lRrPi0SxXptStRSJmmtmhSBiCLaaVsEiS5/GhrE49YwA1AQ BEw43uc9Q+qcoQTHEOxWpp95wqNknqCv+OrMAA6/dcAB4er0MTR0kjrEPnaJjytCBqdR R0hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cK/PuhR+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q62si2707533pga.177.2018.04.12.12.28.29; Thu, 12 Apr 2018 12:28:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cK/PuhR+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbeDLTYb (ORCPT + 99 others); Thu, 12 Apr 2018 15:24:31 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833AbeDLTYa (ORCPT ); Thu, 12 Apr 2018 15:24:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QotMc270ofEL9dFTkTjL8JY+beIxB2tby0JZp/92OlI=; b=cK/PuhR+M2EyDValsUprM7xsg IDAwMm0SLBwbPL4rF2hIHPP2pRBNe+di2wiE/lj2M6x7kdQP5CL0Pr3KHUApaOJqZZkcKSNS1MWNm 6dKFjFdogwOl2RZRiuxMVokmhITAG0xEYmxPCxqIIhhX+HpaDixNFIfLMYZs7Z/WAPjgbyIYTinab KrMWBdZ0gsJVbQjwsWYY7u4URzHnlzdmMR8AC9cVXpR8OU4FjqtxmvP98HPR1Qr7r3BxGH9C1vRm9 vR74NQXJm1RXB+vVLXwwCjOGGapyFcf7RyASH0jnz1nidWlqmKaZ6vRV3bjsJu/A3fjQgfoK3QoqF cYNP5toGA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1f6hpZ-00080W-02; Thu, 12 Apr 2018 19:24:25 +0000 Date: Thu, 12 Apr 2018 12:24:24 -0700 From: Matthew Wilcox To: Minchan Kim Cc: linux-mm@kvack.org, Matthew Wilcox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Mel Gorman , Chris Fries , jaegeuk@kernel.org Subject: Re: [PATCH v2 0/2] Fix __GFP_ZERO vs constructor Message-ID: <20180412192424.GB21205@bombadil.infradead.org> References: <20180411060320.14458-1-willy@infradead.org> <20180412005451.GB253442@rodete-desktop-imager.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180412005451.GB253442@rodete-desktop-imager.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2018 at 09:54:51AM +0900, Minchan Kim wrote: > Matthew, > > Please Cced relevant people so they know what's going on the problem > they spent on much time. Everyone doesn't keep an eye on mailing list. My apologies; I assumed that git send-email would pick up the people named in the changelog. I have now read the source code and discovered it only picks up the people listed in Signed-off-by: and Cc:. That surprises me; I'll submit a patch. > On Tue, Apr 10, 2018 at 11:03:18PM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > v1->v2: > > - Added review/ack tags (thanks!) > > - Switched the order of the patches > > - Reworded commit message of the patch which actually fixes the bug > > - Moved slab debug patches under CONFIG_DEBUG_VM to check _every_ > > allocation and added checks in the slowpath for the allocations which > > end up allocating a page. > > > > Matthew Wilcox (2): > > Fix NULL pointer in page_cache_tree_insert > > slab: __GFP_ZERO is incompatible with a constructor > > > > mm/filemap.c | 9 ++++----- > > mm/slab.c | 7 ++++--- > > mm/slab.h | 7 +++++++ > > mm/slob.c | 4 +++- > > mm/slub.c | 5 +++-- > > 5 files changed, 21 insertions(+), 11 deletions(-) > > > > -- > > 2.16.3 > > >