Received: by 10.192.165.156 with SMTP id m28csp2337941imm; Thu, 12 Apr 2018 12:33:57 -0700 (PDT) X-Google-Smtp-Source: AIpwx49x57kKqIYeh+CCHc4r6IkMkTRqjVDw4fagwM7JcTrqrSPdoU50Z3FZLCR6xUSFZ5uPf2fG X-Received: by 2002:a17:902:6689:: with SMTP id e9-v6mr2411170plk.176.1523561637250; Thu, 12 Apr 2018 12:33:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523561637; cv=none; d=google.com; s=arc-20160816; b=gup6afHNlD++2oAj4uwyrahHFcEuaxS5CDfXTdejFX/dUYM0Dz1GNfvl0rXULFrgBj LHjfhayOGMyzQcOSBHPno/Tgk76d78xjEIyucaEoXUR8YbuWLLPE0jk8/+j0j8QWAgOG Qc50kDTsbEdxDLXIpXFBH/z37z9r+f++WttBs93CIWv2RhvimzJRWXCL7I7oabRjHYGk s5J0S1sSGJypH0lflmp4D0t0Ykrfz/TH1J0uniAqBURNZI1D6VGeejuMHyCUVBdrDO8I G7OSK6Y6SdZKTAQOiuKm740cXAY2qLFww9fxPbjIA7FoRzk0sc56y/nmqvrjF5cKMCOo rxCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=EK0TMkeESOO0DQ1o8Q6qr9SnkXlCsVbbrIeJGqV6KdU=; b=oIHqUBVhnpZhnyeQ8s85cB4yAmYWDnp2yNgFDst9VB9rc8ijNAmdpC19lP1P5Efa0x Za2NnA9TVU+nOjLuW6JA0GmH83PAsoTkQ/fo9loGK9xoX3mJqKYczTJMsVFttTKP40cf WMPDmb0sQINqEZlX3yJyC6PE1OCiD+VfGfZB1D8F/3nFHzqeGWPCHQNEp/4qwJvcwG29 0Q6toskDNN2lDwhGrOHKyo0PIrsgXjLgrw/1OWTpj8347vNR0zVXhrxL467xIeYTwRHI uvVy49mKRye6YEl/n9+ai51UUSOhy7RdFCtbrgeraNny2DxkuadbvpeBByly4tfxOXZv URRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e127si3018091pfc.315.2018.04.12.12.33.43; Thu, 12 Apr 2018 12:33:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753928AbeDLTcT (ORCPT + 99 others); Thu, 12 Apr 2018 15:32:19 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:11042 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbeDLTcS (ORCPT ); Thu, 12 Apr 2018 15:32:18 -0400 Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by g9t1613g.houston.hpe.com (Postfix) with ESMTPS id A672B61417 for ; Thu, 12 Apr 2018 19:32:17 +0000 (UTC) Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2354.austin.hpe.com (Postfix) with ESMTP id CA1451DB; Thu, 12 Apr 2018 19:32:05 +0000 (UTC) Received: from compy-386.americas.hpqcorp.net (compy-386.americas.hpqcorp.net [10.34.81.134]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 6587D39; Thu, 12 Apr 2018 19:32:04 +0000 (UTC) From: Micah Parrish To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Kieulien.Dang@seagate.com, jeffrey.wang@seagate.com, keith.busch@intel.com, pragyansri.pathi@intel.com, micah.parrish@hpe.com Subject: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage Date: Thu, 12 Apr 2018 13:25:25 -0600 Message-Id: <1523561125-31945-1-git-send-email-micah.parrish@hpe.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add Seagate Nytro Flash Storage nvme drive to quirk list for NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is probed on hot-add before the firmare is ready, I/O errors are generated while reading sector 0, and linux is "unable to read partition table". This has occurred when the drive is in an NVME drive slot adjacent to an Intel drive. Intel (Keith Busch and Pragyan Pathi) and Seagate (Jeffery Wang and Kieulien Dang) agreed to add this quirk in off-list discussion. Signed-off-by: micah.parrish@hpe.com --- linux/drivers/nvme/host/pci.c.orig 2018-04-05 13:52:23.048890019 -0600 +++ linux/drivers/nvme/host/pci.c 2018-04-09 11:20:57.432900569 -0600 @@ -2687,6 +2687,8 @@ static const struct pci_device_id nvme_i .driver_data = NVME_QUIRK_NO_DEEPEST_PS }, { PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */ .driver_data = NVME_QUIRK_IDENTIFY_CNS, }, + { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */ + .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, { PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */