Date: Tue, 19 Aug 2003 03:55:06 -0700
From: Andrew Morton <akpm@osdl.org>
To: chrisl@vmware.com
Cc: azarah@gentoo.org, linux-kernel@vger.kernel.org, adilger@clusterfs.com,
       ext3-users@redhat.com, x86-kernel@gentoo.org,
       ext2-devel@lists.sourceforge.net
Subject: Re: [PATCH] fix for htree corruption. Was: [2.6] Perl weirdness
 with ext3 and HTREE
Message-Id: <20030819035506.28f72a6a.akpm@osdl.org>
In-Reply-To: <20030819104026.GA25402@vmware.com>
References: <68F326C497FDB743B5F844B776C9B146097700@pa-exch4.vmware.com>
	<1060208887.12477.31.camel@nosferatu.lan>
	<20030819104026.GA25402@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 27

chrisl@vmware.com wrote:
>
> Martin,
> 
> The first patch should fix it. The bug is trigger by creating the index.
> Coping out the index we assume the dirents start with the first entry
> after "." "..".
> 
> It can make the first previous deleted entry reappear.
> In the past we set inode to zero for empty entry so this is not
> a problem. That is not true any more.

whee, neat, thanks.

> Andrew, I assume touch inode->i_ctime after
> ext3_mark_inode_dirty is a bug? The second patch is for that.

That's correct.

Could you please regenerate a full, single diff against a known kernel
version?  That patch generated 100% rejects for me...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/