Received: by 10.192.165.156 with SMTP id m28csp2444689imm; Thu, 12 Apr 2018 14:31:40 -0700 (PDT) X-Google-Smtp-Source: AIpwx49/4dYBpu1JwEtiVxc1hPos7foUhuWn4vLOVT+R3R2f4nmOPvoBKje+O9JkZX0EZGHolhzM X-Received: by 2002:a17:902:108a:: with SMTP id c10-v6mr2713896pla.22.1523568700174; Thu, 12 Apr 2018 14:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523568700; cv=none; d=google.com; s=arc-20160816; b=PUPJYWXb/p1dpB5mUHeTzmhU3VLnENp4QWOYEMRWaSseeJXyk7pd0iJrlbkzNndBlb /w34OX7s6alkVLtlXanS0BM1cPQvlFFQ4rgJQRUwiyVhdB8QjtxN5mmFg6yXh4yxQUnl drSpsc8CWX2diVa/BMpeHJN9vxLbPSwUqE3sZ25/APMWZg3NMEopG5tbIgepKpEgZ2u0 Osrd7T3V4ReBH7iwGHVqpkypZuAM/w+Qvp25CjgjbixBISGt1kVxyCoUYe+966qw21f+ l+4Ii3GiT/E4w29hlXnelG8WeQCoTdCyzOYqDzruN/KaVD1aZxzRwiIsXxoL1jp+tZHK VmcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=YdnoDCzxPKKTX4HCF4LoUOi/gWaFGxQQl301x9xM33I=; b=IBImkKdlbnc8J4ubPHBPbmqfQmvSwqPLoJ10sJsTanLys2oUOgdG8Ro7Vd8WOsOhnG CL//gnzNFw32qVsgBldLAPM2vB1IaEFwAyVHKUyEupFl7KFxyE8xP6/r7C2KDcSAEnET OJI9zTnjvZjnZWAPCBNr8G0nr/QQYwoHg2CgqjvLIZsu6EDeX9ikF5ZyKit0/cF7jSz8 8oJNU8Bx79FN+fzPjg2uKFRu0goXqe7AJZebY+r4sGy36t5H+BNVFB8N7W+RTlK5c0b8 AW8/UQkgE2qoPncxdeuR3Q1Dx1c9LsTzfedk6ufM/qJhFNOlO/wIfwAfuOjlFjtgVPgI CgeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=CTS3Ewng; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h33-v6si4054090plh.483.2018.04.12.14.31.14; Thu, 12 Apr 2018 14:31:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=CTS3Ewng; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbeDLV2m (ORCPT + 99 others); Thu, 12 Apr 2018 17:28:42 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:45982 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbeDLV2l (ORCPT ); Thu, 12 Apr 2018 17:28:41 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3CLM2c0138075; Thu, 12 Apr 2018 21:28:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=YdnoDCzxPKKTX4HCF4LoUOi/gWaFGxQQl301x9xM33I=; b=CTS3Ewngu818M59b+0ctT8g225g6aBQ0DeihK3izEeHfTSBW8rqJu/XwJul9mZheODIt zbfxw90YTIP1+F7g9SYqTjTWhQuq/UtY0c6Fzf2aHrU0oXGglwqfhCGEneEYGu7AtN2k GHFMuYJ9Kfn0zcIoQZ1ySEkCRuPVH0D8Lnu8p47/AQy0YkC2Pz5cqpZGQiiB1FNPVayG vgHCYUaiGwOgFgTbH4lkOnO30X775RvP0qv3MrEd0xQYmtcl7SNwPVl5NXc/wp10Mbvr rlJ39k1ADVAZtE5rFEguDQHXuXniGqTBD2zorHUT6VStSRRT1SQARRY5mv5tnNJUyNkW rw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2120.oracle.com with ESMTP id 2h6ny3p59e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Apr 2018 21:28:23 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3CLSLiT017931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Apr 2018 21:28:22 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3CLSLxT008481; Thu, 12 Apr 2018 21:28:21 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Apr 2018 14:28:21 -0700 To: Micah Parrish Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, keith.busch@intel.com, pragyansri.pathi@intel.com, jeffrey.wang@seagate.com, Kieulien.Dang@seagate.com Subject: Re: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage From: "Martin K. Petersen" Organization: Oracle References: <1523561125-31945-1-git-send-email-micah.parrish@hpe.com> Date: Thu, 12 Apr 2018 17:28:18 -0400 In-Reply-To: <1523561125-31945-1-git-send-email-micah.parrish@hpe.com> (Micah Parrish's message of "Thu, 12 Apr 2018 13:25:25 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8861 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=673 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804120203 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Micah, > Add Seagate Nytro Flash Storage nvme drive to quirk list for > NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is > probed on hot-add before the firmare is ready, I/O errors are generated > while reading sector 0, and linux is "unable to read partition table". Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering