Received: by 10.192.165.156 with SMTP id m28csp2471676imm; Thu, 12 Apr 2018 15:04:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx49c/g5k9MMduVjUD4EC0WzB8EjM06LhJQqW12ggbq4nJKW1xxn04KyhSthofRcUZmAfWk5j X-Received: by 10.98.253.22 with SMTP id p22mr9075110pfh.217.1523570670832; Thu, 12 Apr 2018 15:04:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523570670; cv=none; d=google.com; s=arc-20160816; b=ngOJWtRAplzOSZ/06VlalpTU50mHVzSzMB2vyJbF3IIRX58tGC1WrbzAft49NYWtQA 6Dg/L4L0THOpTsptjFzmdZKMPSeq3tjdu0Isfex7C5AwtboUqNhmJZUsc2Ph2gqQl3Yg 8c4oeV9bBnv5vhtAmeYOzFbrf94tvrH92WyeyV8hc1oF44X05OoJuuHmZPK9IcYh3Ak7 OcrwO5XekodD9xx+hNJ7/2+RS7VmId9VDIfjqGJQS8MoC5f+sKwez43kp2OKdB4TMunZ +b8SnNTOTeoBbpwUudcWf+Z60sx5E5HfK0Sp/WBK/PdiN0rtebx6LapNmEpDVTXur09+ 8Swg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=YXTQsrhKheqt0Zxlg5Zggud1vuVcTkMlLtNiFwL3PLg=; b=x9bpu+Ro2vmEQQOUIIrlQct7lzvx3Bt8qvfc4J1k0DY2EmL2dVueZQsM1chPLMvBR1 GLU5wnZ34yh8l7GB6pK4clGkc2nYQedwJ5OnEtGEJVWTy8POATSgruuA8avhcvxCQLTw QAkvQGz/lDCgrS9x/YY8lmtjFhLo6riPZFM45wZBEUdJyHo+GClGLT2a/f1rN5eO0Oy+ MJrSvarrJXOWQyhTU/td2mStiyJEatGvyogYzrNde8GRq6zsa3IsK1fMPZTQClMom7qc 0LjH8E30Pt4njNiIOR8vmzWdmfPprSvx4YIestkCCy2eNmktm1luIZG5QI5h7SW6jrIZ 2QPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=oIeCpzuE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si4079554plk.674.2018.04.12.15.04.17; Thu, 12 Apr 2018 15:04:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=oIeCpzuE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbeDLVVH (ORCPT + 99 others); Thu, 12 Apr 2018 17:21:07 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:41270 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbeDLVVF (ORCPT ); Thu, 12 Apr 2018 17:21:05 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3CLFnah042200; Thu, 12 Apr 2018 21:21:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=YXTQsrhKheqt0Zxlg5Zggud1vuVcTkMlLtNiFwL3PLg=; b=oIeCpzuEQmVvYsuKH09w71SrNGps8DJ3HxHGj0FgWqMg3PQa+lt4mDQZdtKgK2fUcJeg ZuVi+XaGYGPxMCMngae187RoSGtbG7xkSpCKxCwyxEzvmXXu3ScttjL6a/OmRk2Zs0jO pChLWv4Es2ZPNlKDBFeqCUOi4wVpDj0irhGzAGHwCBkn5nGPMglGUUk/dJxr3ED8+Vjj /Kz6ARVsWBV8Uk2H0LRz/ugXiiIdwkIGN4E9rbZOT2u7j/QWkbGw0Oeh8vrgrGxQV5uy xI4hlFTsFP0sh5U1O5PTcEo95bs3kpb6IUGAK6FH6ImXc7RreJ1Zm7G0Ft2VHG2GhDNF RQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2h6ne7p6dm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Apr 2018 21:21:01 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3CLKxDc029629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Apr 2018 21:21:00 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3CLKvkl024153; Thu, 12 Apr 2018 21:20:57 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Apr 2018 14:20:57 -0700 To: Jack Wang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, elliott@hpe.com Subject: Re: [PATCH v2] block: ratelimite pr_err on IO path From: "Martin K. Petersen" Organization: Oracle Corporation References: <1523524915-25170-1-git-send-email-jinpu.wangl@profitbricks.com> Date: Thu, 12 Apr 2018 17:20:54 -0400 In-Reply-To: <1523524915-25170-1-git-send-email-jinpu.wangl@profitbricks.com> (Jack Wang's message of "Thu, 12 Apr 2018 11:21:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8861 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=624 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804120202 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jack, > + pr_err_ratelimited("%s: ref tag error at location %llu (rcvd %u)\n", I'm a bit concerned about dropping records of potential data loss. Also, what are you doing that compels all these to be logged? This should be a very rare occurrence. -- Martin K. Petersen Oracle Linux Engineering