Received: by 10.192.165.156 with SMTP id m28csp149495imm; Thu, 12 Apr 2018 18:45:18 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/VfxJ7ZuUCGuhwmN58g2Zz5RUKbiAFA6FJl3iSSiItu1weKzMpAkfORKcTrTmPfUAJUOhk X-Received: by 10.99.126.71 with SMTP id o7mr2435044pgn.366.1523583918825; Thu, 12 Apr 2018 18:45:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523583918; cv=none; d=google.com; s=arc-20160816; b=tqOpkhGkwR7vU5CsNZsYuZyr4dUnV/tdWA+FJZENcCs8DZ28qJJIgaYWqn7h2SJb3l cs1qPhoz78BizqBKZtHBPXqhUfvGGjluK/vFzIUtXfhnFGg3Mc8S6BdYo/LvHtF6e0f6 tsqZEfZBFdh6RGfgP6sZnxQXoObobw0WMe0UayfywWBSaWV6+pof8e3QwSqtlhYdzgXr vEz/Nbnu/i46OzPmQNDRyk0jZ1KIL5E36zujFfGpsrJzNJEZs5wJx5AbGOvfo1rAGJkX t6xe1YcVa4WnZ0ZsixryrAdWu82wgKLuVu4LLUf32dzH5txcTfWyQuDXJmOa7qpDUABO +xOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=1BlayLRfFu+78r5GGrXeh/Qmr0IVrkjt4ObWBQ4LbMk=; b=C3JfmbcNEI/csaSlylxQHfy6rmUgdE3w2RIao+j1qNxtdB3FEKtmQw8cmtOgODSYmO YwYz6UNngl4kKCZc+VSsLRV10kPP0YYmQ+aDtIv6wwhHNcINVTtN4g8t90pvpQygi5LR 29rSxj+ySvGsQo98ONcU88ad0II6xZSO66Lyul7uKkmSCi/BMn/5U5jipT2cIk5MgXzb jVMFDoqC+Tq9pzQdlTZlfzlWnzXNKMCKJOkuWokYvaStmV9ySDpEqnO8iH5Q5a5QgroS CalNllt99ESjbRD/nebiDb4SBTY0aG+gSiH+YhwOXMGGe0XAO8/jRRo9y2EMnWEdH+18 l2Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=prFBaON8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si3061988pgq.646.2018.04.12.18.45.05; Thu, 12 Apr 2018 18:45:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=prFBaON8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbeDMAaV (ORCPT + 99 others); Thu, 12 Apr 2018 20:30:21 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:34252 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693AbeDMAaT (ORCPT ); Thu, 12 Apr 2018 20:30:19 -0400 Received: by mail-pl0-f65.google.com with SMTP id y12-v6so5038775plt.1 for ; Thu, 12 Apr 2018 17:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=1BlayLRfFu+78r5GGrXeh/Qmr0IVrkjt4ObWBQ4LbMk=; b=prFBaON8wto4cm8W9KmrUkabr+lAv1ZLlJZ0HRuGKb0+0P5nzvtPJaHj7mcdreklmG 0+7iqIFzkh+9YPcRd19QwbIbg9aDlqYvacS7UDB5KqWWOPKq59Y6lKYENyNcofzDsh2V H/JwTLDcFTG/rhSqNfPvrtjmPY8H35lcLVMIB1Ss4ML+f2ZJHIwjrB4ONaQEBlm52hkN OCjw2WNIWS0n4LkbAptwmznX5viZrcel7+2oG7y7r6E2bFJqPk0UxoepS5jviu0ZLsH4 Q5KG3Ii2H+T8bAmEVJTRCut6OAKwlIwfSjfrdzQiWZFygfAl+SPYxb5iyYbAysZ/Lzq7 VfGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1BlayLRfFu+78r5GGrXeh/Qmr0IVrkjt4ObWBQ4LbMk=; b=A828nLNaEWvoXuVETomn7VX6Z80C5TBGvDZ0KylLhO5B1c05zYGjTr5Wlxjwchz/ty RycRtYowifSufwUw7t1gqEdfKALPVdgMd0B3FINNZb271sdylSZeBhEPGquvT7rs/+oU 0BRS0a24XcqMRNZ098h/pyFX81o8lj2/3QDysrjLwTExCq2ZyDuq2XabWit/5vOblSUR QeoDSsV/V9MKRLwOTjVh6jCs+bc10rVB3ZKAy3W7XfU7NkRdLp9jY78jo5cfNKrmidYR aXgVqrUPNwI2pePHUPGrRy1fj9nGVj2N9K2etX1lUewo6/cyeSMvivj9agcAdGoI0DXA UykQ== X-Gm-Message-State: ALQs6tDBoK1ADkU55dB3iLHkcwf7doeUytxKqmAEmdF5T/uK02POcFRQ /JQ5PVeOf+kOt1lO4bIsf5Zz3g== X-Received: by 2002:a17:902:206:: with SMTP id 6-v6mr3118024plc.376.1523579418575; Thu, 12 Apr 2018 17:30:18 -0700 (PDT) Received: from hackmann.mtv.corp.google.com ([2620:0:1000:1600:2377:5409:db26:9d95]) by smtp.gmail.com with ESMTPSA id d64sm9328270pfa.80.2018.04.12.17.30.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Apr 2018 17:30:17 -0700 (PDT) From: Greg Hackmann To: Adam Wallis , Mathias Nyman , Greg Kroah-Hartman Cc: Badhri Jagan Sridharan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Hackmann , stable@vger.kernel.org Subject: [PATCH] Revert "xhci: plat: Register shutdown for xhci_plat" Date: Thu, 12 Apr 2018 17:29:51 -0700 Message-Id: <20180413002951.155762-1-ghackmann@google.com> X-Mailer: git-send-email 2.17.0.484.g0c8726318c-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pixel 2 field testers reported that when they tried to reboot their phones with some USB devices plugged in, the reboot would get wedged and eventually trigger watchdog reset. Once the Pixel kernel team found a reliable repro case, they narrowed it down to this commit's 4.4.y backport. Reverting the change made the issue go away. This reverts commit b07c12517f2aed0add8ce18146bb426b14099392. Cc: stable@vger.kernel.org Signed-off-by: Greg Hackmann --- drivers/usb/host/xhci-plat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index df327dcc2bac..ea089fdda611 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -420,7 +420,6 @@ MODULE_DEVICE_TABLE(acpi, usb_xhci_acpi_match); static struct platform_driver usb_xhci_driver = { .probe = xhci_plat_probe, .remove = xhci_plat_remove, - .shutdown = usb_hcd_platform_shutdown, .driver = { .name = "xhci-hcd", .pm = &xhci_plat_pm_ops, -- 2.17.0.484.g0c8726318c-goog