Received: by 10.192.165.156 with SMTP id m28csp551632imm; Fri, 13 Apr 2018 03:58:10 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+XlwoZ1hCT9pnnekRjmAI7E8wAAvshotye71jlX6byMrMT9lQRhUvjlb+ue9Mn9SjVCUZV X-Received: by 10.99.180.65 with SMTP id n1mr3735238pgu.342.1523617090184; Fri, 13 Apr 2018 03:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523617090; cv=none; d=google.com; s=arc-20160816; b=tPdJ3FHSzqsnRAKV9GlP/15uekOmeaIIRPooVCMrF5EF8j3wovFfPXvHjPSximZxES 9h7LOQfC9DiWMVH0Xy2xbOGn60oETxxG+Zqw/TmcdM/59RFcP9m7OcRLMLW5Q5vvAb6w Y0ORPSmUHYnXjlyK7eZH/E6LMh5ipuh37vVNdSbxqFs5Ncm9QBa2KvqySZi/rwxnlbZE N9TMvNmtXGU2tE/LP6WqemtHFalc38ytHf20Byh9Ve/VPb4asLJ3m3v7ipRceP+98brv +CkRySpwn8vl478WYWSDXWOZpAt+Fup3TqdkHNwxr8kfiPZBGDfuBWJE23B8pib0ogbA dRBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=gWh2nDj4+JnjikDwfBEHMFOz6YTkpGkk5HuoL2j746E=; b=ACEVaGJHWQWYQJbRBr35LrZd0DrcJw9lyJx1pk18bYw7MoSjrJeKD268Qs4r0wBhdZ Oy0/1MUYdc3bo+BuNExVCXf4E1jDArtUX3NpKS32EI1cYZrwZvuf/RnhHc6lcNslpa69 G4JzlAIZVB1TZD6MMByMEzkJxEUdR7lAnRcX47IW5xXgjOhfn112A+zncLPSG0QYw2Tf 0mG0C1FN8AJBkF5tUBHHAm2vZYiT5g3LrFZzq0/KIgqfZxLs+II8dML+BAYYQ6h+P6rh ubPPZrSrfpu/QCzhrs7v1mD0RybFIb2fHgplVivyAB5MxkZ69qcY6XZcunWcqnrkSfSF TwZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SFLlUphg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5-v6si5496070plo.405.2018.04.13.03.57.56; Fri, 13 Apr 2018 03:58:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SFLlUphg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbeDMKl5 (ORCPT + 99 others); Fri, 13 Apr 2018 06:41:57 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:52490 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753868AbeDMKlz (ORCPT ); Fri, 13 Apr 2018 06:41:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gWh2nDj4+JnjikDwfBEHMFOz6YTkpGkk5HuoL2j746E=; b=SFLlUphgG9U7Qa/XUtCatK0lL AMLSrNPsc7AskHENt/u0Q8TBynO9tXKAllxjX5MC89agyrDTb6UllpQJPimr2Ny2YsUKwK+JP4KUb nODZuzZomBO9nOV4+C+2Upvt6rCcLDwwoVxsJ/c+CTTio74ApgQo6YwD4/OK+MXGleLjM=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6w95-00084Z-IC; Fri, 13 Apr 2018 10:41:31 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6w94-0006IL-Vo; Fri, 13 Apr 2018 11:41:30 +0100 Date: Fri, 13 Apr 2018 11:41:30 +0100 From: Mark Brown To: Jia-Ju Bai Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, sathyanarayana.nujella@intel.com, Adam.Thomson.Opensource@diasemi.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe Message-ID: <20180413104130.GA6854@sirena.org.uk> References: <1523270781-22627-1-git-send-email-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <1523270781-22627-1-git-send-email-baijiaju1990@gmail.com> X-Cookie: You were s'posed to laugh! User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: > broxton_audio_probe() is never called in atomic context. > This function is only set as ".probe" in "struct platform_driver". Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrQiVoACgkQJNaLcl1U h9CQPwf9EQIfFL7w6d2apKyJctMJiogjpDcKmRDZkAvAXXhZLRkjYE9+JADLxpi1 s4ClYXhU1ggARiyLLXGRnWDRCYY7Fh67huCBpKkf5GDPAbC2tAvOBAtbVN9Ex50Z PFyzkOW9bENfM3RgdlXP3Sql00XrjNErjrl8Daw+STmlORzXsGLzZZDZH3owI35Z cwQ4qzqaMjB5O9EWlse1EJla911Kf6xYjVGeTQw91C4nLxg9Nm32YjBhp4iSHjqW 1AFBB2L9fmTcWaPAEgmnMlnWE6NGZBdcpXvYSvfkJbdhg0lpp0vE728pykUDmAxz rHtKyUeHTsw/59UOl5cQDGs19HtB/A== =D/7C -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--