Received: by 10.192.165.156 with SMTP id m28csp579014imm; Fri, 13 Apr 2018 04:26:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx499oghkJo+5JKBFjMIybJwe5hL+kAAZqW8V0w3/Q8/F0obuNNKAbaQRl3tIxBJ4cQkQu9ol X-Received: by 10.98.13.23 with SMTP id v23mr11229597pfi.202.1523618762593; Fri, 13 Apr 2018 04:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523618762; cv=none; d=google.com; s=arc-20160816; b=O1Lvt3JIxZMnMAbT4UnAc8S38c4E3WqjAmAPEDCjDMytV06C5ZKDzRDHbR+ydnox+Y fkraIdLtEoR2BBI8ZHmFFBTwZvizYI2IDLKpEhaxow+3meyF3Md8fj2YJRBmg6e7z0Ig xwyH+DGQxCRzG1VmOnNgW4K38u7x6kkVFs9vwz8jyX/0W2SImqs4PYpdVTep/QoNtlMn lT2TeKH8k2h+VuUhHHIwQGHFvxOHZ66DtPJmLlSh7HZaAkTw9sKidcjUXO3Ehnsqg7fz iOriIKWjg+53r2JKmSdmKAF6EGGi3/sIoDjMYFa4bZyqVWIYeoegYJwMCgtSv3h7Y0Ts hayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=aCLHdQHN6V4AyKwRwcJKQabB2Hw1Kc64nTvukEEggP8=; b=LVISMDu8t981SjwOlZB+VEIOgAoISfSmdyRU66h5poHfBsQabs0iJmsq7DvL9uUmdq c0q+DMBB74ya47k+PfHiEOGQap2Xn+I2Qu/eGnmoYW7EFZrMt5KW9CZG0UM3AlXoCmdC RxW1oa0pwQEtkQGF+KR5kBCiRYsWM3WrJB+oze7IhN/+jP11nevbCFqQTuPryPofvO7F 9Jg2MjLnvLqY/6iDiouwpYGAYz51t1jkne3gmuzXKfsWT0lJJBpVNnqNwrOxHtjOHkX7 DmzgD+SsoYWRXIy4+YGPM7nbEiLdsf5rVv6n3nDu9aa6vP006GsHWurNVOcpSSM5f327 OrBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YkPhxNLh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 142si3846115pgg.29.2018.04.13.04.25.48; Fri, 13 Apr 2018 04:26:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YkPhxNLh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636AbeDMLY0 (ORCPT + 99 others); Fri, 13 Apr 2018 07:24:26 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39522 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbeDMLYY (ORCPT ); Fri, 13 Apr 2018 07:24:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=aCLHdQHN6V4AyKwRwcJKQabB2Hw1Kc64nTvukEEggP8=; b=YkPhxNLhHO+D oXJNGTrjPC5w0kuYUnMb9rApAjGug742ielcjORhV4Wf7a39QNIpQZQbeMZFfFLwpbAUbkEUKCnOq MvzXcP4Vfg4+AUmHzOIPTowqa5vP6AwOkISNUqGgeRpCtsALcBZYKAPUoFloAoczXzDXK/sOK8ZeI ku4z8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6woO-0008Cv-6M; Fri, 13 Apr 2018 11:24:12 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6woN-0000Eh-Ns; Fri, 13 Apr 2018 12:24:11 +0100 From: Mark Brown To: Jia-Ju Bai Cc: Mark Brown , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, pradeep.d.tewani@intel.com, subhransu.s.prusty@intel.com, dharageswari.r@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: intel: bxt_rt298: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe" to the asoc tree In-Reply-To: <1523270827-22735-1-git-send-email-baijiaju1990@gmail.com> Message-Id: Date: Fri, 13 Apr 2018 12:24:11 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: intel: bxt_rt298: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From ac6c5ea121e78b4c5caef2e307d59a0e35a65a88 Mon Sep 17 00:00:00 2001 From: Jia-Ju Bai Date: Mon, 9 Apr 2018 18:47:07 +0800 Subject: [PATCH] ASoC: intel: bxt_rt298: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe broxton_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Mark Brown --- sound/soc/intel/boards/bxt_rt298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bxt_rt298.c b/sound/soc/intel/boards/bxt_rt298.c index c7e9024e65ef..b68c289558a8 100644 --- a/sound/soc/intel/boards/bxt_rt298.c +++ b/sound/soc/intel/boards/bxt_rt298.c @@ -593,7 +593,7 @@ static int broxton_audio_probe(struct platform_device *pdev) } } - ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC); + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); if (!ctx) return -ENOMEM; -- 2.17.0