Received: by 10.192.165.156 with SMTP id m28csp600735imm; Fri, 13 Apr 2018 04:50:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx49qkBh3LSOS32zLQBFkC3UgUm1vgeeD4Xk+x3XnEjyi5FAkBO/+8SUAiwDcEB8Xh4bhqdGB X-Received: by 2002:a17:902:2805:: with SMTP id e5-v6mr4956554plb.89.1523620206064; Fri, 13 Apr 2018 04:50:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523620206; cv=none; d=google.com; s=arc-20160816; b=I09VYcHPBTwhUghaE/7F0d7rue+lUzrvyIQlgfPlAvdMgcxYzDMI/FsIIuKQFPmsa4 ccHwASTGOKEsOyXrJa/FvQdJ3lI1rJTa+Li5/wkvK9uc57Oj5S4ZVRZh9wxOD9RJUuXb QZ7IstElFETFS/OEe5p+P9G5k81KctjPOxuKtbIfWoPqd5a8r1ELsAdCgVdiDCg1t46w wObWg5oMPKcfKCQW+bRkrrDxf6psfa/b+12esSfd5wkrK9F7+IIT+jN1EVGHOqqOWYYc wBlxl9Cizvq/P1vnY7zfVVdddQABNEyuNQ2gApzGtU4GQcaAo0gMQ/tqDTjq1rz8kUym /TBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=uhEQeUcU3gLCthtvObDL9hhvf7SmTpVi9lQ20m9Bi18=; b=N3O0JwPs+ZVzw7lAMdemDXUCHGFgrpFse70cmUo/gUArLfuWKqbFM7nvCldyIraVwd eXh8F4s05J1ze0seqUFS9W6zjJ6afmKgAIpwJ9p5Hf1+NRUuNd0cXZxVnylRQ8nNnpaB MfT9NoUkb7LZNIJ7bsVYmTrjMGDYrgj+/QjpBuMNFQU+kdY8rXGK6KAuR5sVBfX1GtGh ii4RInTZWzPhQCIyUQZlz9HK7aZrEpDcA1L6CIt3GUOS4NJLQnnEYG0G5/R4UFRh4BH8 o9QZrups2FVewjZFaP80B08VsGfaQtnOeyIQV4pUclDr3qDpN/DIQZ1Cu882+lJQU4DM 68Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QU8ee9la; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m14si3981289pgt.287.2018.04.13.04.49.52; Fri, 13 Apr 2018 04:50:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QU8ee9la; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754340AbeDMKyg (ORCPT + 99 others); Fri, 13 Apr 2018 06:54:36 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:37056 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbeDMKyf (ORCPT ); Fri, 13 Apr 2018 06:54:35 -0400 Received: by mail-pg0-f66.google.com with SMTP id r14so1772500pgq.4 for ; Fri, 13 Apr 2018 03:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=uhEQeUcU3gLCthtvObDL9hhvf7SmTpVi9lQ20m9Bi18=; b=QU8ee9lakdDmcavLJOiC6vyKJ7W2kqaAW+i/ZqizmRVa6l6p5F3cRUG5ezQn77v2Xa Wqtr+8ORTNveWvEBqCwxl/7rAZmbOksN7wWxOxFgjTj9exebzE7RROz3SljZXksAOehP 7Lu/9uOZ2lwNEfPI+1SkJyIWdTlXCSkqU+H6WNbTRErmRoAkTkfXRTD4v3eS27yIfvIW d6KtQQhEyzCCHi4aOVLwbyUn0QXxQ1licNO7DQNoDc9bm1F8Zk394+VafaE4Hxo1meZq J5y+q4oWPXBvhk8RMwnjz3NNs1xBCr9sO1RCL+fwssndSJY5101ocCvBlr8y0zbx4W14 xcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uhEQeUcU3gLCthtvObDL9hhvf7SmTpVi9lQ20m9Bi18=; b=VWz2t/62SeAokmbnq6PFG+20P/p7L9iIy6cTpR03P/8EVpvf7QqP4mL4LdGDLuFtbK wyVBLsD7hqOEd+LoakROeIlufRYpa/JfDhoSgzZGKOBOvMhweG5PdWmpwpsG4guv+/HO KJZDSYQ84OCXJcWJ7q9NMlKSfETaHlMgVRzVaC+X4DCYbb+qN2cAWVnOVsvxq9vXmArx jrxR3H2XRACwShf+POt9UurUFMvZmI4jPi8DIupFwdfdy18T2SQKrTzTWnL85srJwvu4 1QrhcfDhjLtzNUALjObzejzG9rz1umTmw5M5v4evP3AGl4JTmTatpgNG+sRo6Av7DmF0 c24A== X-Gm-Message-State: ALQs6tD/0Ct6FLj9ktTeNfYRrKw1rfVdnh8I9k4Q/R6xNgggWc7+hY4/ TRba52sr9tOImXaSZ5KN+1byktQE X-Received: by 10.101.102.211 with SMTP id c19mr3678013pgw.78.1523616874767; Fri, 13 Apr 2018 03:54:34 -0700 (PDT) Received: from ?IPv6:2402:f000:1:1501:200:5efe:166.111.70.38? ([2402:f000:1:1501:200:5efe:a66f:4626]) by smtp.gmail.com with ESMTPSA id q62sm16658655pfd.61.2018.04.13.03.54.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Apr 2018 03:54:34 -0700 (PDT) Subject: Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe To: Mark Brown Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, sathyanarayana.nujella@intel.com, Adam.Thomson.Opensource@diasemi.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1523270781-22627-1-git-send-email-baijiaju1990@gmail.com> <20180413104130.GA6854@sirena.org.uk> From: Jia-Ju Bai Message-ID: <32138b5e-843b-3f37-28ee-62d7fa93f0db@gmail.com> Date: Fri, 13 Apr 2018 18:54:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180413104130.GA6854@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/4/13 18:41, Mark Brown wrote: > On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote: >> broxton_audio_probe() is never called in atomic context. >> This function is only set as ".probe" in "struct platform_driver". > Please submit patches using subject lines reflecting the style for the > subsystem. This makes it easier for people to identify relevant > patches. Look at what existing commits in the area you're changing are > doing and make sure your subject lines visually resemble what they're > doing. Oh, sorry for my improper subjects. Thanks for your very helpful advice :) I looked at previous related patches, and find the subject should be "ASoC: Intel: ...." I will follow it in my future patches. Do I need to send V2 patches? Best wishes, Jia-Ju Bai