Received: by 10.192.165.156 with SMTP id m28csp655034imm; Fri, 13 Apr 2018 05:46:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+kdzL5aoLYhu9ltcNYxWrOotnf/EP5sIQX+Z7I45qYFW1F+11zuzcFvwYFUCZFIyEif68u X-Received: by 2002:a17:902:68c2:: with SMTP id x2-v6mr5155998plm.129.1523623572916; Fri, 13 Apr 2018 05:46:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523623572; cv=none; d=google.com; s=arc-20160816; b=VC/MxfhoZtO3H98zqUIL4HXDLUyGhxFvn+u4xoZ13CHRYOqF8X8UuUDmm1Mob4IGgR XYzTLXQX4O2WH9AAPL7KXdHF0aCnNErKq3d6wcCz0Ny+gC4nUb+JYrYbEKMHYzpu4xBY 0LZzoMdSMrtFB5mptkKfz5sUs9lO0YpBlVQHeTHhULDiPPxeVosKFIFl5RRv4iJkG01G SLT4kg6qI5EYMhRQO5sjzXyEBtXlumvdTspglaSO55M9qZczcIFC1u2AQQG8MmOw3hC4 9uQfoHVXJFm/WmOyONCEa6gRc7So2MCIDZ2dTYwAApSQgesvrorgykNrGh+kZn0DSDvi iSFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=FXTs886QXUY9IswYjBpX+H3WgZM19xnJFMq5dI1f5CQ=; b=hGdgcd4DfrbSpdYlGeJSBsLOrFuQVIwcK+UlrLA6uNlvBsrn/Sv0fnJO/TmCTj7rn6 07hEc8SoM0JwOmdm3RKyYcNdPPIAqsL+DRja2kj+0vR07c+mDDHjxwoX+wnqkkmRBLC0 xR1ZV8OpHFxHzoRDFaBCha9idb5laqNhdXV9J2ZWNoTam8TB5KEtc7OVJiH5INckfa39 RRxqlb/I35bo27DGv0g08aWs6z+bFpOg7ZimDRbKYn8XYU0DNRVMN6EYXmFsu/8eH4kN 8AVjK6/JmDDgPCNKuDPAZBgdSrAs2GhKXjWadCyWtDpB2Ed7v17fM7vKxqi/vhgzT4IX E1uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=a7UDilwg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay8-v6si5207342plb.554.2018.04.13.05.45.58; Fri, 13 Apr 2018 05:46:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=a7UDilwg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbeDMMAK (ORCPT + 99 others); Fri, 13 Apr 2018 08:00:10 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:34884 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754255AbeDMMAG (ORCPT ); Fri, 13 Apr 2018 08:00:06 -0400 Received: by mail-qt0-f170.google.com with SMTP id s2so7711737qti.2; Fri, 13 Apr 2018 05:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FXTs886QXUY9IswYjBpX+H3WgZM19xnJFMq5dI1f5CQ=; b=a7UDilwg4+RCN0aHLwFwXyY0tU6/X5XViIgbo0IFNdkaNGsiuJ6ixv/VYWmWrpPlGm 6JPEYGb3WUAJQRjkfjCXEy3+x/mO3xJ6HFrDMyybVuEr7J2On0YW/G1vQ5E0U4OGP+RU TGTJoGIt03u5768x8uPUZVaL0vWbXtMApi00fMg7TDAsiGnq+p0kiqO10QZFfj9Jye+i AZZKt7UeiGQ2Y2GiH71OTcgdETa492Gn8tESn2Os3YT4ZWeWzz+QzT/DJX808q95IauR FCtkVpngv47e+8axTj/J2zgnqinHfzrodKKhBxKPNXLjOF9FDEH4qPeSm31bfrtiSaSI S/4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FXTs886QXUY9IswYjBpX+H3WgZM19xnJFMq5dI1f5CQ=; b=ggiNJMFgkY3inszH3cFexfsWFjR9kurSIxnUqVGySEP0MaeuOwyvKl/YLyZpD/+AGH IQ9KmVuzl54yMCRoGTp0tPLJOQX1OI+zAX9HU8KYKl9Te0LwcRf5hLTtcHbcVi3va8X8 q7vvmSv11g5I6HNjRYLaFf+oHCMEg3xdbabL+3YjJ6FrWJv2DwjVvy2+f7RcKwxLV9Cv DSY3zIVveopF9nf3joI4cA9A9cCK90tBzIf+OpVoISJ7iAhADapw1vcW5nmrXHqMHs0q 1jsm8kzRkMqdheGTBQKRlg3FQ7PAJ7aP8NVz4TV0Ei885NUGkVCiBI+HqlBf0iEY04nY zLCw== X-Gm-Message-State: ALQs6tCoIB5mQVK32ofPiq3Da8nDYZYW27XLrAZghkY29akEzUHdKURn 5Eq/KXaSCMUKMTjH4+kS9qjqduVn+4Gk3qtcZa8= X-Received: by 10.200.23.213 with SMTP id r21mr2811088qtk.314.1523620805416; Fri, 13 Apr 2018 05:00:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.200.134 with HTTP; Fri, 13 Apr 2018 05:00:04 -0700 (PDT) In-Reply-To: <20180411124325.youvfpws27l2wesf@flea> References: <20180411124325.youvfpws27l2wesf@flea> From: Jagan Teki Date: Fri, 13 Apr 2018 17:30:04 +0530 Message-ID: Subject: Re: [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support To: Maxime Ripard Cc: Thierry Reding , Chen-Yu Tsai , Mark Rutland , Rob Herring , Frank Rowand , dri-devel@lists.freedesktop.org, Gustavo Padovan , Daniel Vetter , Maarten Lankhorst , Sean Paul , devicetree , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2018 at 6:13 PM, Maxime Ripard wrote: > On Wed, Apr 04, 2018 at 11:57:08AM +0200, Maxime Ripard wrote: >> Hi, >> >> Here is an preliminary version of the MIPI-DSI support for the Allwinner >> SoCs. >> >> This controller can be found on a number of recent SoCs, such as the >> A31, A33 or the A64. >> >> Given the sparse documentation, there's a number of obscure areas, but >> the current implementation has been tested with a 4-lanes DSI panel on >> an A33. >> >> The support is a bit rough around the edges at the time, and some artifacts >> are still shown on the screen for some reasons. Wider testing with >> different display will hopefully nail those down. >> >> This needs the regmap_mmio_attach_clk, on its way to Linus in 4.17. >> >> Let me know what you think, >> Maxime >> >> Changes from v3: >> - Rebased on top of current drm-misc-next >> - Switched to SPDX license header >> - Made the ECC array const >> - Split the big DSI patch into two, one to add the DSI driver and one to >> add the TCON bits. >> - Removed the dithering code >> - Changed the DT labels to remove the indices >> - Used sleeps instead of delays in the panel driver >> - Used the backlight_enable / _disable functions >> - Added Chen-Yu's Reviewed-by >> >> Changes from v2: >> - Added a ports node under the DSI node >> - Changed the huarui panel driver to an ili9881c driver >> - Changed the panel vendor to bananapi >> - Made the init table static in the panel driver >> - Dropped the huarui vendor patch for the DT doc. >> >> Changes from v1: >> - Rebased on 4.16-rc1 >> - Constified a few function arguments and structures >> - Reworked the DT binding example a bit >> - Reworked the panel driver to check for DSI return codes, and use DCS >> helpers when possible >> >> Maxime Ripard (8): >> drm/sun4i: tcon: Add TRI finish interrupt for vblank >> dt-bindings: display: Add Allwinner MIPI-DSI bindings >> drm/sun4i: Add Allwinner A31 MIPI-DSI controller support >> drm/sun4i: Tie the DSI controller in the TCON >> dt-bindings: panel: Add the Ilitek ILI9881c panel documentation >> drm/panel: Add Ilitek ILI9881c panel driver >> ARM: dts: sun8i: a33: Add the DSI-related nodes >> [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display I have reviewed most of the patches and reused for A64 all look fine to me (except the panel driver). May be my issue is not relevant to this thread, but I'm looking for help If I miss anything for A64 [1] and [2] are changes made for A64, the issue is kernel hang while loading sun6i_dsi. Log: # modprobe -a sun6i_dsi [ 18.798684] sun6i-mipi-dsi 1ca0000.dsi: Attached device ts8550b [ 18.819628] sun4i-drm display-engine: bound 1100000.mixer (ops sun8i_mixer_ops) [ 18.827336] sun4i-drm display-engine: No panel or bridge found... RGB output disabled [ 18.835200] sun4i-drm display-engine: bound 1c0c000.lcd-controller (ops sun4i_tcon_ops) [ 18.843246] sun4i-drm display-engine: bound 1ca0000.dsi (ops sun6i_dsi_ops [sun6i_dsi]) [ 18.851263] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 18.857878] [drm] No driver support for vblank timestamp query. << hang here >> [1] https://github.com/openedev/linux-openedev/commit/9030929673b21971ff77b7593e88c26e84ed3742 [2] https://github.com/openedev/linux-openedev/commit/725afe3ce4507fa975fcb4a04b1bbb90d9d44a91 Jagan. -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.