Received: by 10.192.165.156 with SMTP id m28csp790283imm; Fri, 13 Apr 2018 07:54:25 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/bYAb4NXJRk8HmH4FTFhy1Fyono3mIc3XD0S3npAo5jsMyrLOuYWkxHpKH+gk26m+/X+D6 X-Received: by 10.101.81.11 with SMTP id f11mr776550pgq.137.1523631265808; Fri, 13 Apr 2018 07:54:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523631265; cv=none; d=google.com; s=arc-20160816; b=svSc1asJLXtLOFntJjU56tKh9gY+VI9S0kxsDpfpC28aEsCfZgM8vmvpjlvJaRtnU/ 1NRd/sKI0qOnPZOHQpYSutqpLXBJk0oa/0oz7aLdq06fRKUu1aWf+cIFepcmQxgw2Ze7 fraHmiFHhewhRoPFSbalm5pz/18Jt8qRPfvPBXMYd+iiiMldRrr6b5N0kfGXdNz2e1pW JjNdHvmXJHkUHUDydMcGFvnMXt2zLhaIS0CSt/OK8XLS/Nc0TcjUU3+ofDqLTouX3257 UDA4z+gwID5pB7OVwzFV7s6tc+3aA2bJChrUYbo45ffYo2JB1/vyNLPQrUAJWCj1M5G5 m/UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=le7YiWhxiGn0Km3iZNS22NcuqB68Yr2YJKt7aqt+YQY=; b=c0dAboUm3+m6j/J7w1MpLvDU03JYeluFIIEMQr9mY/S0qFrQNvOfvgqUYWk7AuNkTX +Yvql3qpDkFnSUPzDU/OTfBDSlMvxvBPh0m0rxBtAY6am5j1YVrGsOLqq6AhryopTq1e i7XaIT7as5GhzUH3yP+rMU5WCzXHMs7FOIGXd74jKcDi09TH7IwDiUwvF4iPGL8q5UUf PPrQbE+cxJxonR20+2Qqk+YcAxW23UgvGIE0uU2RcmCMjmeH+SrYmlGFNnJng2aQ5T+N 0loQBKlPlEeeURSBviWLu5uepRxJkBv97BOiyB7VwIOWSxty0rk+Xj+nLhIPZe/Q36MS jujg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay5-v6si5419523plb.208.2018.04.13.07.54.11; Fri, 13 Apr 2018 07:54:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbeDMOq1 (ORCPT + 99 others); Fri, 13 Apr 2018 10:46:27 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751091AbeDMOq0 (ORCPT ); Fri, 13 Apr 2018 10:46:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 317E54040856; Fri, 13 Apr 2018 14:46:26 +0000 (UTC) Received: from [10.36.116.23] (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF8D2DEECD; Fri, 13 Apr 2018 14:46:20 +0000 (UTC) Subject: Re: [PATCH 0/2] drm: Make it compilable without CONFIG_HDMI and CONFIG_I2C To: Daniel Vetter Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , dri-devel , borntraeger@de.ibm.com, Farhan Ali , Linux Kernel Mailing List , Gerd Hoffmann References: <1523612456-14827-1-git-send-email-thuth@redhat.com> From: Thomas Huth Message-ID: <8ad514ec-7126-30d7-1c3f-332b6e574764@redhat.com> Date: Fri, 13 Apr 2018 16:46:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 13 Apr 2018 14:46:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 13 Apr 2018 14:46:26 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.04.2018 16:32, Daniel Vetter wrote: > On Fri, Apr 13, 2018 at 11:40 AM, Thomas Huth wrote: >> By enabling the DRM code for virtio-gpu on S390, you currently also get >> all the code that is enabled by CONFIG_HDMI and CONFIG_I2C automatically. >> This is quite ugly, since on S390, there is no HDMI and no I2C. Thus it >> would be great if the DRM code could also be compiled without CONFIG_HDMI >> and CONFIG_I2C. These two patches now refactor the DRM code a little bit >> so that we can compile it also without CONFIG_HDMI and CONFIG_I2C. >> >> Thomas Huth (2): >> drivers/gpu/drm: Move CONFIG_HDMI-dependent code to a separate file >> drivers/gpu/drm: Make the DRM code compilable without CONFIG_I2C > > What's the benefit? Why does I2C/HDMI hurt you? Why should I be forced to compile-in subsystems that do not make any sense on this architecture? It's just completely weird to see CONFIG_I2C enabled on s390x. Thomas