Received: by 10.192.165.156 with SMTP id m28csp903103imm; Fri, 13 Apr 2018 09:46:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/NWTlKuIhnMwofdTvVm5PEWudG8TOQj3zwsMoYfu0DTJ9+i3/hHJ6VFZQGkuaFCjqQ9b1S X-Received: by 10.98.209.92 with SMTP id t28mr4248623pfl.249.1523637993170; Fri, 13 Apr 2018 09:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523637993; cv=none; d=google.com; s=arc-20160816; b=mJoJckF6vUCfaIfLM17PqxE8suARAAhEWrC7hyQcxaWiOef3Gb5gjI2bkUIcFZIVb0 45rCGYqGKLHHZF4pPqg75CfuHzyxam0O1AJAR5jPC6ToXHWDqaamBq1L5nR7vOXbtl4l z1qd65eVES/t6Qqodzx0gfQ8K+ZxYAXiXG1vcAkV6ykXDX8goHwyM2BUlzljXrIVySdv +7EojS8BXm4AeffbQBT1PM3/oLc3KipyG7FYIj+1w45tJVu5HW2Jvvlx1zVJolvmFCyD 3vFBmjyU267sIFCd1esiWxa2D4Bc24gObaUIzx9n+qixqz74hUT8ELC7VdWJSORMp90s qG0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=BrWc0WM2F5pjg0eSmM854FBPqQsrSonuiC/M7Ae1v9w=; b=g9ukPiIhlmwSJfdm549LWV6idQ34tQ7WuYUng7M1TjnHT0TlM1zNb2FI6wNRs7kZlf FVUbRVUDmSFAEUTfehOx5zLW7+2CEDYsngylXFzQiE4XirpJFDHK5L4cyFpGA4/dXt4s vpH3p3vFN3QkGKZ6LUjN0JXeNihB9Ma7XJt5bMWdgXotJ0Y+mkWUWLF3rokw7/YDrxa9 89T+1ypWznI3kqLIhCGCktZn0EVE+LXx8wWBTl/7Bkl3md/XBKAuOphwVOvudVg5+PiV hpKxpT+Vy74CmrseQDZr8BvrxFkUF4g2gcQqYIomCVWWqavVfFecSf1EWE22pnmOCyQI XCmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=TBeJiaZl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j73si4344117pgc.142.2018.04.13.09.46.18; Fri, 13 Apr 2018 09:46:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=TBeJiaZl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbeDMQpJ (ORCPT + 99 others); Fri, 13 Apr 2018 12:45:09 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:51926 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbeDMQpH (ORCPT ); Fri, 13 Apr 2018 12:45:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BrWc0WM2F5pjg0eSmM854FBPqQsrSonuiC/M7Ae1v9w=; b=TBeJiaZlyHs/CX/gRX1QDBYIE 6A++Zrb9ix+It4YQRQNt0gA3aGsbDI0qCcLThpc9nUDgfGGtZKT/EbzwuR7FRzq+5Pj+kwW5mQUB0 5IK6qUULOewdsnNJMGjB/caWCUnloTgTUjUhgDUu1raM/dknDrvXgLWXhGUuS5rgvvNWMtOLFCdHd iTrXzuj7go9bkOjOaXgA6AfqlX8no56KzgaQzw/FdzoHuRQWc9D7hoJM7MsoS/N7Fj3hLye+fwu2c vws3i3YcqfHz6C/i/nKZTw256X0MdKeiGgdvmzh79lcQx3caWisMoBzSoyntf/bCstoEHuP225by3 nUNJuQVKA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1f71ou-0000yB-RM; Fri, 13 Apr 2018 16:45:04 +0000 Subject: Re: [PATCH 1/6] fs: use << for MS_* flags To: Christian Brauner , viro@zeniv.linux.org.uk, tglx@linutronix.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, pombredanne@nexb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, serge@hallyn.com References: <20180413161126.31313-1-christian.brauner@ubuntu.com> <20180413161126.31313-2-christian.brauner@ubuntu.com> From: Randy Dunlap Message-ID: Date: Fri, 13 Apr 2018 09:45:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180413161126.31313-2-christian.brauner@ubuntu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2018 09:11 AM, Christian Brauner wrote: > Consistenly use << to define MS_* constants. > > Signed-off-by: Christian Brauner > --- > include/uapi/linux/fs.h | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h > index d2a8313fabd7..9662790a657c 100644 > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -105,22 +105,23 @@ struct inodes_stat_t { > /* > * These are the fs-independent mount-flags: up to 32 flags are supported > */ > -#define MS_RDONLY 1 /* Mount read-only */ > -#define MS_NOSUID 2 /* Ignore suid and sgid bits */ > -#define MS_NODEV 4 /* Disallow access to device special files */ > -#define MS_NOEXEC 8 /* Disallow program execution */ > -#define MS_SYNCHRONOUS 16 /* Writes are synced at once */ > -#define MS_REMOUNT 32 /* Alter flags of a mounted FS */ > -#define MS_MANDLOCK 64 /* Allow mandatory locks on an FS */ > -#define MS_DIRSYNC 128 /* Directory modifications are synchronous */ > -#define MS_NOATIME 1024 /* Do not update access times. */ > -#define MS_NODIRATIME 2048 /* Do not update directory access times */ > -#define MS_BIND 4096 > -#define MS_MOVE 8192 > -#define MS_REC 16384 > -#define MS_VERBOSE 32768 /* War is peace. Verbosity is silence. > - MS_VERBOSE is deprecated. */ > -#define MS_SILENT 32768 > +#define MS_RDONLY (1<<0) /* Mount read-only */ Why not just use BIT(n) instead? #include #define MS_RDONLY BIT(0) /* Mount read-only */ etc. > +#define MS_NOSUID (1<<1) /* Ignore suid and sgid bits */ > +#define MS_NODEV (1<<2) /* Disallow access to device special files */ > +#define MS_NOEXEC (1<<3) /* Disallow program execution */ > +#define MS_SYNCHRONOUS (1<<4) /* Writes are synced at once */ > +#define MS_REMOUNT (1<<5) /* Alter flags of a mounted FS */ > +#define MS_MANDLOCK (1<<6) /* Allow mandatory locks on an FS */ > +#define MS_DIRSYNC (1<<7) /* Directory modifications are synchronous */ > +#define MS_NOATIME (1<<10) /* Do not update access times. */ > +#define MS_NODIRATIME (1<<11) /* Do not update directory access times */ > +#define MS_BIND (1<<12) > +#define MS_MOVE (1<<13) > +#define MS_REC (1<<14) > +#define MS_VERBOSE (1<<15) /* War is peace. Verbosity is silence. > + * MS_VERBOSE is deprecated. > + */ > +#define MS_SILENT (1<<15) > #define MS_POSIXACL (1<<16) /* VFS does not apply the umask */ > #define MS_UNBINDABLE (1<<17) /* change to unbindable */ > #define MS_PRIVATE (1<<18) /* change to private */ > -- ~Randy