Received: by 10.192.165.156 with SMTP id m28csp905320imm; Fri, 13 Apr 2018 09:49:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/HjUFPZa+MLKlczJxyh/wWaUWLFB3S16xuBOfms+nFPM35FM8AAbhjJB9CNFPQr4sFv+xf X-Received: by 10.101.64.201 with SMTP id u9mr4791296pgp.142.1523638147659; Fri, 13 Apr 2018 09:49:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523638147; cv=none; d=google.com; s=arc-20160816; b=RO9AbwOBZUFvY3NcOi4hmiyiMbI2MzxSEgUIu6CTjrbQ3jaietEZjfHspc31kbFgKx KEKyoRvLbgIbcNN9kJN1YWZqUxD4Ed2AK5V5bqCR31u0e1PVcqNXDe8TLAyOr8yPBIfT rVa9doxsGNEywAHayhJ4T8Al6TMzL+4DTlivo0W1c1SWQSZX89L3WJRp+kEN8suQEEWW Tdc1iBtsNLSpzy/KTahEu6NCdLyauzHMgXeAc7HAT6DvfqZ0Zb6ZP7QE6Oe63GDqAyS8 E6eYwqmo9RXvuPTZ9vyzIZBGlY30AnE8O2s5ljUd4HZjchyCEOjWTTRKQ5VKNvQ5LKk+ 4UQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=/To355o1r3uvE/0MnTVDKGbnuQ+zsoLDPUUU9RfpvwQ=; b=xdsl27NkNsw7nmez4b8yp9EsgJu7AS3EYZpUrhDeXMUtx6C3EDQQLSWNroksops09B m7QX9JhxdeZwEgkolaM8oFJ5/8VznN9TzzdhZKquOtdHXb1aAA5j0qq7VMAz5UCBF77k dvvTyqVK2dMeN5myI+RaVRAWaQTEtAtuCeqqv7oDr4zsuqyBF0afdUNYxzCiBnzT8/qw d8mdN9mDwXGpnVAiET1q8flmWS0qjuF17Svd0m4OHKD1IhYB/mhEeQjAIhHqMFtGTm4K Lz4OXl0NcphIFRe0u2LTea92rEGSZzA0h6ZyozMgIh6qYGRLu3DEmmdm6kG8jbofR+YK 72DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=I7wvFRjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16-v6si6038759plr.141.2018.04.13.09.48.53; Fri, 13 Apr 2018 09:49:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=I7wvFRjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbeDMQrv (ORCPT + 99 others); Fri, 13 Apr 2018 12:47:51 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:52288 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbeDMQrs (ORCPT ); Fri, 13 Apr 2018 12:47:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/To355o1r3uvE/0MnTVDKGbnuQ+zsoLDPUUU9RfpvwQ=; b=I7wvFRjzEUOUciKr+JKflnLRU e2ysb86gsP2EhoJMpl+EPv+EDJj4r+ukZaPpa3jPRc28NP9A/fypQgl/Q05qUq1g800XrABuDBuq/ ToaLl3zp1I2HcDq7VxpsSAH1iFdOSv+TDEXTkDj/1/JqvAyQXsGo2BV/1mkYLuVoOIOPCRfZ7PR3y /QsZyMj/7tEAd2F4Rp3lAULRCFJJvqxmFOlb3cc34t4vRr8WVc5jO1F4Ed/gwFaNUNbZctZsIBWCU zc3b6BqdEu9jxU8qnvwfxLYu2/GV9/QWr6hsoc14MHppDoSSrAWMYIh/SmP+TPzxXJMufwl/frNjO Je0DHzxng==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1f71rX-0002Ko-SN; Fri, 13 Apr 2018 16:47:47 +0000 Subject: Re: [PATCH 2/6] statfs: use << to align with fs header To: Christian Brauner , viro@zeniv.linux.org.uk, tglx@linutronix.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, pombredanne@nexb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, serge@hallyn.com References: <20180413161126.31313-1-christian.brauner@ubuntu.com> <20180413161126.31313-3-christian.brauner@ubuntu.com> From: Randy Dunlap Message-ID: Date: Fri, 13 Apr 2018 09:47:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180413161126.31313-3-christian.brauner@ubuntu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2018 09:11 AM, Christian Brauner wrote: > Consistenly use << to define ST_* constants. This also aligns them with > their MS_* counterparts in fs.h > > Signed-off-by: Christian Brauner > --- > include/linux/statfs.h | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) Lots of opportunities to use BIT(n) macro. Is there some reason not to do that? > diff --git a/include/linux/statfs.h b/include/linux/statfs.h > index 3142e98546ac..b336c04e793c 100644 > --- a/include/linux/statfs.h > +++ b/include/linux/statfs.h > @@ -27,18 +27,18 @@ struct kstatfs { > * ABI. The exception is ST_VALID which has the same value as MS_REMOUNT > * which doesn't make any sense for statfs. > */ > -#define ST_RDONLY 0x0001 /* mount read-only */ > -#define ST_NOSUID 0x0002 /* ignore suid and sgid bits */ > -#define ST_NODEV 0x0004 /* disallow access to device special files */ > -#define ST_NOEXEC 0x0008 /* disallow program execution */ > -#define ST_SYNCHRONOUS 0x0010 /* writes are synced at once */ > -#define ST_VALID 0x0020 /* f_flags support is implemented */ > -#define ST_MANDLOCK 0x0040 /* allow mandatory locks on an FS */ > -/* 0x0080 used for ST_WRITE in glibc */ > -/* 0x0100 used for ST_APPEND in glibc */ > -/* 0x0200 used for ST_IMMUTABLE in glibc */ > -#define ST_NOATIME 0x0400 /* do not update access times */ > -#define ST_NODIRATIME 0x0800 /* do not update directory access times */ > -#define ST_RELATIME 0x1000 /* update atime relative to mtime/ctime */ > +#define ST_RDONLY (1<<0) /* mount read-only */ > +#define ST_NOSUID (1<<1) /* ignore suid and sgid bits */ > +#define ST_NODEV (1<<2) /* disallow access to device special files */ > +#define ST_NOEXEC (1<<3) /* disallow program execution */ > +#define ST_SYNCHRONOUS (1<<4) /* writes are synced at once */ > +#define ST_VALID (1<<5) /* f_flags support is implemented */ > +#define ST_MANDLOCK (1<<6) /* allow mandatory locks on an FS */ > +/* (1<<7) used for ST_WRITE in glibc */ > +/* (1<<8) used for ST_APPEND in glibc */ > +/* (1<<9) used for ST_IMMUTABLE in glibc */ > +#define ST_NOATIME (1<<10) /* do not update access times */ > +#define ST_NODIRATIME (1<<11) /* do not update directory access times */ > +#define ST_RELATIME (1<<12) /* update atime relative to mtime/ctime */ > > #endif > -- ~Randy